Problem: Missing swap functions #303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigiesec
reviewed
Apr 2, 2019
Member
sigiesec
left a comment
sigiesec
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
Just one general remark for future changes (you don't need to change this know): Please try to keep independent changes in separate commits. Here, the changes relating to the swappability, and the other changes are independent from each other.
Pull Request Test Coverage Report for Build 182
💛 - Coveralls |
sigiesec
reviewed
Apr 3, 2019
Solution: Implement for socket_t, context_t, message_t and poller_t Additionally remove dependency on <functional> by refactoring poller_t and remove unused <unordered_map> include.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution: Implement for socket_t, context_t, message_t and poller_t
Additionally remove dependency on
<functional>by refactoring poller_tand remove unused
<unordered_map>include.