Upgrade libzmq 4.2.0 #90
Conversation
| 'libraries': [ | ||
| '<(PRODUCT_DIR)/../../windows/lib/libzmq', | ||
| 'ws2_32.lib', | ||
| 'iphlpapi' |
There was a problem hiding this comment.
Given I have no background on this, it looks like someone fell asleep on the keyboard to name this.
There was a problem hiding this comment.
lol. IP Helper API. https://msdn.microsoft.com/en-us/library/windows/desktop/aa366073(v=vs.85).aspx
A good example of how adding an 'e' to make a human readable name would have been a solid idea. iphelpapi would have been better than iphlpapi.
Overall, I think the addition here is fine.
There was a problem hiding this comment.
Yep it's needed otherwise the build would fail
|
Im glad this leaves room for building from source on Windows. |
|
@lgeiger Wow! Lots of good work here. I didn't do a line-by-line review rather a quick scan. I would say merge it. |
|
@willingc |
|
💯 to humility @lgeiger. |
3 participants
This also simplifies the build script and move the essential stuff to cross platform js.
It will make it possible to build libzmq from source on windows if someone writes a batch script handling the build.