Skip to content

Changed order of arguments to spherical_harm#969

Merged
zerothi merged 2 commits intomainfrom
scipy-1.17-deprecations
Jan 15, 2026
Merged

Changed order of arguments to spherical_harm#969
zerothi merged 2 commits intomainfrom
scipy-1.17-deprecations

Conversation

@zerothi
Copy link
Owner

@zerothi zerothi commented Jan 15, 2026

Since scipy 1.15 the sph_harm has been deprecated
in favor of sph_harm_y (with changed argument order).

Now sisl obeys the same order of arguments.

Since scipy 1.15 the sph_harm has been deprecated
in favor of sph_harm_y (with changed argument order).

Now sisl obeys the same order of arguments.
@codecov
Copy link

codecov bot commented Jan 15, 2026

Codecov Report

❌ Patch coverage is 68.75000% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.67%. Comparing base (a6777eb) to head (6510145).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/sisl/utils/mathematics.py 63.63% 4 Missing ⚠️
src/sisl/_core/orbital.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #969      +/-   ##
==========================================
- Coverage   86.68%   86.67%   -0.01%     
==========================================
  Files         412      412              
  Lines       54365    54373       +8     
==========================================
+ Hits        47124    47129       +5     
- Misses       7241     7244       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zerothi zerothi merged commit 1a5a6f8 into main Jan 15, 2026
11 of 13 checks passed
@zerothi zerothi deleted the scipy-1.17-deprecations branch January 15, 2026 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incompatibility issues with scipy=1.17.0

1 participant