-
Notifications
You must be signed in to change notification settings - Fork 149
Fixed withdraw gas table #487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughThe changes in this pull request involve an enhancement to the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant FeesComponent
participant ZetaChainClient
participant API
User->>FeesComponent: Request to view fees
FeesComponent->>ZetaChainClient: Fetch fees
ZetaChainClient->>API: Call new mainnet API endpoint
API-->>ZetaChainClient: Return fee data
ZetaChainClient-->>FeesComponent: Provide fetched fees
FeesComponent-->>User: Display fees
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
src/components/Docs/components/Fees.tsx (1)
47-50: Approve addition of new API endpoint with recommendations.The inclusion of the Cosmos HTTP endpoint for the mainnet configuration enhances the
ZetaChainClient's capabilities. However, consider the following recommendations:
- Implement robust error handling to manage potential failures specific to this new endpoint.
- Document the purpose and expected data format of this Cosmos HTTP endpoint to facilitate future maintenance.
- Ensure data consistency between the EVM and Cosmos endpoints, particularly in the
getFeesmethod of theZetaChainClient.To verify data consistency, consider implementing a comparison mechanism:
const evmData = await client.getFees(500000, 'evm'); const cosmosData = await client.getFees(500000, 'cosmos-http'); if (!isConsistent(evmData, cosmosData)) { console.warn('Inconsistency detected between EVM and Cosmos data'); // Handle inconsistency (e.g., use a preferred source or merge data) }
|
@zeta-chain/fullstack please, review. |
GMaiolo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The
getFeestoolkit function was using NodesHub API, which was down. Specified ATN endpoint, instead.We should refactor how RPC/API endpoints are stored and used.
Summary by CodeRabbit