Skip to content

Conversation

@fadeev
Copy link
Member

@fadeev fadeev commented Oct 9, 2024

The getFees toolkit function was using NodesHub API, which was down. Specified ATN endpoint, instead.

We should refactor how RPC/API endpoints are stored and used.

Summary by CodeRabbit

  • New Features
    • Enhanced the Fees component to support a new API endpoint for mainnet configuration, improving data retrieval for fees.
  • Bug Fixes
    • Maintained existing functionality for sorting and rendering fees without disruption.

@fadeev fadeev requested review from a team, bbbeeeee and brewmaster012 as code owners October 9, 2024 12:21
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 9, 2024

📝 Walkthrough

Walkthrough

The changes in this pull request involve an enhancement to the Fees component located in src/components/Docs/components/Fees.tsx. A new API endpoint for the mainnet configuration has been introduced, specifically adding a URL for a REST API to the ZetaChainClient instantiation. This modification allows the fetchFees function to utilize the updated client configuration, thereby expanding the data retrieval capabilities without altering the existing component structure or rendering logic.

Changes

File Path Change Summary
src/components/Docs/components/Fees.tsx Added a new API endpoint for mainnet configuration in ZetaChainClient, including a REST API URL. The fetchFees function now uses this updated configuration for data retrieval. Existing logic and rendering remain unchanged.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant FeesComponent
    participant ZetaChainClient
    participant API

    User->>FeesComponent: Request to view fees
    FeesComponent->>ZetaChainClient: Fetch fees
    ZetaChainClient->>API: Call new mainnet API endpoint
    API-->>ZetaChainClient: Return fee data
    ZetaChainClient-->>FeesComponent: Provide fetched fees
    FeesComponent-->>User: Display fees
Loading

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@vercel
Copy link

vercel bot commented Oct 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2024 0:35am

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
src/components/Docs/components/Fees.tsx (1)

47-50: Approve addition of new API endpoint with recommendations.

The inclusion of the Cosmos HTTP endpoint for the mainnet configuration enhances the ZetaChainClient's capabilities. However, consider the following recommendations:

  1. Implement robust error handling to manage potential failures specific to this new endpoint.
  2. Document the purpose and expected data format of this Cosmos HTTP endpoint to facilitate future maintenance.
  3. Ensure data consistency between the EVM and Cosmos endpoints, particularly in the getFees method of the ZetaChainClient.

To verify data consistency, consider implementing a comparison mechanism:

const evmData = await client.getFees(500000, 'evm');
const cosmosData = await client.getFees(500000, 'cosmos-http');

if (!isConsistent(evmData, cosmosData)) {
  console.warn('Inconsistency detected between EVM and Cosmos data');
  // Handle inconsistency (e.g., use a preferred source or merge data)
}
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 6c5b295 and 797b3b5.

📒 Files selected for processing (1)
  • src/components/Docs/components/Fees.tsx (1 hunks)
🧰 Additional context used

@fadeev
Copy link
Member Author

fadeev commented Oct 9, 2024

@zeta-chain/fullstack please, review.

Copy link
Contributor

@GMaiolo GMaiolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fadeev fadeev merged commit 3e01d68 into main Oct 9, 2024
5 checks passed
@fadeev fadeev deleted the quick-fix-withdraw-gas branch October 9, 2024 15:08
@coderabbitai coderabbitai bot mentioned this pull request Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants