-
Notifications
You must be signed in to change notification settings - Fork 61
feat: Redesign Hello frontend example #277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Redesign Hello frontend example #277
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment bugbot run to trigger another review on this PR
|
|
||
| await result.wait(); | ||
|
|
||
| setConnectedChainTxHash(result.hash); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Transaction Status Ignored, Causing Misleading Outcomes
The transaction receipt status is no longer captured or used after waiting for transaction completion. Previously, the receipt status was used to inform users of transaction success or failure. Now, only the transaction hash is stored, leading to transactions that fail without throwing an exception (e.g., status: 0) being incorrectly displayed as successful, misleading users about the actual outcome.
Locations (1)
2563e75
into
feat/add-hello-frontend-tutorial
Walkthrough
rec-hello-fe-tut.mp4
Screenshots
Desktop light
Desktop dark
Mobile light
Mobile dark