-
Notifications
You must be signed in to change notification settings - Fork 61
chore: update CLI to 7.0.0 #298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughRemoved side-effect ZetaChain task imports from multiple Hardhat configs and updated example dependencies to zetachain v7.0.0. Several example scripts were migrated to read addresses from ~/.zetachain/localnet/registry.json with updated jq filters targeting zrc20Tokens and contracts. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Script as localnet.sh
participant FS as ~/.zetachain/localnet/registry.json
participant JQ as jq
participant Shell as ShellEnv
Note over Script,FS: New registry-based lookup flow
Script->>FS: read registry.json
Script->>JQ: query .<chain>.zrc20Tokens[] / .<chain>.contracts[] with filters
JQ-->>Script: return address / contract object
Script->>Shell: export VAR=address
Script-->>Shell: echo VAR
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (13)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Broken, because |
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (5)
examples/call/yarn.lockis excluded by!**/yarn.lock,!**/*.lockexamples/hello/yarn.lockis excluded by!**/yarn.lock,!**/*.lockexamples/messaging/yarn.lockis excluded by!**/yarn.lock,!**/*.lockexamples/nft/yarn.lockis excluded by!**/yarn.lock,!**/*.lockexamples/token/yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (5)
examples/call/package.json(1 hunks)examples/hello/package.json(1 hunks)examples/messaging/package.json(1 hunks)examples/nft/package.json(1 hunks)examples/token/package.json(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- examples/call/package.json
🧰 Additional context used
🧠 Learnings (3)
📓 Common learnings
Learnt from: hernan-clich
PR: zeta-chain/example-contracts#280
File: examples/hello/frontend/src/utils/ethersHelpers.ts:1-6
Timestamp: 2025-09-18T17:59:04.889Z
Learning: Commit 1c6cffd3d29499bf0544987a9116c7c6571ff895 in zeta-chain/example-contracts resolves the noble/hashes esbuild build failure by adding resolutions for "noble/hashes": "1.8.0" and "noble/curves": "1.9.7" to examples/hello/frontend/package.json.
Learnt from: hernan-clich
PR: zeta-chain/example-contracts#280
File: examples/hello/frontend/src/ConnectedContent.tsx:3-10
Timestamp: 2025-09-18T18:00:10.177Z
Learning: Commit 1c6cffd3d29499bf0544987a9116c7c6571ff895 in zeta-chain/example-contracts#280 successfully resolved the noble/hashes "anumber" export error by adding resolutions in examples/hello/frontend/package.json to pin noble/hashes to 1.8.0 and noble/curves to 1.9.7, eliminating the version conflicts that were causing esbuild build failures.
Learnt from: hernan-clich
PR: zeta-chain/example-contracts#280
File: examples/hello/frontend/src/AppContent.tsx:6-6
Timestamp: 2025-09-17T21:47:04.873Z
Learning: The noble/hashes version conflict issue in zeta-chain/example-contracts should be resolved at the zetachain/wallet library level by adding resolutions to force compatible versions, protecting all consumers from this transitive dependency issue.
📚 Learning: 2025-09-18T17:59:04.889Z
Learnt from: hernan-clich
PR: zeta-chain/example-contracts#280
File: examples/hello/frontend/src/utils/ethersHelpers.ts:1-6
Timestamp: 2025-09-18T17:59:04.889Z
Learning: Commit 1c6cffd3d29499bf0544987a9116c7c6571ff895 in zeta-chain/example-contracts resolves the noble/hashes esbuild build failure by adding resolutions for "noble/hashes": "1.8.0" and "noble/curves": "1.9.7" to examples/hello/frontend/package.json.
Applied to files:
examples/nft/package.jsonexamples/hello/package.json
📚 Learning: 2025-09-18T18:00:10.177Z
Learnt from: hernan-clich
PR: zeta-chain/example-contracts#280
File: examples/hello/frontend/src/ConnectedContent.tsx:3-10
Timestamp: 2025-09-18T18:00:10.177Z
Learning: Commit 1c6cffd3d29499bf0544987a9116c7c6571ff895 in zeta-chain/example-contracts#280 successfully resolved the noble/hashes "anumber" export error by adding resolutions in examples/hello/frontend/package.json to pin noble/hashes to 1.8.0 and noble/curves to 1.9.7, eliminating the version conflicts that were causing esbuild build failures.
Applied to files:
examples/hello/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: slither (examples/call, call.sarif)
- GitHub Check: slither (examples/hello, hello.sarif)
🔇 Additional comments (3)
examples/token/package.json (1)
64-64: Clarify use of RC version for@zetachain/standard-contractsand version consistency.Line 61 pins
@zetachain/standard-contractsto4.0.0-rc9, a release candidate, whileexamples/messaging/package.jsonuses the stable3.0.0. Confirm this inconsistency is intentional. If standardization is desired, align this across all examples or document why version divergence is needed.examples/hello/package.json (1)
60-60: LGTM.The zetachain 7.0.0 update is consistent with the PR objectives and maintains exact version pinning for stability. The absence of
@zetachain/standard-contractsin this example appears intentional based on its simpler scope compared to other examples.examples/nft/package.json (1)
64-64: LGTM on the zetachain 7.0.0 bump.The version update is consistent with the PR objectives. Note that this example (like
examples/token/package.json) uses@zetachain/standard-contracts@4.0.0-rc9(RC), whereasexamples/messaging/package.jsonpins the stable3.0.0. Verify this split is intentional across the examples.
Summary by CodeRabbit