refactor: standardize zetaclient logging #4144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 📝 WalkthroughWalkthroughRefactors logging across zetaclient to structured style, replacing formatted Msgf logs with fielded logs and per-method loggers. Removes the logger parameter from base Observer.LoadLastBlockScanned and updates callers/tests. Reorders parameters for tss.ParsePubKeysFromPath. Deletes types/dynamic_ticker.go. Adds minor doc and comment updates. Changes
Sequence Diagram(s)Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Assessment against linked issues
Assessment against linked issues: Out-of-scope changes
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
renan061
force-pushed
the
feature/standardize-logging
branch
from
091a8e5 to
ff4e7a6
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #4144 +/- ##
===========================================
+ Coverage 66.03% 66.06% +0.02%
===========================================
Files 457 456 -1
Lines 33751 33957 +206
===========================================
+ Hits 22287 22433 +146
- Misses 10490 10549 +59
- Partials 974 975 +1
🚀 New features to boost your workflow:
|
renan061
force-pushed
the
feature/standardize-logging
branch
from
ff4e7a6 to
dbff1e5
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, please have a team admin upgrade your team to Bugbot Pro by visiting the Cursor dashboard. Your first 14 days will be free!
Comment @cursor review or bugbot run to trigger another review on this PR
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 9
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (4)
zetaclient/maintenance/tss_listener.go (1)
136-136: Misleading error text (KeyGen vs TSS history)Message should reflect GetKeyGen failure.
- return errors.Wrap(err, "failed to get initial tss history") + return errors.Wrap(err, "failed to get initial keygen")zetaclient/chains/evm/signer/outbound_data.go (1)
182-184: Length-mismatch can return a nil error due to Wrapf(nil,...); split the checks.When err == nil but len(cctxIndexSlice) != 32, Wrapf(nil, ...) yields nil. This drops the error.
Apply this diff:
- cctxIndexSlice, err := hex.DecodeString(cctx.Index[2:]) - if err != nil || len(cctxIndexSlice) != 32 { - return [32]byte{}, errors.Wrapf(err, "unable to decode cctx index %s", cctx.Index) - } + cctxIndexSlice, err := hex.DecodeString(cctx.Index[2:]) + if err != nil { + return [32]byte{}, errors.Wrapf(err, "unable to decode cctx index %s", cctx.Index) + } + if len(cctxIndexSlice) != 32 { + return [32]byte{}, fmt.Errorf("decoded cctx index has length %d, want 32: %s", len(cctxIndexSlice), cctx.Index) + }zetaclient/chains/bitcoin/observer/outbound.go (1)
201-214: Avoid map-based Fields; attach structured fields directlyThis aligns with the PR objective and improves type-safety and consistency.
- logFields := map[string]any{ - logs.FieldTx: res.TxID, - logs.FieldZetaTx: zetaHash, - logs.FieldBallot: ballot, - } - if err != nil { - logger.Error(). - Err(err). - Fields(logFields). - Msg("Error confirming outbound") + logger.Error(). + Err(err). + Str(logs.FieldTx, res.TxID). + Str(logs.FieldZetaTx, zetaHash). + Str(logs.FieldBallot, ballot). + Msg("Error confirming outbound") } else if zetaHash != "" { - logger.Info().Fields(logFields).Msg("Outbound confirmed") + logger.Info(). + Str(logs.FieldTx, res.TxID). + Str(logs.FieldZetaTx, zetaHash). + Str(logs.FieldBallot, ballot). + Msg("Outbound confirmed") }zetaclient/chains/base/observer.go (1)
410-456: Replace ad-hoc field map with a function-scoped structured loggerThis file still uses Fields(lf); migrate to chained fields to complete the standardization.
- // prepare logger fields - lf := map[string]any{ - logs.FieldMethod: "PostVoteInbound", - logs.FieldTx: txHash, - logs.FieldCoinType: coinType.String(), - logs.FieldConfirmationMode: msg.ConfirmationMode.String(), - } + // scoped logger with static fields + logger := ob.logger.Inbound.With(). + Str(logs.FieldMethod, "PostVoteInbound"). + Str(logs.FieldTx, txHash). + Str(logs.FieldCoinType, coinType.String()). + Str(logs.FieldConfirmationMode, msg.ConfirmationMode.String()). + Logger() @@ - ob.logger.Inbound.Info().Fields(lf).Msg("inbound detected: cctx exists but the ballot does not") + logger.Info().Msg("inbound detected: cctx exists but the ballot does not") @@ - if err := msg.ValidateBasic(); err != nil { - ob.logger.Inbound.Warn().Err(err).Fields(lf).Msg("invalid inbound vote message") + if err := msg.ValidateBasic(); err != nil { + logger.Warn().Err(err).Msg("invalid inbound vote message") return "", nil } @@ - lf[logs.FieldZetaTx] = zetaHash - lf[logs.FieldBallot] = ballot - switch { case err != nil: - ob.logger.Inbound.Error().Err(err).Fields(lf).Msg("inbound detected: error posting vote") + logger.Error().Err(err). + Str(logs.FieldZetaTx, zetaHash). + Str(logs.FieldBallot, ballot). + Msg("inbound detected: error posting vote") return "", err case zetaHash == "": - ob.logger.Inbound.Info().Fields(lf).Msg("inbound detected: already voted on ballot") + logger.Info(). + Str(logs.FieldZetaTx, zetaHash). + Str(logs.FieldBallot, ballot). + Msg("inbound detected: already voted on ballot") default: - ob.logger.Inbound.Info().Fields(lf).Msg("inbound detected: vote posted") + logger.Info(). + Str(logs.FieldZetaTx, zetaHash). + Str(logs.FieldBallot, ballot). + Msg("inbound detected: vote posted") }
🧹 Nitpick comments (73)
zetaclient/chains/evm/signer/gas.go (1)
109-111: Inconsistent log key style (dots vs underscores).Elsewhere you switched to underscores (e.g., cctx_initial_gas_limit). Align these keys for consistency and easier querying.
- .Str("cctx.initial_priority_fee", priorityFee.String()). - .Str("cctx.forced_priority_fee", gasPrice.String()). + .Str("cctx_initial_priority_fee", priorityFee.String()). + .Str("cctx_forced_priority_fee", gasPrice.String()).zetaclient/chains/bitcoin/signer/sign.go (1)
184-186: Standardize field naming and add explicit adjustment metadata in structured logUse the tx.* key prefix consistently and capture why/how the value is adjusted for easier filtering. Consider downgrading to Debug if this path is common to avoid log noise.
- signer.Logger().Std.Info(). - Int64("remaining_sats", remainingSats). - Msg("adjust remainder value to avoid duplicate nonce-mark") + signer.Logger().Std.Info(). + Str("tx.output", "change"). + Int64("tx.change_sats", remainingSats). + Int64("tx.nonce_mark_sats", nonceMark). + Int64("tx.change_adjustment_sats", -1). + Bool("tx.dup_nonce_mark", true). + Msg("adjust change to avoid duplicate nonce-mark")zetaclient/zetacore/client_subscriptions.go (3)
78-80: Use Warn and add explicit expected vs. got fields for parse-friendly logsLower severity to avoid noisy error logs on benign mismatches and add stable fields to aid filtering.
- c.logger.Error().Type("event_type", event.Data).Msg("expecting new block event") + c.logger.Warn(). + Str("expected_event", "EventDataNewBlock"). + Type("got_type", event.Data). + Str("query", ctypes.EventQueryNewBlock.String()). + Msg("unexpected event type; skipping")
82-84: Enrich the new-block debug log with stable fieldsAdd query and tighten the message to a canonical phrase; keeps it structured and easier to grep/aggregate. Consider adding chain_id, block_time, and num_txs if readily available in this scope.
- c.logger.Debug(). - Int64("height", newBlockEvent.Block.Height). - Msg("Received new block event") + c.logger.Debug(). + Int64("height", newBlockEvent.Block.Height). + Str("query", ctypes.EventQueryNewBlock.String()). + Msg("new block")
29-41: Avoid allocating a new timer on every select iterationReplace time.After with a ticker to prevent per-iteration allocations and reduce GC pressure in long-lived goroutines.
- for { - select { + ticker := time.NewTicker(10 * time.Second) + defer ticker.Stop() + for { + select { case block := <-consumer: blocksChan <- block - case <-time.After(time.Second * 10): + case <-ticker.C: // the subscription should automatically reconnect after zetacore // restart, but we should log this just in case that logic is not // working c.logger.Warn().Msg("Block subscriber: no blocks after 10 seconds") case <-ctx.Done(): closeConsumer() return } }zetaclient/maintenance/tss_listener.go (2)
109-111: Surface transient errors when fetching TSS historyErrors are currently swallowed; emit a warn to aid observability and incident triage.
- if err != nil { - continue - } + if err != nil { + tl.logger.Warn().Err(err).Msg("unable to get TSS history") + continue + }
166-169: Normalize field name to snake_case for consistencyPrefer block_number over blockNumber to match other keys (tss_old, from_length, etc.). Check log consumers for key changes.
- tl.logger.Info(). - Int64("blockNumber", keygenUpdated.BlockNumber). - Msg("got new keygen") + tl.logger.Info(). + Int64("block_number", keygenUpdated.BlockNumber). + Msg("got new keygen")zetaclient/chains/bitcoin/observer/witness.go (14)
60-64: Field name does not match value (script hex vs recipient address).Key "recipient" holds a script hex, not an address. Use a precise key to avoid downstream parsing errors.
- Str("recipient", tx.Vout[0].ScriptPubKey.Hex). + Str("script_hex", tx.Vout[0].ScriptPubKey.Hex).
78-81: Add a reason field and reduce log level to debug to avoid noise.This path will be common; include a structured reason and log at debug.
- logger.Info(). + logger.Debug(). Fields(lf). - Str("sender", fromAddress). - Msg("skipping transaction") + Str("sender", fromAddress). + Str("reason", reason). + Msg("skipping transaction")Outside the range, compute the reason immediately before the if:
reason := "empty_sender" if fromAddress != "" { reason = "outbound_tx" }
99-99: Include deposited/fee/status context in error log.Enriching this log makes failed-fee triage straightforward.
- logger.Error().Err(err).Fields(lf).Msg("unable to deduct depositor fee") + logger.Error(). + Err(err). + Fields(lf). + Float64("deposited", tx.Vout[0].Value). + Float64("depositor_fee", depositorFee). + Str("status", status.String()). + Msg("unable to deduct depositor fee")
111-111: Avoid logging full inscription memo; add length and a short preview.Inscription payloads can be large. Emit length + preview to keep logs compact.
- logger.Debug().Fields(lf).Str("memo", hex.EncodeToString(memo)).Msg("found inscription memo") + logger.Debug().Fields(lf).Int("memo_len", len(memo)).Str("memo_preview", memoPreview).Msg("found inscription memo")Outside the range, compute the preview just above the log:
memoHex := hex.EncodeToString(memo) memoPreview := memoHex if len(memoHex) > 128 { memoPreview = memoHex[:128] }
145-145: Add minimal context to invalid witness element.Length of the hex string helps debugging malformed inputs.
- logger.Debug().Msg("invalid witness element") + logger.Debug().Int("witness_hex_len", len(witness[length-1])).Msg("invalid witness element")
159-159: Message grammar nit.Improve clarity.
- logger.Debug().Msg("not script path spending detected, ignore") + logger.Debug().Msg("not script-path spend; ignoring")
166-166: Consistent phrasing.Align with prior message.
- logger.Debug().Msg("witness script cannot be decoded from hex, ignore") + logger.Debug().Msg("witness script cannot be decoded from hex; ignoring")
174-174: Attach tx id to per-method logger via standard field key.This removes repeated tx fields below and standardizes on logs.FieldTx.
- logger = logger.With().Str(logs.FieldMethod, "tryExtractOpRet").Logger() + logger = logger.With().Str(logs.FieldMethod, "tryExtractOpRet").Str(logs.FieldTx, tx.Txid).Logger()
177-179: Use the per-method logger; avoid ad-hoc key "tx_id".Standardize and simplify.
- logger.Debug(). - Str("tx_id", tx.Txid). - Msg("txn has fewer than 2 outputs, not target OP_RETURN txn") + logger.Debug().Msg("txn has fewer than 2 outputs; no OP_RETURN candidate")
185-188: Wrong field name ("memo") – this is the OP_RETURN script hex.Rename to avoid confusion with decoded memo bytes.
- logger.Error(). - Err(err). - Str("memo", tx.Vout[1].ScriptPubKey.Hex). - Msg("error decoding OP_RETURN memo") + logger.Error(). + Err(err). + Str("script_hex", tx.Vout[1].ScriptPubKey.Hex). + Msg("error decoding OP_RETURN memo")
206-206: Standardize tx field key.Prefer logs.FieldTx everywhere.
- logger.Debug().Str("tx", tx.Txid).Int("input_index", i).Msg("potential witness script") + logger.Debug().Str(logs.FieldTx, tx.Txid).Int("input_index", i).Msg("potential witness script")
210-210: Include error context when available and standardize tx field key.This aids triage without inflating log volume.
- logger.Debug().Str("tx", tx.Txid).Int("input_index", i).Msg("invalid witness script") + logger.Debug().Err(err).Str(logs.FieldTx, tx.Txid).Int("input_index", i).Msg("invalid witness script")
214-214: Add memo length and standardize tx field key.Consistent, compact signal for downstream consumers.
- logger.Debug().Str("tx", tx.Txid).Int("input_index", i).Msg("found memo in inscription") + logger.Debug().Str(logs.FieldTx, tx.Txid).Int("input_index", i).Int("memo_len", len(memo)).Msg("found memo in inscription")
174-179: Unify transaction log field keys
- In zetaclient/chains/bitcoin/observer/witness.go (lines 174–179, 206–214), replace all Str("tx_id", …) and Str("tx", …) calls with Str(logs.FieldTx, tx.Txid)
- In logs/fields.go, add centralized constants for common keys (e.g. FieldInputIndex, FieldMemoLen, FieldMemoPreview, FieldScriptHex, FieldSender, FieldRecipient) to enforce uniform naming across the repo
zetaclient/chains/sui/signer/signer.go (1)
99-103: Promote field keys to shared constants and add a reason field for consistency.Use canonical keys across the codebase and make the message declarative for easier parsing.
Apply:
- logger.Info(). - Uint64("gateway_nonce", gatewayNonce). - Uint64("cctx_nonce", nonce). - Msg("gateway nonce does not match CCTX nonce; skip broadcast") + logger.Info(). + Uint64(logs.FieldGatewayNonce, gatewayNonce). + Uint64(logs.FieldCCTXNonce, nonce). + Str(logs.FieldReason, "nonce_mismatch"). + Msg("skipping broadcast due to gateway/CCTX nonce mismatch")Add in logs/fields.go:
const ( FieldGatewayNonce = "gateway_nonce" FieldCCTXNonce = "cctx_nonce" FieldReason = "reason" )zetaclient/tss/keygen.go (1)
125-129: Normalize field naming style in structured logs.Avoid mixing dotted and underscored keys in the same event. Prefer one convention repo-wide.
Apply:
- k.logger.Info(). - Int64("keygen.height", keygenHeight). - Int64("zeta_height", zetaHeight). + k.logger.Info(). + Int64("keygen_height", keygenHeight). + Int64("zeta_height", zetaHeight). Msg("Waiting for keygen block to arrive or new keygen block to be set") - k.logger.Info(). - Int64("keygen.height", keygenHeight). - Int64("zeta_height", zetaHeight). + k.logger.Info(). + Int64("keygen_height", keygenHeight). + Int64("zeta_height", zetaHeight). Msg("Waiting for keygen finalization")Also applies to: 131-135
zetaclient/zetacore/client_start.go (2)
86-86: Include readiness latency in the success log.Adds immediate observability for startup time.
Apply:
- zc.logger.Info().Int64("block_height", blockHeight).Msg("Zetacore is ready") + zc.logger.Info(). + Int64("block_height", blockHeight). + Dur("elapsed", time.Since(start)). + Msg("Zetacore is ready")
96-99: Unify numeric field types in retry logs.Use the same type for both fields to keep schemas stable.
Apply:
- zc.logger.Info(). - Int("current_attempt", retryCount). - Uint("max_attempts", attempts). + zc.logger.Info(). + Int("current_attempt", retryCount). + Int("max_attempts", attempts). Msg("Failed to get block number")zetaclient/chains/bitcoin/observer/mempool.go (2)
57-64: Add correlation fields and keep keys canonical.Consider including chain_id and observer instance identifiers (if available) and stick to shared keys (e.g., logs.FieldTx) everywhere.
Apply:
- logger.Info(). - Uint64(logs.FieldNonce, lastNonce). - Str(logs.FieldTx, lastTxHash). - Msg("Checking last TSS outbound") + logger.Info(). + Uint64(logs.FieldNonce, lastNonce). + Str(logs.FieldTx, lastTxHash). + Int64("chain_id", ob.Chain().ChainId). + Msg("checking last TSS outbound")
89-95: Emit a final status log after updating the stuck outbound state.This helps operators see the outcome of each check.
Apply:
ob.setLastStuckOutbound(stuckOutbound) + logger.Info(). + Bool("stuck", stuck). + Dur("stuck_for", stuckFor). + Msg("updated last stuck outbound status")zetaclient/keys/keys.go (2)
92-96: Structured debug log: align field keys for consistencyUse explicit, self-describing keys to ease filtering across services.
-logger.Debug(). - Str("hotkey", granteeName). - Str("folder", chainHomeFolder). - Str("backend", kb.Backend()). - Msg("Checking for hotkey") +logger.Debug(). + Str("hotkey", granteeName). + Str("zeta_core_home", chainHomeFolder). + Str("keyring_backend", kb.Backend()). + Msg("Checking for hotkey")Additionally (outside this hunk), prefer the shared field name for module:
// add import import "github.com/zeta-chain/node/zetaclient/logs" // line 67 logger := log.Logger.With().Str(logs.FieldModule, "keys.GetKeyringKeybase").Logger()
99-100: Minor: error text grammarOptional tweak for clarity; verify no tests depend on exact string.
- format := "key not in backend %s present with name (%s): %w" + format := "key not present in backend %s with name (%s): %w"zetaclient/keys/relayer_key.go (1)
51-57: Optional: lower severity and use clearer field name for optional fileAbsent relayer key is expected; Info (or Debug) reduces noise. Prefer “file_path”.
- if !zetaos.FileExists(fileName) { - log.Logger.Warn(). - Str("file_name", fileName). - Msg("Relayer-key file not found") + if !zetaos.FileExists(fileName) { + log.Logger.Info(). + Str("file_path", fileName). + Msg("Relayer-key file not found (optional)") return nil, nil }Additionally (outside this hunk), short-circuit when no path is provided to differentiate “not provided” vs “invalid”:
func LoadRelayerKey(relayerKeyPath string, network chains.Network, password string) (*RelayerKey, error) { if relayerKeyPath == "" { log.Logger.Debug().Msg("Relayer-key path not provided; skipping") return nil, nil } // ... existing logic }zetaclient/chains/bitcoin/signer/signer.go (1)
196-199: Nit: comment typo“broacasting” → “broadcasting”.
- // try broacasting tx with backoff in case of RPC error + // try broadcasting tx with backoff in case of RPC errorzetaclient/zetacore/broadcast.go (1)
142-147: Make sequence-mismatch log fields self-describing“from/to” are ambiguous. Use explicit names to aid operators.
- c.logger.Warn(). - Uint64("from", gotSeq). - Uint64("to", expectedSeq). - Msg("Resetting seq number (from err msg)") + c.logger.Warn(). + Uint64("got_seq", gotSeq). + Uint64("expected_seq", expectedSeq). + Msg("Resetting account sequence from error message")zetaclient/tss/service.go (3)
175-177: Field name should convey meaning without the messageUse a descriptive field key instead of “to”.
- logger.Info(). - Uint64("to", cfg.maxPendingSignatures). - Msg("Setting max pending signatures") + logger.Info(). + Uint64("max_pending_signatures", cfg.maxPendingSignatures). + Msg("Setting max pending signatures")
234-238: Reduce log verbosity for cache hitsCache hits are high-frequency; use Debug to avoid log noise.
- s.logger.Info(). + s.logger.Debug(). Fields(keysignLogFields(req, nonce, chainID)). Msg("Signature cache hit")
333-336: Unify key naming: prefer dotted tss. keys*Other TSS logs use dotted keys (tss.chain_id, tss.block_height). Align blame fields for consistency.
- Any("tss_fail_blame", res.Blame). + Any("tss.blame", res.Blame).- Str("tss_blame_tx_hash", zetaHash). + Str("tss.blame_tx_hash", zetaHash).Also applies to: 368-371
zetaclient/chains/ton/observer/inbound.go (2)
48-50: Structured pagination logs look good; consider binding a scoped logger with method/chain.Use a per-function logger via With() to avoid repeating method names in messages and to align with the PR’s standardized pattern (see EVM/Solana/Bitcoin files).
Example (outside this hunk):
logger := ob.Logger().Inbound.With(). Str(logs.FieldMethod, "ObserveInbound"). Int64(logs.FieldChain, ob.Chain().ChainId). Logger() // then replace ob.Logger().Inbound.* with logger.*Also applies to: 53-55
371-371: Message content: prefer action-oriented, method-free text.Keep method names in fields, not in Msg(). Suggest simplifying the message.
- .Msg("setLastScannedTX: unable to WriteLastTxScannedToDB") + .Msg("unable to persist last scanned tx to DB")zetaclient/chains/evm/signer/signer.go (3)
293-297: Use a constant for destination chain field to keep names consistent.You’re using "to_chain_id" here (and in BroadcastOutbound). Consider adding logs.FieldToChain (or similar) to logs/fields.go and using it everywhere for destination chain IDs.
Also applies to: 300-303
306-306: Avoid potential uint64 truncation for gas price; log as string in wei.big.Int may exceed uint64. Emit as decimal string to preserve precision.
- logger = logger.With().Uint64("gas_price", txData.gas.Price.Uint64()).Logger() + logger = logger.With().Str("gas_price_wei", txData.gas.Price.String()).Logger()
421-424: Field naming and consistency in BroadcastOutbound.
- Keep "to_chain_id" consistent via a logs constant (see prior comment).
- Prefer logs.FieldCctx over a one-off "cctx_index".
- logger.Warn().Str("cctx_index", cctx.Index).Msg("BroadcastOutbound: no tx to broadcast") + logger.Warn().Str(logs.FieldCctx, cctx.Index).Msg("BroadcastOutbound: no tx to broadcast")Also applies to: 429-431, 433-433
zetaclient/chains/bitcoin/observer/observer.go (1)
253-266: Minor: method field should match the function name casing.Function is setLastStuckOutbound; use the same in logs for greppability and consistency with other unexported methods.
- logger := ob.logger.Outbound.With().Str(logs.FieldMethod, "SetLastStuckOutbound").Logger() + logger := ob.logger.Outbound.With().Str(logs.FieldMethod, "setLastStuckOutbound").Logger()The rest of the structured log fields look good.
zetaclient/chains/bitcoin/observer/utxos.go (2)
199-201: Use a standard tx field key.Prefer logs.FieldTx for the transaction/UTXO tx id to keep keys uniform across modules.
- Str("utxo_tx_id", utxo.TxID). + Str(logs.FieldTx, utxo.TxID).
206-206: Consistent function name in error text.Match the actual function name/case.
- return -1, fmt.Errorf("FindNonceMarkUTXO: cannot find nonce-mark utxo with nonce %d", nonce) + return -1, fmt.Errorf("findNonceMarkUTXO: cannot find nonce-mark utxo with nonce %d", nonce)zetaclient/chains/solana/signer/signer.go (4)
165-166: Error messages updated correctly; consider adding structured context consistently.Where helpful, attach specific context fields (e.g., coin type) to reduce string parsing.
For the default branch:
- logger.Error(). - Msg("TryProcessOutbound: can only send SOL to the Solana network") + logger.Error(). + Str("coin_type", coinType.String()). + Msg("TryProcessOutbound: unsupported coin type for Solana network")Also consider replacing ad-hoc "method"/"chain"/"nonce"/"cctx" literals with logs.Field* constants for uniformity (as used in EVM/Bitcoin).
Also applies to: 176-177, 184-185, 195-196, 203-204, 212-213
407-411: Good shift to structured error; add method binding for consistency.Add a With().Str(logs.FieldMethod, "SetGatewayAddress") on the logger to align with the rest of the PR.
218-220: Optional: enrich default-case error with coin type.Adds filterable context, avoids string parsing.
- logger.Error(). - Msg("TryProcessOutbound: can only send SOL to the Solana network") + logger.Error(). + Str("coin_type", coinType.String()). + Msg("TryProcessOutbound: unsupported coin type for Solana network")
319-373: Replace map-based Fields with With()-chained context in broadcastOutbound.Using With() keeps types explicit and aligns with the PR objective to standardize logging style.
Outside this hunk, suggested refactor:
logger := logger.With(). Str(logs.FieldMethod, "broadcastOutbound"). Uint64(logs.FieldNonce, nonce). Stringer(logs.FieldTx, tx.Signatures[0]). Logger() // later when pdaNonce is known: logger = logger.With().Uint64("pda_nonce", pdaNonce).Logger()zetaclient/chains/bitcoin/observer/outbound.go (4)
288-291: Fix log message to match the called methodThe RPC call is GetTransactionByStr; reflect that in the message.
- logger.Warn().Err(err).Msg("GetTxResultByHash failed") + logger.Warn().Err(err).Msg("GetTransactionByStr failed")
295-297: Rename field and add minimum for clarity“count” is ambiguous; use explicit confirmation fields.
- logger.Warn().Int64("count", txResult.Confirmations).Msg("invalid confirmations") + logger.Warn(). + Int64("confirmations", txResult.Confirmations). + Int("min_confirmations", minTxConfirmations). + Msg("below_min_confirmations")
151-156: Prefer snake_case keys; avoid dots in field namesDots can be interpreted as nesting by log processors.
- logger.Debug(). - Int64("confirmations.current", res.Confirmations). - Uint64("confirmations.required", ob.ChainParams().OutboundConfirmationSafe()). - Msg("Outbound not confirmed yet") + logger.Debug(). + Int64("confirmations_current", res.Confirmations). + Uint64("confirmations_required", ob.ChainParams().OutboundConfirmationSafe()). + Msg("Outbound not confirmed yet")
224-225: Normalize method tag casingUse a consistent style with other methods (e.g., “ProcessOutboundTrackers”, “VoteOutboundIfConfirmed”).
- logger := ob.logger.Outbound.With().Str(logs.FieldMethod, "refresh_pending_nonce").Logger() + logger := ob.logger.Outbound.With().Str(logs.FieldMethod, "RefreshPendingNonce").Logger()zetaclient/chains/base/observer.go (1)
149-150: Consistent capitalization in log messagesAlign with other Info messages.
- ob.Logger().Chain.Info().Msg("observer stopped") + ob.Logger().Chain.Info().Msg("Observer stopped")zetaclient/chains/base/observer_test.go (1)
345-347: Use t.Setenv to avoid environment leakage across testst.Setenv automatically restores prior state and keeps tests isolated.
- os.Setenv(envvar, "101") + t.Setenv(envvar, "101")- os.Setenv(envvar, base.EnvVarLatestBlock) + t.Setenv(envvar, base.EnvVarLatestBlock)- os.Setenv(envvar, "invalid") + t.Setenv(envvar, "invalid")Also applies to: 362-363, 375-376
zetaclient/chains/solana/observer/observer.go (1)
60-63: Include method field via a scoped logger for consistencyMatch the standardized pattern used elsewhere.
- ob.Logger().Chain.Info(). - Int64("chain", ob.Chain().ChainId). - Str("tx", ob.LastTxScanned()). - Msg("chain starts scanning from tx") + logger := ob.Logger().Chain.With(). + Str(logs.FieldMethod, "LoadLastTxScanned"). + Int64("chain", ob.Chain().ChainId). + Str("tx", ob.LastTxScanned()). + Logger() + logger.Info().Msg("chain starts scanning from tx")Add import:
// at top of file import ( // ... "github.com/zeta-chain/node/zetaclient/logs" )zetaclient/tss/config_test.go (1)
96-99: Avoid changing process working directory in testsos.Chdir in tests can cause cross-test interference and flakiness. Write files via filepath.Join instead.
func generateKeyShareFiles(t *testing.T, n int, dir string) { - err := os.Chdir(dir) - require.NoError(t, err) for i := 0; i < n; i++ { _, pubKey, _ := testdata.KeyTestPubAddr() @@ - filename := fmt.Sprintf("localstate-%s.json", pk.String()) - - err = os.WriteFile(filename, b, 0644) + filename := filepath.Join(dir, fmt.Sprintf("localstate-%s.json", pk.String())) + err := os.WriteFile(filename, b, 0o644) require.NoError(t, err) } }Also applies to: 111-114
zetaclient/chains/evm/observer/observer.go (1)
234-234: Nit: fix log message grammarPrefer “succeeded”.
- ob.Logger().Chain.Info().Uint64("last_block_scanned", ob.LastBlockScanned()).Msg("LoadLastBlockScanned succeed") + ob.Logger().Chain.Info().Uint64("last_block_scanned", ob.LastBlockScanned()).Msg("LoadLastBlockScanned succeeded")zetaclient/chains/solana/observer/outbound.go (1)
299-302: Emit signer and expected address as canonical hex stringsUsing Any on address-like types can produce verbose or pointer-y outputs. Log stable hex strings with clear field names.
- logger.Error(). - Any("signer", signerECDSA). - Any("address", ob.TSS().PubKey().AddressEVM()). - Msg("tx signer is not matching current TSS address") + logger.Error(). + Str("signer", signerECDSA.Hex()). + Str("expected_address", ob.TSS().PubKey().AddressEVM().Hex()). + Msg("tx signer is not matching current TSS address")zetaclient/chains/bitcoin/observer/db.go (1)
56-56: Nit: fix log message grammarUse “succeeded”.
- ob.Logger().Chain.Info().Uint64("last_block_scanned", ob.LastBlockScanned()).Msg("LoadLastBlockScanned succeed") + ob.Logger().Chain.Info().Uint64("last_block_scanned", ob.LastBlockScanned()).Msg("LoadLastBlockScanned succeeded")zetaclient/chains/bitcoin/observer/event.go (1)
168-168: Adopt neutral, action-oriented log messageProduction logs should be neutral and searchable.
- logger.Info().Msg("thank you rich folk for your donation!") + logger.Info().Msg("Donation transaction detected; skipping processing")zetaclient/chains/evm/observer/outbound.go (3)
79-82: Standardize field keys and include chain_id for contextUse a canonical field for counts and add chain_id to aid correlation.
- logger.Error(). - Uint64(logs.FieldNonce, nonce). - Int("count", txCount). - Msg("Confirmed multiple outbound") + logger.Error(). + Int64(logs.FieldChain, ob.Chain().ChainId). + Uint64(logs.FieldNonce, nonce). + Int(logs.FieldCount, txCount). + Msg("Confirmed multiple outbound")Add this field key once to centralize naming (in zetaclient/logs/fields.go):
// fields.go const ( // ... FieldCount = "count" )
228-231: Use canonical field names: FieldChain and FieldTx (avoid ad-hoc keys)Align with the rest of the file to keep logs queryable and consistent.
- Str(logs.FieldMethod, "VoteOutboundIfConfirmed"). - Int64("chain", ob.Chain().ChainId). - Any("tx_hash", receipt.TxHash). + Str(logs.FieldMethod, "VoteOutboundIfConfirmed"). + Int64(logs.FieldChain, ob.Chain().ChainId). + Str(logs.FieldTx, receipt.TxHash.Hex()).
500-500: Warn instead of Error for expected transient, fix grammar in messageDuring TSS upgrades this branch can be a false positive; WARN reduces noise. Also fix pluralization.
- logger.Error().Str("tx_sender", from.String()).Msg("tx sender is not TSS addresses") + logger.Warn().Str("tx_sender", from.String()).Msg("tx sender is not TSS address")Optionally introduce a canonical key:
// fields.go const FieldTxSender = "tx_sender"and then:
- logger.Warn().Str("tx_sender", from.String()).Msg("tx sender is not TSS address") + logger.Warn().Str(logs.FieldTxSender, from.String()).Msg("tx sender is not TSS address")zetaclient/chains/bitcoin/observer/inbound.go (2)
190-194: Use Observer accessor for loggers and normalize method tag casingPrefer ob.Logger() for encapsulation. Consider snake_case to match observe_inbound.
- logger := ob.logger.Inbound.With(). - Str(logs.FieldMethod, "GetInboundVoteFromBtcEvent"). + logger := ob.Logger().Inbound.With(). + Str(logs.FieldMethod, "get_inbound_vote_from_btc_event"). Str(logs.FieldTx, event.TxHash). Logger()
200-204: Clarify field name: memo_hex (content is hex-encoded)Improves discoverability in log queries.
- logger.Info(). - Err(err). - Str("memo", hex.EncodeToString(event.MemoBytes)). - Msg("invalid memo") + logger.Info(). + Err(err). + Str("memo_hex", hex.EncodeToString(event.MemoBytes)). + Msg("invalid memo")zetaclient/tss/setup.go (2)
70-70: Log multiaddrs as strings for readabilityMarshalling multiaddr as Interface can be verbose. Prefer Strs with stringified addrs.
- setupLogger.Info().Interface("bootstrap_peers", bootstrapPeers).Msg("Bootstrap peers") + setupLogger.Info().Strs("bootstrap_peers", multiaddrsToStrings(bootstrapPeers)).Msg("Bootstrap peers")Add helper (place anywhere in this file):
func multiaddrsToStrings(addrs []multiaddr.Multiaddr) []string { out := make([]string, 0, len(addrs)) for _, a := range addrs { out = append(out, a.String()) } return out }
269-271: Downgrade to Info: fallback path is expectedFalling back to default TSS path is a normal condition; WARN can be noisy in ops.
- logger.Warn(). + logger.Info(). Str("to", tssPath). Msg("TSS path is empty, falling back")zetaclient/tss/config.go (7)
81-81: Include directory context in the warning.Add the directory for easier triage in aggregated logs.
-logger.Warn().Msg("Found no TSS key share files") +logger.Warn().Str("dir", tssPath).Msg("Found no TSS key share files")
85-87: Enrich summary log with directory context.Improves traceability across nodes/paths.
logger.Info(). + Str("dir", tssPath). Int("count", len(shareFiles)). Msg("Found TSS key share files")
94-97: Remove redundant prefix check or the earlier filter; pick one source of truth.You already filtered by prefix when building
shareFiles, so this branch is unreachable. Prefer removing this block to reduce noise, or stop filtering early and rely on explicit "Skipping" logs.- if !strings.HasPrefix(filename, prefix) { - logger.Warn(). - Str("file", filename). - Str("expected_prefix", prefix). - Msg("Skipping file: does not have the expected prefix") - continue - }
102-104: Add expected suffix field for symmetry and easier filtering.-logger.Warn(). - Str("file", filename). - Msg("Skipping file: not a JSON file") +logger.Warn(). + Str("file", filename). + Str("expected_suffix", ".json"). + Msg("Skipping file: not a JSON file")
112-116: Demote to warn to avoid error-noise for a single bad file.The system recovers by skipping; warn is sufficient.
-logger.Error(). +logger.Warn(). Err(err). Str("file", filename). Str("bech32", bech32). Msg("Skipping file: unable to create PubKey")
124-124: Enrich final warning; consider returning an empty slice instead of nil.
- Add
dirandscannedto aid debugging.- Optional: return
[]PubKey{}to avoid nil-vs-empty ambiguity for callers.-logger.Warn().Msg("Found no valid TSS pub keys") +logger.Warn(). + Str("dir", tssPath). + Int("scanned", len(shareFiles)). + Msg("Found no valid TSS pub keys")Outside this range, consider:
// at early return (no share files) and here: return []PubKey{}, nil
65-65: All callers updated; implement optional child logger reuse and tssPath normalization
- Verified that setup.go (line 290) and config_test.go (line 35) both invoke
ParsePubKeysFromPath(logger, tssPath)with the new signature.- Optional refactor in config.go’s
ParsePubKeysFromPath: create a child logger (e.g.l := logger.With().Str("component","zetaclient.tss.config").Str("dir",tssPath).Logger()) and normalize/expandtssPath(usefilepath.Clean, detect leading~, expand viaos.UserHomeDir).
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (38)
changelog.md(1 hunks)zetaclient/chains/base/observer.go(6 hunks)zetaclient/chains/base/observer_test.go(5 hunks)zetaclient/chains/bitcoin/observer/db.go(1 hunks)zetaclient/chains/bitcoin/observer/event.go(1 hunks)zetaclient/chains/bitcoin/observer/inbound.go(2 hunks)zetaclient/chains/bitcoin/observer/mempool.go(2 hunks)zetaclient/chains/bitcoin/observer/observer.go(1 hunks)zetaclient/chains/bitcoin/observer/outbound.go(4 hunks)zetaclient/chains/bitcoin/observer/utxos.go(2 hunks)zetaclient/chains/bitcoin/observer/witness.go(7 hunks)zetaclient/chains/bitcoin/signer/sign.go(1 hunks)zetaclient/chains/bitcoin/signer/signer.go(3 hunks)zetaclient/chains/evm/observer/inbound.go(14 hunks)zetaclient/chains/evm/observer/observer.go(1 hunks)zetaclient/chains/evm/observer/outbound.go(3 hunks)zetaclient/chains/evm/observer/v2_inbound.go(3 hunks)zetaclient/chains/evm/signer/gas.go(2 hunks)zetaclient/chains/evm/signer/outbound_data.go(3 hunks)zetaclient/chains/evm/signer/signer.go(4 hunks)zetaclient/chains/solana/observer/observer.go(1 hunks)zetaclient/chains/solana/observer/outbound.go(2 hunks)zetaclient/chains/solana/signer/signer.go(7 hunks)zetaclient/chains/sui/signer/signer.go(1 hunks)zetaclient/chains/ton/observer/inbound.go(3 hunks)zetaclient/keys/keys.go(1 hunks)zetaclient/keys/relayer_key.go(1 hunks)zetaclient/maintenance/tss_listener.go(2 hunks)zetaclient/tss/config.go(2 hunks)zetaclient/tss/config_test.go(1 hunks)zetaclient/tss/keygen.go(1 hunks)zetaclient/tss/service.go(4 hunks)zetaclient/tss/setup.go(6 hunks)zetaclient/types/dynamic_ticker.go(0 hunks)zetaclient/zetacore/broadcast.go(2 hunks)zetaclient/zetacore/client_monitor.go(6 hunks)zetaclient/zetacore/client_start.go(2 hunks)zetaclient/zetacore/client_subscriptions.go(1 hunks)
💤 Files with no reviewable changes (1)
- zetaclient/types/dynamic_ticker.go
🧰 Additional context used
📓 Path-based instructions (1)
**/*.go
⚙️ CodeRabbit configuration file
Review the Go code, point out issues relative to principles of clean code, expressiveness, and performance.
Files:
zetaclient/tss/keygen.gozetaclient/chains/solana/observer/outbound.gozetaclient/zetacore/client_start.gozetaclient/chains/bitcoin/signer/sign.gozetaclient/chains/sui/signer/signer.gozetaclient/tss/config_test.gozetaclient/chains/bitcoin/observer/observer.gozetaclient/keys/relayer_key.gozetaclient/chains/evm/observer/outbound.gozetaclient/chains/evm/signer/signer.gozetaclient/chains/bitcoin/signer/signer.gozetaclient/chains/evm/signer/outbound_data.gozetaclient/chains/bitcoin/observer/mempool.gozetaclient/chains/ton/observer/inbound.gozetaclient/chains/evm/observer/observer.gozetaclient/chains/bitcoin/observer/utxos.gozetaclient/keys/keys.gozetaclient/chains/evm/signer/gas.gozetaclient/zetacore/broadcast.gozetaclient/chains/solana/observer/observer.gozetaclient/tss/service.gozetaclient/tss/config.gozetaclient/chains/bitcoin/observer/outbound.gozetaclient/maintenance/tss_listener.gozetaclient/chains/solana/signer/signer.gozetaclient/chains/bitcoin/observer/inbound.gozetaclient/chains/bitcoin/observer/event.gozetaclient/chains/base/observer.gozetaclient/chains/evm/observer/v2_inbound.gozetaclient/tss/setup.gozetaclient/chains/base/observer_test.gozetaclient/zetacore/client_subscriptions.gozetaclient/zetacore/client_monitor.gozetaclient/chains/bitcoin/observer/db.gozetaclient/chains/evm/observer/inbound.gozetaclient/chains/bitcoin/observer/witness.go
🧠 Learnings (10)
📚 Learning: 2025-01-21T04:41:16.947Z
Learnt from: ws4charlie
PR: zeta-chain/node#3381
File: zetaclient/chains/bitcoin/signer/sign.go:165-167
Timestamp: 2025-01-21T04:41:16.947Z
Learning: In Bitcoin outbound transactions, remainingSats cannot be negative after deducting fees and nonceMark because the UTXO selection process (SelectUTXOs) ensures sufficient total input value to cover the withdrawal amount, fees, and nonceMark.
Applied to files:
zetaclient/chains/bitcoin/signer/sign.go
📚 Learning: 2024-09-23T19:51:43.360Z
Learnt from: ws4charlie
PR: zeta-chain/node#2907
File: zetaclient/chains/bitcoin/observer/outbound_test.go:81-82
Timestamp: 2024-09-23T19:51:43.360Z
Learning: In the `mineTxNSetNonceMark` function within `bitcoin/observer/outbound_test.go`, it's acceptable to hardcode the chain ID, as the tests do not require varying chain IDs.
Applied to files:
zetaclient/chains/bitcoin/observer/observer.gozetaclient/chains/bitcoin/observer/utxos.go
📚 Learning: 2025-03-04T22:39:58.395Z
Learnt from: gartnera
PR: zeta-chain/node#3632
File: zetaclient/chains/solana/signer/signer.go:304-304
Timestamp: 2025-03-04T22:39:58.395Z
Learning: The Solana signer implementation in zetaclient/chains/solana/signer/signer.go has limited test coverage, particularly for the transaction broadcasting logic with fallback scenarios. Adding this coverage has been acknowledged as a potential future improvement outside the scope of immediate fixes.
Applied to files:
zetaclient/chains/evm/signer/signer.gozetaclient/chains/bitcoin/signer/signer.gozetaclient/chains/solana/signer/signer.go
📚 Learning: 2025-01-14T00:09:01.416Z
Learnt from: ws4charlie
PR: zeta-chain/node#3306
File: zetaclient/chains/bitcoin/observer/db.go:11-25
Timestamp: 2025-01-14T00:09:01.416Z
Learning: In Bitcoin observer, non-critical DB operations (like saving broadcasted transactions) should log errors but not return them to callers, as the errors are already handled appropriately through logging and don't affect the critical in-memory state.
Applied to files:
zetaclient/chains/bitcoin/signer/signer.go
📚 Learning: 2024-07-04T23:47:56.072Z
Learnt from: ws4charlie
PR: zeta-chain/node#2411
File: zetaclient/orchestrator/orchestrator.go:222-237
Timestamp: 2024-07-04T23:47:56.072Z
Learning: The `GetUpdatedChainObserver` method in the `Orchestrator` class is covered by unit tests in `zetaclient/orchestrator/orchestrator_test.go` and `zetaclient/orchestrator/chain_activate_test.go`.
Applied to files:
zetaclient/chains/evm/observer/observer.gozetaclient/chains/base/observer_test.go
📚 Learning: 2024-09-19T18:22:35.964Z
Learnt from: ws4charlie
PR: zeta-chain/node#2899
File: zetaclient/chains/bitcoin/observer/inbound.go:37-38
Timestamp: 2024-09-19T18:22:35.964Z
Learning: In `BTCInboundEvent`, it's acceptable to use `float64` for monetary values (`Value` and `DepositorFee`) because precision is ensured through conversion to integer when building the vote message.
Applied to files:
zetaclient/chains/bitcoin/observer/inbound.gozetaclient/chains/evm/observer/v2_inbound.gozetaclient/chains/evm/observer/inbound.gozetaclient/chains/bitcoin/observer/witness.go
📚 Learning: 2025-01-21T04:32:31.147Z
Learnt from: ws4charlie
PR: zeta-chain/node#3381
File: zetaclient/chains/bitcoin/signer/outbound_data.go:92-93
Timestamp: 2025-01-21T04:32:31.147Z
Learning: Bitcoin protocol requires amounts to be represented as int64 (in satoshis). The maximum Bitcoin supply of 21M BTC (2.1M satoshis) fits within int64, making the conversion from big.Int to int64 safe for Bitcoin amounts.
Applied to files:
zetaclient/chains/bitcoin/observer/inbound.go
📚 Learning: 2024-08-01T18:08:13.681Z
Learnt from: kingpinXD
PR: zeta-chain/node#2615
File: x/crosschain/keeper/msg_server_vote_outbound_tx_test.go:472-472
Timestamp: 2024-08-01T18:08:13.681Z
Learning: The `SaveFailedOutbound` function in `x/crosschain/keeper/msg_server_vote_outbound_tx.go` requires a string argument for the error message.
Applied to files:
zetaclient/zetacore/client_monitor.gozetaclient/chains/evm/observer/inbound.go
📚 Learning: 2025-01-14T03:39:29.764Z
Learnt from: ws4charlie
PR: zeta-chain/node#3306
File: zetaclient/chains/bitcoin/signer/sign.go:225-233
Timestamp: 2025-01-14T03:39:29.764Z
Learning: The signature hash calculation in Bitcoin TSS transactions using `txscript.NewCannedPrevOutputFetcher([]byte{}, 0)` with correct input amounts has been proven to work reliably in production, despite theoretical concerns about empty previous output fetcher.
Applied to files:
zetaclient/chains/bitcoin/observer/witness.go
📚 Learning: 2024-09-19T18:28:58.296Z
Learnt from: ws4charlie
PR: zeta-chain/node#2899
File: zetaclient/chains/bitcoin/observer/inbound.go:366-371
Timestamp: 2024-09-19T18:28:58.296Z
Learning: The `bitcoin.CalcDepositorFee` function is covered by live tests.
Applied to files:
zetaclient/chains/bitcoin/observer/witness.go
🧬 Code graph analysis (21)
zetaclient/chains/solana/observer/outbound.go (2)
zetaclient/testutils/mocks/tss.go (1)
TSS(19-24)zetaclient/tss/crypto.go (1)
PubKey(28-31)
zetaclient/chains/bitcoin/signer/sign.go (1)
zetaclient/chains/bitcoin/observer/observer.go (1)
Logger(82-88)
zetaclient/tss/config_test.go (1)
zetaclient/tss/config.go (1)
ParsePubKeysFromPath(65-129)
zetaclient/chains/bitcoin/observer/observer.go (1)
zetaclient/logs/fields.go (3)
FieldMethod(7-7)FieldNonce(10-10)FieldTx(12-12)
zetaclient/keys/relayer_key.go (1)
pkg/os/path.go (1)
FileExists(27-33)
zetaclient/chains/evm/observer/outbound.go (1)
zetaclient/logs/fields.go (2)
FieldNonce(10-10)FieldMethod(7-7)
zetaclient/chains/bitcoin/observer/mempool.go (2)
zetaclient/logs/fields.go (3)
FieldMethod(7-7)FieldNonce(10-10)FieldTx(12-12)zetaclient/chains/bitcoin/observer/observer.go (1)
Logger(82-88)
zetaclient/chains/ton/observer/inbound.go (1)
zetaclient/chains/bitcoin/observer/observer.go (1)
Logger(82-88)
zetaclient/chains/evm/observer/observer.go (1)
zetaclient/chains/base/observer.go (1)
Observer(39-79)
zetaclient/chains/bitcoin/observer/utxos.go (4)
zetaclient/logs/fields.go (1)
FieldMethod(7-7)zetaclient/chains/bitcoin/observer/observer.go (1)
Logger(82-88)pkg/chains/conversion.go (1)
NonceMarkAmount(11-14)zetaclient/chains/bitcoin/common/utils.go (1)
GetSatoshis(13-30)
zetaclient/tss/config.go (1)
zetaclient/tss/crypto.go (2)
PubKey(28-31)NewPubKeyFromBech32(41-60)
zetaclient/chains/bitcoin/observer/outbound.go (2)
zetaclient/logs/fields.go (4)
FieldMethod(7-7)FieldNonce(10-10)FieldTx(12-12)FieldOutboundID(13-13)zetaclient/chains/interfaces/interfaces.go (1)
ZetacoreClient(58-114)
zetaclient/chains/bitcoin/observer/inbound.go (3)
zetaclient/logs/fields.go (2)
FieldMethod(7-7)FieldTx(12-12)zetaclient/chains/bitcoin/observer/observer.go (1)
Logger(82-88)zetaclient/chains/base/logger.go (1)
Logger(18-21)
zetaclient/chains/bitcoin/observer/event.go (4)
zetaclient/chains/bitcoin/observer/observer.go (1)
Logger(82-88)zetaclient/logs/fields.go (1)
FieldTx(12-12)zetaclient/types/event.go (3)
InboundCategoryProcessable(26-26)InboundCategoryDonation(29-29)InboundCategoryRestricted(32-32)zetaclient/compliance/compliance.go (1)
PrintComplianceLog(24-57)
zetaclient/chains/base/observer.go (2)
zetaclient/chains/bitcoin/observer/observer.go (2)
Logger(82-88)Observer(97-135)zetaclient/logs/fields.go (1)
FieldMethod(7-7)
zetaclient/chains/evm/observer/v2_inbound.go (1)
zetaclient/logs/fields.go (1)
FieldMethod(7-7)
zetaclient/tss/setup.go (1)
zetaclient/tss/config.go (1)
ParsePubKeysFromPath(65-129)
zetaclient/zetacore/client_monitor.go (1)
zetaclient/logs/fields.go (2)
FieldZetaTx(16-16)FieldMethod(7-7)
zetaclient/chains/bitcoin/observer/db.go (2)
zetaclient/chains/base/observer.go (1)
Observer(39-79)zetaclient/chains/bitcoin/observer/observer.go (1)
Observer(97-135)
zetaclient/chains/evm/observer/inbound.go (2)
zetaclient/chains/evm/common/validation.go (1)
ValidateEvmTxLog(16-30)zetaclient/logs/fields.go (1)
FieldMethod(7-7)
zetaclient/chains/bitcoin/observer/witness.go (2)
zetaclient/logs/fields.go (1)
FieldMethod(7-7)zetaclient/chains/bitcoin/common/tx_script.go (2)
DecodeOpReturnMemo(158-201)DecodeScript(218-231)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
- GitHub Check: Cursor Bugbot
- GitHub Check: build-zetanode
- GitHub Check: lint
- GitHub Check: gosec
- GitHub Check: build-and-test
- GitHub Check: analyze (go)
- GitHub Check: semgrep/ci
- GitHub Check: build
renan061
force-pushed
the
feature/standardize-logging
branch
2 times, most recently
from
39d7155 to
b8eaf9b
Compare
Member
can we maybe replace all usages in this PR? or if this is out of scope open follow up issue for this so we use same approach everywhere? |
renan061
force-pushed
the
feature/standardize-logging
branch
2 times, most recently
from
243f443 to
2313013
Compare
Member
Author
Done. |
skosito
reviewed
Sep 3, 2025
Member
skosito
left a comment
skosito
left a comment
There was a problem hiding this comment.
just couple of minor comments
lumtis
reviewed
Sep 3, 2025
ws4charlie
reviewed
Sep 3, 2025
ws4charlie
reviewed
Sep 3, 2025
ws4charlie
reviewed
Sep 3, 2025
ws4charlie
reviewed
Sep 3, 2025
ws4charlie
reviewed
Sep 3, 2025
ws4charlie
reviewed
Sep 3, 2025
ws4charlie
reviewed
Sep 3, 2025
ws4charlie
reviewed
Sep 3, 2025
ws4charlie
reviewed
Sep 3, 2025
ws4charlie
reviewed
Sep 3, 2025
ws4charlie
reviewed
Sep 3, 2025
ws4charlie
reviewed
Sep 3, 2025
renan061
force-pushed
the
feature/standardize-logging
branch
3 times, most recently
from
c1e609f to
e69e6cb
Compare
ws4charlie
reviewed
Sep 5, 2025
ws4charlie
reviewed
Sep 5, 2025
ws4charlie
reviewed
Sep 5, 2025
ws4charlie
reviewed
Sep 5, 2025
* Replace Msgf for Msg * Use '_' instead of '.' * Start logs with lowercase instead of uppercase characters * Use the constants in the logs module * Use With().Logger() instead of log fields when possible
renan061
force-pushed
the
feature/standardize-logging
branch
from
e69e6cb to
db918ea
Compare
ws4charlie
approved these changes
Sep 8, 2025
skosito
approved these changes
Sep 9, 2025
This was referenced Sep 9, 2025
5 tasks
renan061
added a commit
that referenced
this pull request
Sep 26, 2025
* chore: remove unused DynamicTicker from zetaclient/types * refactor: remove Msgf and refactor zerolog uses * Replace Msgf for Msg * Use '_' instead of '.' * Start logs with lowercase instead of uppercase characters * Use the constants in the logs module * Use With().Logger() instead of log fields when possible
renan061
added a commit
that referenced
this pull request
Sep 26, 2025
* chore: remove unused DynamicTicker from zetaclient/types * refactor: remove Msgf and refactor zerolog uses * Replace Msgf for Msg * Use '_' instead of '.' * Start logs with lowercase instead of uppercase characters * Use the constants in the logs module * Use With().Logger() instead of log fields when possible
renan061
added a commit
that referenced
this pull request
Sep 26, 2025
* chore: remove unused DynamicTicker from zetaclient/types * refactor: remove Msgf and refactor zerolog uses * Replace Msgf for Msg * Use '_' instead of '.' * Start logs with lowercase instead of uppercase characters * Use the constants in the logs module * Use With().Logger() instead of log fields when possible
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 26, 2025
* chore: remove unused DynamicTicker from zetaclient/types * refactor: remove Msgf and refactor zerolog uses * Replace Msgf for Msg * Use '_' instead of '.' * Start logs with lowercase instead of uppercase characters * Use the constants in the logs module * Use With().Logger() instead of log fields when possible
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 3, 2026
* fix: ratelimiting race condition vuln (#4072) * fix: ratelimiting race condition vuln * fix: ratelimiting race condition vuln - Fix race condition in RateLimiter.Release() function - Replace non-atomic check-then-act with atomic decrement and bounds checking - Add comprehensive test suite to verify the fix - Update changelog with PR #4072 * fix: correct atomic implementation to prevent underflow - Replace flawed Add(-1) approach with proper CompareAndSwap - Fix underflow detection issue where uint32 wrap-around was missed - Add TestRateLimiterUnderflowProtection to verify the fix - Ensure Release() never causes negative counters or semaphore over-release * refactor: simplify rate limiter Release() implementation - Remove unnecessary infinite loop in CAS operation - Single CAS attempt is sufficient for race condition protection - Maintains thread-safety while being more efficient - All tests still pass with simplified implementation * fix: correct order of operations in rate limiter Release() - Fix race condition by decrementing counter before releasing semaphore - Ensure pending counter accurately reflects semaphore state - Simplify implementation by using correct operation order - All tests pass with cleaner, more logical approach * test: add tests that reproduce the original race condition vulnerability - Add BuggyRateLimiter that implements the original vulnerable code - Add TestBuggyRateLimiterRaceCondition to demonstrate the race condition - Add TestBuggyRateLimiterStressTest to stress test the vulnerability - Add TestVulnerabilityDemonstration to show before/after comparison - Add TestBuggyRateLimiterExcessiveReleases to show excessive release issues - These tests demonstrate the theoretical vulnerability even if timing makes it hard to reproduce consistently * fix: address race condition and underflow issues in RateLimiter - Fix race condition in Release() by reordering operations (decrement pending first, then release semaphore) - Fix Pending() function to handle negative atomic.Int32 values correctly - Add comprehensive tests to verify fixes - Remove buggy code from tests as requested by reviewers - Document original vulnerability in test comments The original race condition allowed multiple goroutines to release more permits than acquired. The Pending() function could return incorrect values due to negative atomic.Int32 conversion. Fixes: #4072 * refactor: rename test and update changelog to reflect actual improvements - Rename TestVulnerabilityDemonstration to TestRateLimiterRobustness - Update test description to reflect code quality improvements rather than vulnerability fixes - Update changelog entry to match actual changes - Tests still pass, confirming the improvements are working correctly The reviewer correctly pointed out that if tests pass on develop without fixes, then we're improving robustness rather than fixing vulnerabilities. * refactor: remove support for v1 revert address for BTC (#4070) * remove support for v1 revert address for BTC * add changelog --------- Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com> * feat: add support for withdraw using v2 connector contract (#4064) * update go mod * add a new message for migrating funds * add migrate funds to e2e * rebase from develop * add v2 e2e test to check flow * add zeta gateway deposit to zetaclient * add github workflow * update comments * fix code formating * fix code formating * fix code formating * fix unit tests * fix unit tests * revert to old command to start e2e test * remove message for migration and refactor to using contract directly * add changelog * generate files after removing new message * update generated files * update generated files * update go mod * update deposit * add unit tests * add unit tests * generate files * generate files * undo changes based on develop * update deposit and revert smart contract call * rename zeta deposit test file * rename zeta deposit test file * add abort and revert tests * add TestZetaDepositAndCallNoMessage * add TestZetaDepositAndCallNoMessage * remove payable from TestAbort contract * rename to LegacyZETADepositAndCallContract * improve unit test coverage * fix unit tests * add some delay in TestZetacore_SubscribeNewBlocks * update comment for handling zeta token zrc20 * add e2e test * add e2e test for withdraw * refactor ProcessZEVMInboundV2 * add core registry to setup * refactor e2e test helper functions * add unit test for zeta withdraw * add unit test for withdraw and call * resolve comments 1 * add unit test for ProcessRevert * add unit test for ProcessRevert * add unit test for ProcessRevert * improve abort tests * improve abort tests * resolve comments * resolve comments 2 * update upgrade height to 280 to allow the first test to run the entire cycle * wrap zeta mints in tmp context * wrap zeta mint in temp context * rebase * add changelog * add changelog * adjust comments * Update cmd/zetae2e/config/contracts.go Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * fix gas pool zeta calcualation * add unit test for executeWithMintedZeta * fix comments 1 * add unit tests * update test dapp to use zeta token for consuming gas * add core registry to zeta e2e post upgrade handler * revert legacy test * update changes based on comments 1 --------- Co-authored-by: Charlie Chen <34498985+ws4charlie@users.noreply.github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * fix: print error message in detail if unable to decode Bitcoin memo (#4090) * print error message detail when memo decoding failed * add changelog entry * keep invalid memo log on Info level --------- Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com> * test(e2e): update admin e2e tests to use v2 connector (#4071) * update go mod * add a new message for migrating funds * add migrate funds to e2e * rebase from develop * add v2 e2e test to check flow * add zeta gateway deposit to zetaclient * add github workflow * update comments * fix code formating * fix code formating * fix code formating * fix unit tests * fix unit tests * revert to old command to start e2e test * remove message for migration and refactor to using contract directly * add changelog * generate files after removing new message * update generated files * update generated files * update go mod * update deposit * add unit tests * add unit tests * generate files * generate files * undo changes based on develop * update deposit and revert smart contract call * rename zeta deposit test file * rename zeta deposit test file * add abort and revert tests * add TestZetaDepositAndCallNoMessage * add TestZetaDepositAndCallNoMessage * remove payable from TestAbort contract * rename to LegacyZETADepositAndCallContract * improve unit test coverage * fix unit tests * add some delay in TestZetacore_SubscribeNewBlocks * update comment for handling zeta token zrc20 * add e2e test * add e2e test for withdraw * refactor ProcessZEVMInboundV2 * add core registry to setup * refactor e2e test helper functions * add unit test for zeta withdraw * add unit test for withdraw and call * resolve comments 1 * add unit test for ProcessRevert * add unit test for ProcessRevert * add unit test for ProcessRevert * improve abort tests * improve abort tests * resolve comments * resolve comments 2 * update upgrade height to 280 to allow the first test to run the entire cycle * wrap zeta mints in tmp context * wrap zeta mint in temp context * rebase * add changelog * add changelog * adjust comments * Update cmd/zetae2e/config/contracts.go Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * fix gas pool zeta calcualation * add unit test for executeWithMintedZeta * fix comments 1 * add unit tests * update admin * revert unncessary changes * disable account balance verification for admin tests * improve naming for deposit functions * add changelog * update comments * update test legacy test zeta to use EVMAddress * remove skipping admin in upgrade setup --------- Co-authored-by: Charlie Chen <34498985+ws4charlie@users.noreply.github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * test: fix eth deposit test to check balance after deposit (#4118) * check balance after eth deposit test * fix typo * fix import * test: fix flaky Solana depositAndCall tests (#4113) * fix flaky solana depositAndCall tests * add changelog entry * add wait logic inside AssertTestDAppEVMCalled * chore: bump cosmos evm to support querying legacy proposals of type MsgUpdateParams (#4094) * update zeta evm * update commit * fix: use evm chain id from eth config in rpc backend (#4096) * fix: cancel solana WaC if tx size is too large (#4098) * cancel solana WaC if tx size is too large * align the comments with the code * fix: nil reference in trace block (#4093) * update to commit be548f7691876e656ec61aa46e31ed337be92f4e , on branch release/v34 --------- Co-authored-by: skosito <skostic9242@gmail.com> Co-authored-by: Charlie Chen <34498985+ws4charlie@users.noreply.github.com> Co-authored-by: morde08 <peter@zetachain.com> * fix: error when deploying contracts on testnet (#4112) * dont return err if tx is not found in get tx receipt * fix tests * changelog * feat: support hostname in addition to public IP for zetaclient to connect to zetacore (#4068) * save initial work to remote * add unit test and live test for zetacore hostname support * add changelog entry; fix gosec and clean unused code * fix CI upgrade test --------- Co-authored-by: Tanmay <tanmay@zetachain.com> * fix: dbg trace block by number gas limit legacy (#4121) * fix dbg trace by block * PR comments * changelog * fix(cherry-pick): cancel solana WaC if tx size is too large (#4111) * cancel solana WaC if tx size is too large * add changelog entry * chore: remove tx suffix in vote inbound and outbound message names (#4110) * fix(`crosschain`): remove confirmation mode from outbound and inbound digest (#4116) * inbound * . * changelog * refactor(zetacore): overwrite consensus config values for all timeout deltas on startup. (#4097) * update 1 * add start-skip-consensus-overwrite-test * generate files * update tests * add unit tests * add unit tests for GenesisChainID * add unit tests for GenesisChainID * rename genesisChainID * fix typo * remove testnet from overwrite check * refactor: replace []byte(fmt.Sprintf) with fmt.Appendf (#4131) Signed-off-by: yinwenyu6 <yinwenyu6@outlook.com> * feat: Sui message context ID as dynamic field (#4087) * re-enable sui authenticated call * integrate message context ID as dynamic field * add changelog entry * make issueMessageContext function self-contained * fix unit test * remove --skip-dependency-verification in sui gateway upgrade test * cancel withdrawAndCall on invalid payload * adopt new increase_nonce signature to adopt gas refund logic when cancelling a CCTX * apply stringent check on Sui transaction's checkpoint * apply status check on Sui inbound * fix CI upgrade test * fix unit test * chore: fix some function names in comment (#4129) Signed-off-by: pxwanglu <pxwanglu@icloud.com> * chore: fix some observer message names (#4141) * test: fix flaky Solana SPL deposit balance check (#4142) * fix solana e2e SPL balance check by waiting maximum 30 seconds * add changelog entry * refactor: remove intx and outtx deprecated queries (#4150) * refactor: remove intx and outtx deprecated queries * fixes in e2e * chore: remove redundant word in comment (#4149) Signed-off-by: wmypku <wmypku@outlook.com> * test(`e2e`): improve logs for CCTX status assertion (#4147) * improve require status logs * update usage in tests * lint * cursor comment * chore: fix some typos in comment (#4146) Signed-off-by: tzchenxixi <tzchenxixi@icloud.com> * chore: set v35 as upgrade test reference and various clean up (#4115) * add back precompiles * add abci field to proposal * test * enable back * test no creating proposasl * disable zeta-ante * cleanup v33 upgrade helper * add v35 as reference * remove gas stability pool temporary * update to v36 and disable fast confirmation test * bitcoin fast confirmation * increase ersion for zeta * remove erc20 init handler * disable zevm to evm revert for older version * disable zevm to evm revert abort for older version * increase upgrade height * feat: make the gas limit used for gateway calls on ZEVM a configurable parameter (#4153) * add GatewayGasLimit to state * refactor function name from MustGetGatewayGasLimit to GetGatewayGasLimitSafe * update unit tests * update unit tests * update proto files * replace big int with uint64 * changelog * add check of older value * add v4 migration back for authority module * update setup handler to remove setting erc20 module * test changes * revert to using v32 as base branch for upgrades --------- Co-authored-by: lumtis <lucas.bertrand.22@gmail.com> * test(`e2e`): add a gas limit option for ZEVM to EVM call tests (#4145) * add gas limit option * use option for tests * increase further upgrade height * test: use pre-deployed example dapp V2 contract in e2e tests (#4158) * do not deploy example contract in e2e tests, use pre-deployed example dapp V2 instead * add changelog entry * clean up debugging log * remove commented code * add back extra zrc20 SPL balance check * chore(`e2e`): cleanup unused contracts (#4161) * remove contextapp * remove distribute * test: fix flaky depositAndCall test that failed on sender assertion (#4165) * fix flaky depositAndCall caused by sender assertion * add changelog entry * chore(deps): bump github.com/hashicorp/go-getter from 1.7.8 to 1.7.9 (#4148) Bumps [github.com/hashicorp/go-getter](https://github.com/hashicorp/go-getter) from 1.7.8 to 1.7.9. - [Release notes](https://github.com/hashicorp/go-getter/releases) - [Changelog](https://github.com/hashicorp/go-getter/blob/main/.goreleaser.yml) - [Commits](hashicorp/go-getter@v1.7.8...v1.7.9) --- updated-dependencies: - dependency-name: github.com/hashicorp/go-getter dependency-version: 1.7.9 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump github.com/ulikunitz/xz from 0.5.11 to 0.5.14 (#4172) Bumps [github.com/ulikunitz/xz](https://github.com/ulikunitz/xz) from 0.5.11 to 0.5.14. - [Commits](ulikunitz/xz@v0.5.11...v0.5.14) --- updated-dependencies: - dependency-name: github.com/ulikunitz/xz dependency-version: 0.5.14 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump github.com/go-viper/mapstructure/v2 from 2.2.1 to 2.4.0 (#4173) chore(deps): bump github.com/go-viper/mapstructure/v2 Bumps [github.com/go-viper/mapstructure/v2](https://github.com/go-viper/mapstructure) from 2.2.1 to 2.4.0. - [Release notes](https://github.com/go-viper/mapstructure/releases) - [Changelog](https://github.com/go-viper/mapstructure/blob/main/CHANGELOG.md) - [Commits](go-viper/mapstructure@v2.2.1...v2.4.0) --- updated-dependencies: - dependency-name: github.com/go-viper/mapstructure/v2 dependency-version: 2.4.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * refactor: standardize zetaclient logging (#4144) * chore: remove unused DynamicTicker from zetaclient/types * refactor: remove Msgf and refactor zerolog uses * Replace Msgf for Msg * Use '_' instead of '.' * Start logs with lowercase instead of uppercase characters * Use the constants in the logs module * Use With().Logger() instead of log fields when possible * fix: improve zetatool (#4175) * scan gateway events by default for all inbound hashes * scan gateway events by default for all inbound hashes * test(`e2e`): add a E2E test to test depositAndCall with high gas consumption (#4177) * set gas limit to 4m in localnet * add high usage test * changelog * Update changelog.md Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update e2e/e2etests/e2etests.go Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * test(`e2e`): add all chains by default in `start-localnet` (#4163) * chore: add Solana to start-localnet to allow to run local tests * add sui and ton * Update cmd/zetae2e/local/local.go Co-authored-by: Tanmay <tanmay@zetachain.com> --------- Co-authored-by: Tanmay <tanmay@zetachain.com> * chore: remove redundant words (#4179) Signed-off-by: keeghcet <keeghcet@outlook.com> * refactor: omit unnecessary reassignment (#4184) Signed-off-by: fengyuchuanshen <fengyuchuanshen@outlook.com> * fix: force rescan if inbound vote monitoring fails (#4183) * add monitoringErr channel * update to InboundBlockHeight - 1 , for reseting the block * fix unit tests * implement error interface * rename to ErrTxMonitor * add forceResetLastScanned flag * add forceResetLastScanned flag * add mutex to force scan * add changelog * add changelog * update name to wasForceReset * wrap UpdateForceResetLastScanned in mutex * add a bound check to InboundBlockHeight to be safe * Update zetaclient/chains/base/confirmation.go Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com> * Update zetaclient/chains/base/observer.go Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com> * force update for in memory value if forceResetLastScanned is true * add a lock on reading block height * update error message * update changelog * wait till end of scan cycle to toggle the forceUpdateFlag --------- Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com> * fix: remove duplicate solana post-gas-price goroutine (#4194) * feat: observe inbound from previous gateway package after upgrade (#4138) * observe inbound from old gateway package optionally * add changelog entry * add sui inbound cursor migration; add post-upgrade deposit tests * improve comments, logs and naming; fix post-upgrade withdraw failure * protect anyStringMap * add support for <withdrawcap-id> to Sui gateway address * fix CI upgrade test failure * use name previousPackageID and keep name PairID; rename AnyString and cursor migration function; improve test, comments, etc. * replaced assert by require in sui unit test * add support for original packageID in Sui gateway address * avoid wrapping nil error * use previous package ID in post-upgrade Sui deposit test * add support for previous package deprecation and fix upgrade test * fix unit test * add a note to clarify the PackageID argument used for event query * add documents to explain Sui gateway address format in the chain params * refactor: remove unused loggers and log fields (#4180) * chore: remove unused Headers logger * refactor: remove (mostly) unused GasPrice logger * refactor: replace logs.FieldMethod with With().Caller() and standardize logs.FieldModule values * refactor: remove (mostly) unused log fields FieldTracker and FieldConfirmationMode * refactor: replace missed log instances of '.' for '_' * fix: unpack bitcoin revert message without considering 'CallOnRevert' flag (#4169) * enable bitcoin revertMessage and ignore CallOnRevert flag * add changelog entry * update standard memo doc; improve abort address validation * skip incompatible e2e test to allow CI upgrade test to pass * fix: add timeout to monitoring routine (#4196) * add a timeout for vote monitoring thread * add a timeout for vote monitoring thread * add comments * remove typo for cancel call * fix unit tests * Update zetaclient/zetacore/client_vote.go Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com> * Update zetaclient/chains/base/observer.go Co-authored-by: Charlie Chen <34498985+ws4charlie@users.noreply.github.com> --------- Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com> Co-authored-by: Charlie Chen <34498985+ws4charlie@users.noreply.github.com> * refactor: use maps.Copy for cleaner map handling (#4198) Signed-off-by: joemicky <joemickychang@outlook.com> * chore: fix some comments (#4208) Signed-off-by: zhoujiaweii <zjwustc@outlook.com> * fix: update evm version for missing tx types (#4216) * refactor: replace HasPrefix+TrimPrefix with CutPrefix (#4215) Signed-off-by: quantpoet <quantway@outlook.com> * refactor: remove `LastBlockHeight` state variable (#4200) * proto * remove other references * changelog * refactor: add documentation for ZetaClient logging fields (#4174) * refactor: use coin.CoinType for compliance logging * refactor: add documentation for zetaclient logging fields * fix: remove ZetaChain chain ID from GasStabilityPoolBalances query (#4217) * fix query * add test * changelog * add commment * lint * remove gas token address * change error type * refactor: remove index field in ballot (#4205) * refactor: remove index field in ballot * changelog * fix unit tests * refactor: remove `MsgUpdateERC20CustodyPauseStatus` and `MsgMigrateERC20CustodyFunds` (#4199) * make message legacy * remove other reference * changelog * refactor: rename whitelistERC20 into whitelistAsset (#4203) * refactor: rename whitelistERC20 into whitelistAsset * e2e test * e2e test * fix event * simulation * changelogs * update auth list * add migration script * apply comment * feat: provide error information in CCTX struct when Bitcoin deposit fail (#4211) * add error message to CCTX struct when Bitcoin deposit failed * add changelog entry * fix unit test; improve function naming * add unit test for inbound vote digest * exclude inbound observation error message from digest * fix: re-check for finalized ballot when executing inbound vote to create cctx (#4197) * check for finalized block after ballot is finalized * fix unit tests and add changelog * adjust comments * Apply suggestion from @lumtis Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com> * Apply suggestion from @lumtis Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com> * refactor check finalized ballot check to be done before adding the finalizing vote to the ballot * adjust comments * adjust comments * fix comments 2 --------- Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com> * fix: set zeta ante to true in upgrade tests (#4225) * add zeta ante * add to upgrade test regular * add to upgrade test regular * update out of gas test * update out of gas test * fix tss migration test * fix lint issues 1 * update v2 zeta version * chore: resync changelogs with v36 changes (#4223) * fix: skip writing config file to the filesystem (#4210) * comment out writing files to the state * ad changelog * remove commented code * return error from fetching FlagSkipConfigOverwrite * refactor(`observer`): remove deprecated code (#4192) * update proto * update code * changelogs * fix changelog * fix gas limit issue in upgrade test * use ante-zetae2e for admin upgrade tests * test fix * refactor: prepare the client interfaces used by the observer-signers for dry-mode (#4213) refactor: prepare the client interfaces of the observer-signers for dry-mode * feat: enable NoAssetCall from Bitcoin (#4218) * enable NoAssetCall from Bitcoin * add changelog entry * improve comment and log print * revert bitcoin NoAssetCall that carries large excessive funds * adjust btc inbound parsing order; fix test name * improve function and variable names * feat: multiple evm calls in single tx (#4157) * bump protocol contracts * use newer geth version with cancun support * e2e test with 2 deposits in same tx * e2e tests * inbound trackers for multiple events * changelog * generate * fix e2e tests * inbound trackers e2e test * bump protocol contracts * PR comments * PR comment * PR comments * PR comment * lower upgrade height in upgrade tests * try diff upgrade height * upgrade additional fee in upgrade v36 handler * chore: fix function name in comment (#4238) Signed-off-by: russcoss <russcoss@outlook.com> * revert: add timeout to monitoring routine" (#4244) Revert "fix: add timeout to monitoring routine (#4196)" This reverts commit 65f227b. * fix(e2e): check test contracts deployment (#4251) * fix(e2e): check test contracts deployment * add other contracts * changelog * fix chain to wait tx from * revert: force rescan if inbound vote monitoring fails (#4250) * feat: refund a portion of remaining unused tokens to user (#3734) * add new field to cctx structure to track user gas burned * add unit tests * add doc * add unit test for migration * add check for pre upgrade cctxs * add older logic for handling cctxs created before upgrade * remove LegacyChainParams * add unit test for refund gas fee * remove old migration * add temp note for PR review * fix typo * fix typo * generate files * add missing test case * add missing test case * refactor based on comments * update EtherWithdrawRestricted test * update EtherWithdrawRestricted test * update EtherWithdrawRestricted test * enable all tests * update module version for observer migration * generated docs * generated docs * remove deprecated comments * use older chainparams for upgrade tests * use older chainparams for upgrade tests * changes based on comments 1 * add addition param to CallZRC20Deposit * update comments for legacy cctx and refactor unit tests to use the parent function ManageUnusedGasFee * adjust non zevm chain test cases * fix lint errors * fix comments and rebase develop * add statement to ErrParamsStabilityPoolPercentage * Update x/crosschain/keeper/msg_server_vote_outbound.go Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com> * fix comments 3 * rebase develop 2 * rebase develop 2 * update admin test --------- Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com> * test: add zetaclient only upgrade tests (#4310) * add file based trigger for zetaclient binary download * update zetae2e * add new makefile commands * update comments * remove wait for upgrade height * upgrade contracts on zetaclient test * fixes 1 * add issue to track sui upgrade tests * add issue to track sui upgrade tests * add nosec * fix(`zetatool`): add missing networks (#4424) * add missing networks * add worldchain config * add world chain to unit tests * update tests * add zetaclient changes from main * disable e2e tests not working in the first test run * set light upgrade tests as default for zetaclient label * update rpc import * update contract copy * fix update for removing nonces only if the tx is finalized * fix update for removing nonces only if the tx is finalized * update changelog * rebase develop * rebase develop * generate files * reduced upgrade height for connector-migration-test * update comment for tss migration test --------- Signed-off-by: yinwenyu6 <yinwenyu6@outlook.com> Signed-off-by: pxwanglu <pxwanglu@icloud.com> Signed-off-by: wmypku <wmypku@outlook.com> Signed-off-by: tzchenxixi <tzchenxixi@icloud.com> Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: keeghcet <keeghcet@outlook.com> Signed-off-by: fengyuchuanshen <fengyuchuanshen@outlook.com> Signed-off-by: joemicky <joemickychang@outlook.com> Signed-off-by: zhoujiaweii <zjwustc@outlook.com> Signed-off-by: quantpoet <quantway@outlook.com> Signed-off-by: russcoss <russcoss@outlook.com> Co-authored-by: 0xM3R <omer@zetachain.com> Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com> Co-authored-by: Charlie Chen <34498985+ws4charlie@users.noreply.github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: morde08 <peter@zetachain.com> Co-authored-by: skosito <skostic9242@gmail.com> Co-authored-by: yinwenyu6 <yinwenyu6@outlook.com> Co-authored-by: pxwanglu <pxwanglu@icloud.com> Co-authored-by: wmypku <wmypku@outlook.com> Co-authored-by: tzchenxixi <tzchenxixi@icloud.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Renan <renan.061@gmail.com> Co-authored-by: keeghcet <keeghcet@outlook.com> Co-authored-by: fengyuchuanshen <fengyuchuanshen@outlook.com> Co-authored-by: Renan <renan@zetachain.com> Co-authored-by: joemicky <joemickychang@outlook.com> Co-authored-by: zhoujiaweii <zjwustc@outlook.com> Co-authored-by: quantpoet <quantway@outlook.com> Co-authored-by: russcoss <russcoss@outlook.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 6, 2026
* fix: use evm chain id from eth config in rpc backend (#4096)
* fix: cancel solana WaC if tx size is too large (#4098)
* cancel solana WaC if tx size is too large
* align the comments with the code
* fix: nil reference in trace block (#4093)
* chore : bump cosmos evm to support querying legacy proposals of type MsgUpdateParams (#4095)
* update zeta evm
* update commit
* update to commit be548f7691876e656ec61aa46e31ed337be92f4e , on branch release/v34
---------
Co-authored-by: morde08 <peter@zetachain.com>
* fix: remove store initilization for erc20 module (#4103)
* fix(v34-only): use SAFE confirmation mode for all inbound votes (#4117)
* use SAFE confirmation mode for all inbound votes
* move confirmation mode update logic right before signing the inbound vote message
* fix: port Bitcoin memo decoding error log print to v34 (#4100)
port PR 4090 to v34
* fix: backport dbg trace block by number gas limit legacy (#4119)
* fix: backport error when deploying contracts on testnet (#4120)
* refactor(backport): overwrite consensus config values for all timeout deltas on startup (#4126)
* feat: add conditional logic for adding erc20 module based on chain id (#4125)
* add conditional logic for erc20 module upgrade
* bump cosmos version to run evm migration 6 to 7
* add unit tests
* update handler to panic
* add changelog
* format files
* update changelog
* bump cosmos/evm to release/v35
* add back comments for IBC
* add back comments for IBC
* feat(backport/v36): make the gas limit used for gateway calls on ZEVM a configurable parameter (#4154)
* cherry pick
* cherry pick
* update unit tests
* update unit tests
* cherry pick
* replace big int with uint64
* add check of older value
* update upgrade test and changelog
* fix function call
* add v4 migration back for authority module
* add v4 migration back for authority module
---------
Co-authored-by: Tanmay <tanmay.bhattacharya.smit@gmail.com>
* fix: skip writing config file to the filesystem (#4206)
* skip writing config file
* use the value of skip-config-overwrite flag without restrictions for mainnet
* add comments
* remove unused functions
* remove unit tests for unused functions
* fix(backport/v36): unpack bitcoin revert message without considering 'CallOnRevert' flag (#4181)
* unpack revert message from Bitcoin memo without considering flag
* skip incompatible e2e test to allow CI upgrade test to pass
* fix(backport): force rescan if inbound vote monitoring fails using a context that can timeout (#4202)
* backport changes for rescan logic
* remove changelog
* format files
* use context with timeout
* change error message
* cherry pick changes for context with timeout
* format package and fix lint
---------
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
* chore(backport/v36): cherry pick e2e tests changes for live networks (#4220)
* fix: add a simple check for finalizing vote (#4236)
* revert: add a simple check for finalizing vote (#4240)
Revert "fix: add a simple check for finalizing vote (#4236)"
This reverts commit d8dc5bac363cbfeb8267705a378fc5a7803e24df.
* revert: force rescan if inbound vote monitoring fails using a context that can timeout (#4241)
Revert "fix(backport): force rescan if inbound vote monitoring fails using a…"
This reverts commit 70ab2a724f96bcf48d2ece29674a8bfbf9bb4469.
* fix(e2e): check test contracts deployment (#4252)
* fix(e2e): check test contracts deployment
* add other contracts
* fix chain to wait tx from
* fix check
* docs: add release lifecycle in the documentation (#4265)
* add a note for releases
* add release lifecycle docs
* refactor: omit unnecessary reassignment (#4264)
Signed-off-by: letreturn <letreturn@outlook.com>
Co-authored-by: Charlie Chen <34498985+ws4charlie@users.noreply.github.com>
* refactor(backport): standardize zetaclient logging (#4144) (#4267)
* chore: remove unused DynamicTicker from zetaclient/types
* refactor: remove Msgf and refactor zerolog uses
* Replace Msgf for Msg
* Use '_' instead of '.'
* Start logs with lowercase instead of uppercase characters
* Use the constants in the logs module
* Use With().Logger() instead of log fields when possible
* fix(backport): remove duplicate solana post-gas-price goroutine (#4194) (#4268)
* refactor(backport): remove unused loggers and log fields (#4180) (#4269)
* chore: remove unused Headers logger
* refactor: remove (mostly) unused GasPrice logger
* refactor: replace logs.FieldMethod with With().Caller() and standardize logs.FieldModule values
* refactor: remove (mostly) unused log fields FieldTracker and FieldConfirmationMode
* refactor: replace missed log instances of '.' for '_'
* refactor(backport): add documentation for ZetaClient logging fields (… (#4270)
refactor(backport): add documentation for ZetaClient logging fields (#4174)
* refactor: use coin.CoinType for compliance logging
* refactor: add documentation for zetaclient logging fields
* chore: fix some function names (#4273)
Signed-off-by: yajianggroup <yajianggroup@outlook.com>
* refactor(backport): prepare the client interfaces used by the observe… (#4271)
refactor(backport): prepare the client interfaces used by the observer-signers for dry-mode (#4213)
refactor: prepare the client interfaces of the observer-signers for dry-mode
* refactor: replace the deprecated function in the ioutil package (#4275)
Signed-off-by: mickychang9 <mickychang9@outlook.com>
* feat: multiple evm calls (#4274)
* multiple evm calls in single tx
* gen testdappv2
* cleanup after merge
* ensure gateway proxy is deployed in e2e tests
* fix upgrade tests
* changelog
* PR comments
* feat: add dry-mode support for TON (#4277)
* feat: add dry-mode support for TON
* fix: address review comments
* ci: increase timeout for solana e2e tests (#4276)
* Increase timeout for solana e2e tests
* Remove timeout, but run the test one hour earlier.
* extend timeout for solana
* feat: add feature flag for multiple evm calls (#4288)
* add feature flag for multiple evm calls
* add feature flag to inbound tracker processing
* fix e2e test inbound trackers
* PR review and refactoring
* add todo with issue
* changelog
* use zetae2e ante for upgrade tests
* chore: increase upgrade test height (#4303)
* chore: increase upgrade test height
* test even higher block
* try 300 block height
* refactor: add `zrepo` package to zetaclient with dry-mode (#4296)
refactor: add zrepo package to zetaclient with dry-mode
* ci: remove upgrade tests from merge queue ci (#4309)
* test(`e2e`): improve local stress tests to replicate better live networks (#4293)
* update params
* fix gas limit
* set gas limit to 4m in localnet
* add high usage test
* typo
* set mem pool
* add stress zevm test
* some tests
* send zevm stress tx as batch
* add batch support
* revert back local config
* chore: add Solana to start-localnet to allow to run local tests
* add sui and ton
* improve eth withdraw stress
* use batch model for deposit stress tests
* improve retry logic
* remove unnecessary logs
* fix lint
* fix deposit
* changelogs
* add nosec
* Update changelog.md
Co-authored-by: skosito <skostic9242@gmail.com>
* apply comments
* use deposit and call
* fix last comments
* use 50m for block size
* revert back 30m block
---------
Co-authored-by: skosito <skostic9242@gmail.com>
* chore: fix inconsistent function name in comment (#4297)
Signed-off-by: russcoss <russcoss@outlook.com>
* fix: stop ProcessOutboundTrackers from breaking when it finds an error (#4305)
* feat: localnet monitoring and observability improvements (#4314)
* make PR against develop branch
* add monitoring profile to makefile
* update dashboards
* update grafana image
* fix dashboards
* update namespace to cometbft
* fix dashboard typo
* update dashboard defaults
* fix: adjust inbound retry gas limit; stop broadcasting tx if mempool is congested or base fee too high (#4291)
* adjust inbound retry gas limit; stop broadcasting tx if mempool is congested
* add changelog entry
* use write lock for delete
* add unconfirmed txs count to config and AppContext; skip observation if mempool is congested
* rename functions
* improve naming and documentation; add log print when skipping observation
* add detailed description for inbound retry gas limit adjustment
* do not consider zetacore mempool congestion by default
* consolidate observation skipper functions; print sampled Info logger when observation is skipped
* unit test observation skipper
* rename Bitcoin mempool monitoring goroutine and improve observation skipper description
* configure maximum base fee
* fix gas price observation skipper
* convert Gwei to wei for the max base fee check
* add changelog description for MaxBaseFee
* fix unit test compile
* fix unit test
* feat: add support for Solana Address Lookup Table in withdraw and call (#4266)
* add support for ALT
* split legacy withdraw and call alt to separate test
* fix compile after merge
* add spl e2e test
* ci fixes
* add outbound tests for alt msgs
* PR comments coderabbit
* PR comments
* add feature flag for solana alt
* lint
* fix e2e test
* fix e2e test
* PR comments
* Trigger rebuild
* feat: monitor failed inbound vote and add to an inbound tracker cache (#4295)
* partially cherry-pick PR 4183 and 4196 to monitor failed inbound vote
* implement the backlog for failed inbound vote
* add changelog entry
* fix changelog grammar
* use the internal tracker terminology; use separate goroutine to process internal trackers
* fix internal tracker unit test and update changelog description
* put a limit on number of inbound trackers to process per ticker
* remove unused constant
* fix generte
* remove internal tracker if it was already voted by the observer
* fix unit test
---------
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
* feat: add dry-mode to Sui and add client wrappers to Sui and TON (#4313)
* feat: add dry-mode to Sui
* refactor: add client wrappers to Sui and TON
* refactor: improve logging messages and code comments
* feat: add dry-mode to Solana (#4317)
* chore: adding ABI used by precompiles. (#4311)
* Adding ABI for precompiles
* added readmes
* refactor: use maps.Clone to simplify code (#4319)
Signed-off-by: yajianggroup <yajianggroup@outlook.com>
* chore: fix some comments (#4331)
Signed-off-by: letreturn <letreturn@outlook.com>
* test(e2e): update local chain params for more performant outbound processing (#4318)
* remove useless comment
* improve parameters
* update for local bitcoin
* increase max block size
* revert chain param changes
* update chain params in e2e setup
* feat: add dry-mode to Bitcoin (#4325)
* feat: add dry-mode to EVM (#4326)
* feat: add TSS client dry-wrapper (#4330)
* chore: upgrade cometbft patch version (#4337)
* chore: upgrade cometbft patch version
* chore: run go mod tidy
* refactor: set verbose logs for event parsing error as debug (#4345)
* change invalid event to debug
* skip ton log if zero logs
* generate
* chore(deps): bump github.com/go-viper/mapstructure/v2 from 2.2.1 to 2.4.0 (#4334)
chore(deps): bump github.com/go-viper/mapstructure/v2
Bumps [github.com/go-viper/mapstructure/v2](https://github.com/go-viper/mapstructure) from 2.2.1 to 2.4.0.
- [Release notes](https://github.com/go-viper/mapstructure/releases)
- [Changelog](https://github.com/go-viper/mapstructure/blob/main/CHANGELOG.md)
- [Commits](https://github.com/go-viper/mapstructure/compare/v2.2.1...v2.4.0)
---
updated-dependencies:
- dependency-name: github.com/go-viper/mapstructure/v2
dependency-version: 2.4.0
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* chore(deps): bump github.com/ulikunitz/xz from 0.5.11 to 0.5.14 (#4333)
Bumps [github.com/ulikunitz/xz](https://github.com/ulikunitz/xz) from 0.5.11 to 0.5.14.
- [Commits](https://github.com/ulikunitz/xz/compare/v0.5.11...v0.5.14)
---
updated-dependencies:
- dependency-name: github.com/ulikunitz/xz
dependency-version: 0.5.14
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* chore(deps): bump github.com/hashicorp/go-getter from 1.7.8 to 1.7.9 (#4332)
Bumps [github.com/hashicorp/go-getter](https://github.com/hashicorp/go-getter) from 1.7.8 to 1.7.9.
- [Release notes](https://github.com/hashicorp/go-getter/releases)
- [Changelog](https://github.com/hashicorp/go-getter/blob/main/.goreleaser.yml)
- [Commits](https://github.com/hashicorp/go-getter/compare/v1.7.8...v1.7.9)
---
updated-dependencies:
- dependency-name: github.com/hashicorp/go-getter
dependency-version: 1.7.9
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* test: skip spawning Solana and Sui for ETH stress tests (#4346)
* update docker compose
* update init condition
* fix: update zetachain-exporter to v4.11.0 for localnet support (#4341)
* update zetachain-exporter to v4.11.0 for localnet support
* Update Makefile
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
---------
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
* chore: add precompile metadata for blockscout explorer (#4350)
* Adding ABI for precompiles
* added readmes
* updated metadata for bs
* fixed precompile version in metadata
* fixed abi format
* fixed compiler version
* test: fix eth stress test timeout (#4321)
* fix eth stress test timeout
* decrease default mempool threshold
* add minimum retry interval logic to internal tracker
* set PostVoteInboundGasLimit back to 500K; set block max gas to 50M
* avoid adding finalized or voted ballot to internal tracker cache
* rename DefaultMempoolSize as DefaultAppMempoolSize
* add changelog entry
* update time stamp only for first MaxInboundTrackersPerScan internal trackers
* print RPC error logs from ballotIsFinalizedOrVoted instead of ignore
* chore: upgrade cometbft patch version (#4337)
* chore: upgrade cometbft patch version
* chore: run go mod tidy
* refactor: set verbose logs for event parsing error as debug (#4345)
* change invalid event to debug
* skip ton log if zero logs
* generate
* chore(deps): bump github.com/go-viper/mapstructure/v2 from 2.2.1 to 2.4.0 (#4334)
chore(deps): bump github.com/go-viper/mapstructure/v2
Bumps [github.com/go-viper/mapstructure/v2](https://github.com/go-viper/mapstructure) from 2.2.1 to 2.4.0.
- [Release notes](https://github.com/go-viper/mapstructure/releases)
- [Changelog](https://github.com/go-viper/mapstructure/blob/main/CHANGELOG.md)
- [Commits](https://github.com/go-viper/mapstructure/compare/v2.2.1...v2.4.0)
---
updated-dependencies:
- dependency-name: github.com/go-viper/mapstructure/v2
dependency-version: 2.4.0
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* chore(deps): bump github.com/ulikunitz/xz from 0.5.11 to 0.5.14 (#4333)
Bumps [github.com/ulikunitz/xz](https://github.com/ulikunitz/xz) from 0.5.11 to 0.5.14.
- [Commits](https://github.com/ulikunitz/xz/compare/v0.5.11...v0.5.14)
---
updated-dependencies:
- dependency-name: github.com/ulikunitz/xz
dependency-version: 0.5.14
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* chore(deps): bump github.com/hashicorp/go-getter from 1.7.8 to 1.7.9 (#4332)
Bumps [github.com/hashicorp/go-getter](https://github.com/hashicorp/go-getter) from 1.7.8 to 1.7.9.
- [Release notes](https://github.com/hashicorp/go-getter/releases)
- [Changelog](https://github.com/hashicorp/go-getter/blob/main/.goreleaser.yml)
- [Commits](https://github.com/hashicorp/go-getter/compare/v1.7.8...v1.7.9)
---
updated-dependencies:
- dependency-name: github.com/hashicorp/go-getter
dependency-version: 1.7.9
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* test: skip spawning Solana and Sui for ETH stress tests (#4346)
* update docker compose
* update init condition
* fix: update zetachain-exporter to v4.11.0 for localnet support (#4341)
* update zetachain-exporter to v4.11.0 for localnet support
* Update Makefile
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
---------
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
* chore: add precompile metadata for blockscout explorer (#4350)
* Adding ABI for precompiles
* added readmes
* updated metadata for bs
* fixed precompile version in metadata
* fixed abi format
* fixed compiler version
* renan comments
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: morde08 <peter@zetachain.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: Charlie <31941002+CharlieMc0@users.noreply.github.com>
* feat: add dry-wrappers to zetacore client (#4323)
* feat: add dry-wrappers to zetacore client
* fix: address reviews
* fix: iterate all sui outbound tracker hashes (#4340)
* iterate all sui outbound tracker hashes
* add changelog entry
* remove log message by using Send
* feat: missing fields in msg hash for solana outbounds (#4328)
* missing fields in msg hash for solana outbounds
* changelog
* lint
* update gateway so file
* feat: add dry-mode configuration (#4348)
* feat: add mode option in ZetaClient configuration
* fix: address reviews
* test: fix too many internal trackers in 'start-stress-test-eth' (#4351)
* fix many internal trackers in eth stress test
* add changelog entry
* add description for newly added constant for readibility; improve changelog
* test: add tests related to dry-mode (#4347)
* feat: add metrics for monitoring inbound voting through blockscan and trackers (internal / external) (#4342)
* update metric definations
* add metrics update
* update comments for evm
* add unit test for metrics
* add changelog
* update comments
* format files
* update naming
* add a grafana dashboard for localnet
* update dashboard
* add section for internal trackers
* update docker compose
* update prometheus to scrape data from all zetaclient nodes
* update susccess rate
* use absent in success rate
* make success rate simpler
* remove monitoring for e2e test
---------
Co-authored-by: Renan <renan@zetachain.com>
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
* ci: create a separate release workflow for zetaclient and zetacore (#4329)
* publish release actions
* gorelease new files
* fix security warning
* fix coderabbit comments
* reorganize workflow
* Update .github/workflows/release-template.yml
Co-authored-by: semgrep-code-zeta-chain[bot] <181804379+semgrep-code-zeta-chain[bot]@users.noreply.github.com>
* Update .github/workflows/release-template.yml
Co-authored-by: semgrep-code-zeta-chain[bot] <181804379+semgrep-code-zeta-chain[bot]@users.noreply.github.com>
---------
Co-authored-by: semgrep-code-zeta-chain[bot] <181804379+semgrep-code-zeta-chain[bot]@users.noreply.github.com>
* chore: fix function name in comment (#4364)
Signed-off-by: vastonus <vastonus@outlook.com>
* feat: add support for zetaclient external DNS name (#4254)
* add support for zetaclient external DNS name
* add changelog entry
* point to go-tss tag; fix changelog PR # and add zetaclient config description
* add zetaclient config file validation method
* chore: Update Twitter link to new handle (#4366)
* refactor: set propose/prevote/precommit delta timeouts to 200ms (#4360)
* Initial plan
* consensus: set timeout_*_delta to 200ms in test/localnet configs
Co-authored-by: CharlieMc0 <31941002+CharlieMc0@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: CharlieMc0 <31941002+CharlieMc0@users.noreply.github.com>
Co-authored-by: morde08 <peter@zetachain.com>
* feat: Sui message context ID as dynamic field (#4127)
* backport PR 4087 to v35
* fix CI upgrade test
* fix unit test
* avoid wrapping nil error
* update the TODO comment for broken Sui e2e test in the upgrade
* feat: observe inbound from previous gateway package after upgrade (#4182)
* backport PR 4087 to v35
* fix CI upgrade test
* fix unit test
* avoid wrapping nil error
* backport PR 4138
* fix compile error
* add support for previous package deprecation; fix upgrade test and unit test
* add a note to clarify the PackageID argument used for event query
* add documents to explain Sui gateway address format in the chain params
* update the TODO comment for broken Sui e2e test in the upgrade
* chore: remove repetitive words in comment (#4353)
Signed-off-by: withtimezone <with_timezone@outlook.com>
Co-authored-by: Charlie Chen <34498985+ws4charlie@users.noreply.github.com>
* chore: combine metadata file for precompile ABI (#4369)
* adding combined file for BS
* adding combined file for BS
* docs: add documentation for ZetaClient execution modes (#4358)
* docs: add documentation for ZetaClient execution modes
* fix: address reviews
* docs: add version table and update release process (#4365)
* revamp version file
* update links
* add a few links
* update release lifecycle do
* Apply suggestion from @coderabbitai[bot]
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
* apply comments
---------
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
* refactor: replace mock generation with (broadned) Go file generation (#4367)
* fix(monitoring): update zetachain-exporter to fix bug with localnet mode (#4370)
add signer sync localnet dashboard, fix bug with localnet mode for zetachain-exporter
* fix: upgrade test on develop (#4375)
* remove default gas limit from genesis
* fix keygen in upgrade test
* fix lint
---------
Co-authored-by: Charlie Chen <charliec@zetachain.com>
* test(e2e): json rpc checks during e2e and upgrade tests (#4357)
* add e2e test to check most important rpc methods before and after upgrade
* ci fixes
* lint
* PR comments
* PR comments
* test(backport): add zetaclient only upgrade tests (#4376)
* add zetaclient upgrade tests
* update comment
* use temp file
* refactor: upgrade protocol contract to repo `protocol-contracts-evm` and v15 (#4356)
* update go mod
* update all imports
* update go mod
* fix binding and comment some tests
* conflicts fixes
* changelogs
* disable zeta v2 e2e tests
* disable e2e test for zeta v2
* conflict fixes
* upgrade contract version
* update commit -
* update commit with release
* feat: disable TSS service in dry mode (#4384)
* fix: filter out nil address to prevent error logs (#4386)
* filter out nil address to filter nil connections
* add changelog
* feat: add chaos mode (#4359)
* feat: add chaos mode
* fix: address reviews (kingpinXD)
* fix: address reviews (lumtis)
* ci: fix duplicate env in the release workflow (#4385)
fix env error
* feat: shutdown zetaclient if zetacore is in syncing status (#4362)
* add a listner to check sync status
* add oncomplete
* add changelog
* add unit test
* add comments
* rebase develop
* rebase develop
* update function name to wait until syncing
* update function name to wait until syncing
* add unit test
shutdown cancelled if zetacore stops syncing before timeout
* increase assert timer for test
* Update zetaclient/maintenance/shutdown_listener.go
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
---------
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
* feat: add number of connected peers to tss keygen log (#4378)
* add number of peers to keygen log
* update pr id
* update log output
* update log output
* reset to older log lines
* generate files
* refactor: base validation on zetaclient config file (#4361)
* add support for zetaclient external DNS name
* add changelog entry
* point to go-tss tag; fix changelog PR # and add zetaclient config description
* add zetaclient config file validation method
* add basic validation on zetaclient config file
* add changelog entry
* add description to zetaclient config unit test and minor improvement
* standardize config file error message format
* configure cosmos sdk config in zetaclient supervisor and unit test
* fix format
* fix CI simulation test
* feat: Add test binaries build workflow (#4383)
* feat: Add test build release workflow
* test
* fix: make
* feat: add checks and notifs
* fix: refactor
* feat: refactor into multiple jobs
* fix: refactor
* fix: add description comment
* fix: remove bucket name from summary
* test: update e2e to set higher timeouts when running stress test (#4395)
* update to using higher timeouts when running stress tests
* add changelog
* docs: update matrix table with new released versions (#4390)
* update matrix table
* add note for release
* update last updated
* comments
* chore: remove repetitive words (#4388)
* chore: remove repetitive words
Signed-off-by: findmyhappy <findhappy@sohu.com>
* Update .github/workflows/semgrep.yml
Co-authored-by: Renan <renan.061@gmail.com>
---------
Signed-off-by: findmyhappy <findhappy@sohu.com>
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
Co-authored-by: Renan <renan.061@gmail.com>
Co-authored-by: Renan <renan@zetachain.com>
* feat: add new dry zetaclient to localnet (#4387)
* feat: add new dry zetaclient to localnet
* fix: address reviews (lumtis)
* fix: address reviews (skosito)
* refactor: change client mode config (#4391)
* refactor: change client mode config
* fix: address reviews (skosito)
* fix: address reviews (lumtis)
* fix: address reviews (coderabbitai)
* fix: address reviews (lumtis)
* ci: fix branch name rule to include all release branches (#4398)
ci(backport/zetaclient_v37): fix branch name rule to include all release branches
* docs: add documentation for gas and fees with ZetaChain (#4394)
* recreate docs
* add link to readme
* start deposit sections
* add bitcoin fee
* Update docs/zetacore/gas_and_fees.md
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
* Update docs/zetacore/gas_and_fees.md
Co-authored-by: Renan <renan@zetachain.com>
* Update docs/zetacore/gas_and_fees.md
Co-authored-by: Tanmay <tanmay@zetachain.com>
* apply comments
* add Solana network fees
---------
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: Renan <renan@zetachain.com>
Co-authored-by: Tanmay <tanmay@zetachain.com>
* fix: wrong error usage for aborted cctx error message (#4405)
* chore: fix some typos in comments (#4409)
Signed-off-by: claudecodering <claudecoder@outlook.com>
* test: add chaos mode capabilities to zetaclient localnet (#4408)
* feat: add chaos mode capabilities to zetaclient localnet
* fix: address reviews (coderabbitai)
* fix: address reviews (lumtis)
* feat: Add ref to test binaries workflow (#4410)
* feat: Add ref to test binaries workflow
* docs: move to further reading section
* fix: load inbound cursors for each supported packages from db (#4403)
* load inbound cursors for each packages from database
* add changelog entry
* fix: retry Sui inbound if the inbound vote RPC failed (#4401)
* do not skip inbound when vote inbound RPC failed
* add changelog entry
* wraps two errors into one without convert the second into string
* chore(deps): bump github.com/consensys/gnark-crypto from 0.16.0 to 0.18.1 (#4404)
chore(deps): bump github.com/consensys/gnark-crypto
Bumps [github.com/consensys/gnark-crypto](https://github.com/consensys/gnark-crypto) from 0.16.0 to 0.18.1.
- [Release notes](https://github.com/consensys/gnark-crypto/releases)
- [Changelog](https://github.com/Consensys/gnark-crypto/blob/v0.18.1/CHANGELOG.md)
- [Commits](https://github.com/consensys/gnark-crypto/compare/v0.16.0...v0.18.1)
---
updated-dependencies:
- dependency-name: github.com/consensys/gnark-crypto
dependency-version: 0.18.1
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* chore: fix the inconsistent method names in the comments (#4421)
Signed-off-by: rustversion <rustverion@outlook.com>
* feat: add devnet command to create a fork from existing node data (#4419)
* refactor start command
* update error messages
* update error messages
* generate files
* modify slashing info
* update node shutdown to add grace duration
* add changelog
* add changelog
* generate files
* start json rpc server in sync
* add python script to start a forked node
* replace fmt.Errorf with error.wrap
* rename import to codectypes
* rename testnet to devnet
* rename testnet to devnet
* generate files
* fix gosec warnings
* ignore close error for cleanup
* chore: fix a large number of spelling issues (#4432)
* chore: fix a large number of spelling issues
Signed-off-by: tinyfoolish <tinyfoolish@outlook.com>
* Update cmd/zetatool/cli/cctx_tracker.go
* Update e2e/e2etests/test_bitcoin_deposit_and_withdraw_with_dust.go
* Update e2e/e2etests/test_bitcoin_deposit_and_withdraw_with_dust.go
---------
Signed-off-by: tinyfoolish <tinyfoolish@outlook.com>
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
* fix: temporarily disable zetaclient public DNS usage to avoid start failure (#4434)
* temporarily disable zetaclient public DNS usage
* add changelog entry
* Update changelog.md
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
---------
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
* chore: bump sol contracts with remove max payload check change (#4416)
bump sol contracts to remove max payload check
* refactor: replace interface{} with any for clarity and modernization (#4435)
Signed-off-by: sunnyraindy <sunnyraindy@outlook.com>
* fix: resolve IP address from public DNS and then pass it to go-tss (#4437)
* resolve IP address from public DNS and then pass it to go-tss
* add changelog entry
* sort IP addresses to be deterministic
* return error if both public IP or DNS are missing
* clean up TODO github link
* feat: add an option to trigger upgrade script after forking a network (#4428)
* refactor start command
* update error messages
* update error messages
* generate files
* modify slashing info
* update node shutdown to add grace duration
* add changelog
* add changelog
* generate files
* start json rpc server in sync
* add optional upgrade trigger
* add python script to start a forked node
* replace fmt.Errorf with error.wrap
* rename import to codectypes
* update python script to include upgrade trigger
* cache testnet snapshot for testing
* add upgrade scheduling to devnet
* use dvent for upgrade script
* add unit test for download info
* suppress nosec warnings
* ignore error on cleanup
* add os to the downloadInfo json
* add a constant for DefaultUpgradeHeighOffset
* fixes for comments
* added checksum to the sample script
* fix: update effective gas price calculation (#4443)
* update effective gas price calcualtion
* fix unit tests
* add changelog
* update comments
* add explicit error handling for all tx types that support EIP 1559 style gas prices
* set nil value for effective gas price
* undo setting effective gas price to nil
* test: add new chaos mode profiles (#4440)
* test profiles
* fix solana chaos test
* add back generated files
* add back generated files
* add changelog
* use any instead of interface
* fix naming
* add chaos stress test
* fix: fix Sui example deployment by removing gateway object reference (#4414)
* remove gateway object reference from Sui example package
* add changelog entry
* remove unused error from sui example
* feat: a sequential batch TSS keysign scheduler for EVM chain (#4427)
* initial PoC of batch keysign for eth chain
* add comments in functions; consolidate AddKeysignInfo and GetSignature into one method
* improved code quality using separate files; refined batch keysign logic
* refined batch keysign logic to achieve stable performance
* use TSS nonce as starting point for keysign; improve code description
* use artificial height for batch keysign
* remove cctx height from keysign information
* improve function name and comments
* add changelog entry and update existing unit tests
* fix gosec and lint
* remove unused height; remove unused context from evm signer methods; improve comment
* add unit tests for batch keysign and tss service
* add a few more log messages in batch keysign
* add a few more fields to batch keysign log messages
* loop directly on nonce range other than on map
* split func PrepareForKeysign into two separate method, one for reading one for writing
* refactor: omit unnecessary reassignment (#4447)
Signed-off-by: liuyueyangxmu <liuyueyangxmu@outlook.com>
* test: update tss migration test migrate btc fund in two chunks (#4463)
* migrate btc funds twice
* update spacing to fix lint
* add comment to explain reason for chunking BTC funds migration
* fix: accept uppercase receiver address in Bitcoin withdrawal (#4471)
* allow uppercase receiver address in Bitcoin withdrawal
* add changelog entry
* test: add separate versions for zetaclient ,zetacore and zetae2e binaries when used in e2e tests (#4476)
* create an optional alternate version for zetaclient in upgrade tests
* create an optional alternate version for zetaclient in upgrade tests
* Update changelog.md
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
* use old version for zetacored version directly
* ignore overwrite errors for config file
* split versioning for zetacored ,zetaclient and zetae2e
* simplify second run check
* update changelog
* update changelog
---------
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
* test: prevent zetaclient from running if minimum version check failed (#4474)
* add e2e test for zetaclient minimum version
* block zetaclient to run if minimum version is not set
* revert the check on empty minimum version
* add changelog entry
* continue monitoring if operational flags RPC query failed
* docs: update protocol contracts EVM link in readme (#4458)
* feat: add MsgRemoveObserver (#4479)
* add tss migration for remove obdservers
* update tests and add changelog
* use uint for len of observer set
* remove stree for add observers
* set last update height for observer set
* add check for len of observer set in e2e test
* make TSS_MIGRATION_FLAG optional
* feat: add an option to create zetaclient dry node for tesntet/mainnet (#4453)
* add shell script to demonstrate zetaclient-dry
* verify zetacore and zetaclient binaries
* docker testnet node
* refactor zetaclient dry to use python entrypoint and make it configurable
* remove config
* add rpc nodes
* add changelog
* add changelog
* update comments
* update puthon scripts to use toml files directly
* simplify logic in scripts
* simplify logic in scripts
* copy scripts into docker container directly
* add profile to testnet and mainnet nodes
* add separate versioning for dry containers
* chore: fix some spelling issues in comments (#4480)
Signed-off-by: xiaolinny <xiaolincode@outlook.com>
Co-authored-by: morde08 <peter@zetachain.com>
* test: add sui to tss migration tests (#4488)
* add tss migration for sui
* add changelog
* debug changes
* update message context
* update comments
* remove unused functions
* feat: change params for 2s block time (#4484)
* change params for 2s block time
* changelog
* remove todo
* change default params
* test fixes
* fix migration test
* fix distributions test
* feat: Add action to build & push zetanode image internally (#4482)
* feat: Add action to build zetanode and deploy in dry-run mode
* Add pr trigger
* fix: remove snapshotter
* add pr trigger
* try new flow
* test docker availability
* fix variables and refactor
* add test to tag
* update action
* trigger
* push latest only if no version
* revert to version
* fix: remove PR trigger
* fix: concurrency and fallback
* fix: Add timeout and cleanup
* feat: enable ALT in solana inbounds (#4493)
* enable ALT in solana inbounds
* lint
* changelog
* PR comments
* fmt
* run ci
* fix: bring back the support for tracerConfig object in zevm debug API (#4490)
* bring back the support for tracerConfig object in evm debug API
* add changelog entry
* add unit test for traceConfig object
* fix: port sui outbound schedule interval (#4509)
* fix: sui outbound schedule interval (#4506)
* changelog
* fix: false mempool is congested warning (#4511)
* fix false mempool is congested warning
* changelog
* PR comment
* PR comment
* fix(backport): reindex txlogs if duplicate indexes are present (#4498)
* update needs reindex function to check for log index across all groups
* add changelog
* use uint for index
* test: add e2e test to replace observer (#4503)
* add e2e test to replace observer
* update changelog
* add replace observer label check
* fix: Add solana image dependency
* Update cmd/zetae2e/local/replace_observer.go
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
* add a comments to improve readibilty
---------
Co-authored-by: Hazim <hazim_malik@hotmail.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
* test: add-ton-tss-migration (#4491)
* add tss migration for sui
* add changelog
* debug changes
* update message context
* update comments
* remove unused functions
* add ton to tss migration
* update comments
* update backoff
* update wait blocks for sui
* chore: fix function name in comment for batchLogger (#4504)
Signed-off-by: boqishan <boqishan@126.com>
Co-authored-by: Tanmay <tanmay@zetachain.com>
* feat: add migration script to add an authorization for MsgRemoveObserver (#4492)
* add migration script
* updae changelog
* feat: add a tool to list tss balances across all supported chains (#4507)
* add tss balance check
* update to using supported chains list from network
* update comments
* remove sample config file from repository
* update identifier chainRpc to chainRPC
* feat: move gas price multiplier to chain params (#4485)
* move gas price multiplier to chain params
* add changelog entry
* add breaking change description in changelog
* fix nil chainParams check in migration script; fix typo and make gas multiplier validation less strict; update changelog
* describe the impact of newly added field gas multiplier; fix typo in zetatool inbound
* fix unit test
* chore: merge main into develop (#4512)
* fix: ratelimiting race condition vuln (#4072)
* fix: ratelimiting race condition vuln
* fix: ratelimiting race condition vuln
- Fix race condition in RateLimiter.Release() function
- Replace non-atomic check-then-act with atomic decrement and bounds checking
- Add comprehensive test suite to verify the fix
- Update changelog with PR #4072
* fix: correct atomic implementation to prevent underflow
- Replace flawed Add(-1) approach with proper CompareAndSwap
- Fix underflow detection issue where uint32 wrap-around was missed
- Add TestRateLimiterUnderflowProtection to verify the fix
- Ensure Release() never causes negative counters or semaphore over-release
* refactor: simplify rate limiter Release() implementation
- Remove unnecessary infinite loop in CAS operation
- Single CAS attempt is sufficient for race condition protection
- Maintains thread-safety while being more efficient
- All tests still pass with simplified implementation
* fix: correct order of operations in rate limiter Release()
- Fix race condition by decrementing counter before releasing semaphore
- Ensure pending counter accurately reflects semaphore state
- Simplify implementation by using correct operation order
- All tests pass with cleaner, more logical approach
* test: add tests that reproduce the original race condition vulnerability
- Add BuggyRateLimiter that implements the original vulnerable code
- Add TestBuggyRateLimiterRaceCondition to demonstrate the race condition
- Add TestBuggyRateLimiterStressTest to stress test the vulnerability
- Add TestVulnerabilityDemonstration to show before/after comparison
- Add TestBuggyRateLimiterExcessiveReleases to show excessive release issues
- These tests demonstrate the theoretical vulnerability even if timing makes it hard to reproduce consistently
* fix: address race condition and underflow issues in RateLimiter
- Fix race condition in Release() by reordering operations (decrement pending first, then release semaphore)
- Fix Pending() function to handle negative atomic.Int32 values correctly
- Add comprehensive tests to verify fixes
- Remove buggy code from tests as requested by reviewers
- Document original vulnerability in test comments
The original race condition allowed multiple goroutines to release more permits than acquired.
The Pending() function could return incorrect values due to negative atomic.Int32 conversion.
Fixes: #4072
* refactor: rename test and update changelog to reflect actual improvements
- Rename TestVulnerabilityDemonstration to TestRateLimiterRobustness
- Update test description to reflect code quality improvements rather than vulnerability fixes
- Update changelog entry to match actual changes
- Tests still pass, confirming the improvements are working correctly
The reviewer correctly pointed out that if tests pass on develop without fixes,
then we're improving robustness rather than fixing vulnerabilities.
* refactor: remove support for v1 revert address for BTC (#4070)
* remove support for v1 revert address for BTC
* add changelog
---------
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
* feat: add support for withdraw using v2 connector contract (#4064)
* update go mod
* add a new message for migrating funds
* add migrate funds to e2e
* rebase from develop
* add v2 e2e test to check flow
* add zeta gateway deposit to zetaclient
* add github workflow
* update comments
* fix code formating
* fix code formating
* fix code formating
* fix unit tests
* fix unit tests
* revert to old command to start e2e test
* remove message for migration and refactor to using contract directly
* add changelog
* generate files after removing new message
* update generated files
* update generated files
* update go mod
* update deposit
* add unit tests
* add unit tests
* generate files
* generate files
* undo changes based on develop
* update deposit and revert smart contract call
* rename zeta deposit test file
* rename zeta deposit test file
* add abort and revert tests
* add TestZetaDepositAndCallNoMessage
* add TestZetaDepositAndCallNoMessage
* remove payable from TestAbort contract
* rename to LegacyZETADepositAndCallContract
* improve unit test coverage
* fix unit tests
* add some delay in TestZetacore_SubscribeNewBlocks
* update comment for handling zeta token zrc20
* add e2e test
* add e2e test for withdraw
* refactor ProcessZEVMInboundV2
* add core registry to setup
* refactor e2e test helper functions
* add unit test for zeta withdraw
* add unit test for withdraw and call
* resolve comments 1
* add unit test for ProcessRevert
* add unit test for ProcessRevert
* add unit test for ProcessRevert
* improve abort tests
* improve abort tests
* resolve comments
* resolve comments 2
* update upgrade height to 280 to allow the first test to run the entire cycle
* wrap zeta mints in tmp context
* wrap zeta mint in temp context
* rebase
* add changelog
* add changelog
* adjust comments
* Update cmd/zetae2e/config/contracts.go
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
* fix gas pool zeta calcualation
* add unit test for executeWithMintedZeta
* fix comments 1
* add unit tests
* update test dapp to use zeta token for consuming gas
* add core registry to zeta e2e post upgrade handler
* revert legacy test
* update changes based on comments 1
---------
Co-authored-by: Charlie Chen <34498985+ws4charlie@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
* fix: print error message in detail if unable to decode Bitcoin memo (#4090)
* print error message detail when memo decoding failed
* add changelog entry
* keep invalid memo log on Info level
---------
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
* test(e2e): update admin e2e tests to use v2 connector (#4071)
* update go mod
* add a new message for migrating funds
* add migrate funds to e2e
* rebase from develop
* add v2 e2e test to check flow
* add zeta gateway deposit to zetaclient
* add github workflow
* update comments
* fix code formating
* fix code formating
* fix code formating
* fix unit tests
* fix unit tests
* revert to old command to start e2e test
* remove message for migration and refactor to using contract directly
* add changelog
* generate files after removing new message
* update generated files
* update generated files
* update go mod
* update deposit
* add unit tests
* add unit tests
* generate files
* generate files
* undo changes based on develop
* update deposit and revert smart contract call
* rename zeta deposit test file
* rename zeta deposit test file
* add abort and revert tests
* add TestZetaDepositAndCallNoMessage
* add TestZetaDepositAndCallNoMessage
* remove payable from TestAbort contract
* rename to LegacyZETADepositAndCallContract
* improve unit test coverage
* fix unit tests
* add some delay in TestZetacore_SubscribeNewBlocks
* update comment for handling zeta token zrc20
* add e2e test
* add e2e test for withdraw
* refactor ProcessZEVMInboundV2
* add core registry to setup
* refactor e2e test helper functions
* add unit test for zeta withdraw
* add unit test for withdraw and call
* resolve comments 1
* add unit test for ProcessRevert
* add unit test for ProcessRevert
* add unit test for ProcessRevert
* improve abort tests
* improve abort tests
* resolve comments
* resolve comments 2
* update upgrade height to 280 to allow the first test to run the entire cycle
* wrap zeta mints in tmp context
* wrap zeta mint in temp context
* rebase
* add changelog
* add changelog
* adjust comments
* Update cmd/zetae2e/config/contracts.go
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
* fix gas pool zeta calcualation
* add unit test for executeWithMintedZeta
* fix comments 1
* add unit tests
* update admin
* revert unncessary changes
* disable account balance verification for admin tests
* improve naming for deposit functions
* add changelog
* update comments
* update test legacy test zeta to use EVMAddress
* remove skipping admin in upgrade setup
---------
Co-authored-by: Charlie Chen <34498985+ws4charlie@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
* test: fix eth deposit test to check balance after deposit (#4118)
* check balance after eth deposit test
* fix typo
* fix import
* test: fix flaky Solana depositAndCall tests (#4113)
* fix flaky solana depositAndCall tests
* add changelog entry
* add wait logic inside AssertTestDAppEVMCalled
* chore: bump cosmos evm to support querying legacy proposals of type MsgUpdateParams (#4094)
* update zeta evm
* update commit
* fix: use evm chain id from eth config in rpc backend (#4096)
* fix: cancel solana WaC if tx size is too large (#4098)
* cancel solana WaC if tx size is too large
* align the comments with the code
* fix: nil reference in trace block (#4093)
* update to commit be548f7691876e656ec61aa46e31ed337be92f4e , on branch release/v34
---------
Co-authored-by: skosito <skostic9242@gmail.com>
Co-authored-by: Charlie Chen <34498985+ws4charlie@users.noreply.github.com>
Co-authored-by: morde08 <peter@zetachain.com>
* fix: error when deploying contracts on testnet (#4112)
* dont return err if tx is not found in get tx receipt
* fix tests
* changelog
* feat: support hostname in addition to public IP for zetaclient to connect to zetacore (#4068)
* save initial work to remote
* add unit test and live test for zetacore hostname support
* add changelog entry; fix gosec and clean unused code
* fix CI upgrade test
---------
Co-authored-by: Tanmay <tanmay@zetachain.com>
* fix: dbg trace block by number gas limit legacy (#4121)
* fix dbg trace by block
* PR comments
* changelog
* fix(cherry-pick): cancel solana WaC if tx size is too large (#4111)
* cancel solana WaC if tx size is too large
* add changelog entry
* chore: remove tx suffix in vote inbound and outbound message names (#4110)
* fix(`crosschain`): remove confirmation mode from outbound and inbound digest (#4116)
* inbound
* .
* changelog
* refactor(zetacore): overwrite consensus config values for all timeout deltas on startup. (#4097)
* update 1
* add start-skip-consensus-overwrite-test
* generate files
* update tests
* add unit tests
* add unit tests for GenesisChainID
* add unit tests for GenesisChainID
* rename genesisChainID
* fix typo
* remove testnet from overwrite check
* refactor: replace []byte(fmt.Sprintf) with fmt.Appendf (#4131)
Signed-off-by: yinwenyu6 <yinwenyu6@outlook.com>
* feat: Sui message context ID as dynamic field (#4087)
* re-enable sui authenticated call
* integrate message context ID as dynamic field
* add changelog entry
* make issueMessageContext function self-contained
* fix unit test
* remove --skip-dependency-verification in sui gateway upgrade test
* cancel withdrawAndCall on invalid payload
* adopt new increase_nonce signature to adopt gas refund logic when cancelling a CCTX
* apply stringent check on Sui transaction's checkpoint
* apply status check on Sui inbound
* fix CI upgrade test
* fix unit test
* chore: fix some function names in comment (#4129)
Signed-off-by: pxwanglu <pxwanglu@icloud.com>
* chore: fix some observer message names (#4141)
* test: fix flaky Solana SPL deposit balance check (#4142)
* fix solana e2e SPL balance check by waiting maximum 30 seconds
* add changelog entry
* refactor: remove intx and outtx deprecated queries (#4150)
* refactor: remove intx and outtx deprecated queries
* fixes in e2e
* chore: remove redundant word in comment (#4149)
Signed-off-by: wmypku <wmypku@outlook.com>
* test(`e2e`): improve logs for CCTX status assertion (#4147)
* improve require status logs
* update usage in tests
* lint
* cursor comment
* chore: fix some typos in comment (#4146)
Signed-off-by: tzchenxixi <tzchenxixi@icloud.com>
* chore: set v35 as upgrade test reference and various clean up (#4115)
* add back precompiles
* add abci field to proposal
* test
* enable back
* test no creating proposasl
* disable zeta-ante
* cleanup v33 upgrade helper
* add v35 as reference
* remove gas stability pool temporary
* update to v36 and disable fast confirmation test
* bitcoin fast confirmation
* increase ersion for zeta
* remove erc20 init handler
* disable zevm to evm revert for older version
* disable zevm to evm revert abort for older version
* increase upgrade height
* feat: make the gas limit used for gateway calls on ZEVM a configurable parameter (#4153)
* add GatewayGasLimit to state
* refactor function name from MustGetGatewayGasLimit to GetGatewayGasLimitSafe
* update unit tests
* update unit tests
* update proto files
* replace big int with uint64
* changelog
* add check of older value
* add v4 migration back for authority module
* update setup handler to remove setting erc20 module
* test changes
* revert to using v32 as base branch for upgrades
---------
Co-authored-by: lumtis <lucas.bertrand.22@gmail.com>
* test(`e2e`): add a gas limit option for ZEVM to EVM call tests (#4145)
* add gas limit option
* use option for tests
* increase further upgrade height
* test: use pre-deployed example dapp V2 contract in e2e tests (#4158)
* do not deploy example contract in e2e tests, use pre-deployed example dapp V2 instead
* add changelog entry
* clean up debugging log
* remove commented code
* add back extra zrc20 SPL balance check
* chore(`e2e`): cleanup unused contracts (#4161)
* remove contextapp
* remove distribute
* test: fix flaky depositAndCall test that failed on sender assertion (#4165)
* fix flaky depositAndCall caused by sender assertion
* add changelog entry
* chore(deps): bump github.com/hashicorp/go-getter from 1.7.8 to 1.7.9 (#4148)
Bumps [github.com/hashicorp/go-getter](https://github.com/hashicorp/go-getter) from 1.7.8 to 1.7.9.
- [Release notes](https://github.com/hashicorp/go-getter/releases)
- [Changelog](https://github.com/hashicorp/go-getter/blob/main/.goreleaser.yml)
- [Commits](https://github.com/hashicorp/go-getter/compare/v1.7.8...v1.7.9)
---
updated-dependencies:
- dependency-name: github.com/hashicorp/go-getter
dependency-version: 1.7.9
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* chore(deps): bump github.com/ulikunitz/xz from 0.5.11 to 0.5.14 (#4172)
Bumps [github.com/ulikunitz/xz](https://github.com/ulikunitz/xz) from 0.5.11 to 0.5.14.
- [Commits](https://github.com/ulikunitz/xz/compare/v0.5.11...v0.5.14)
---
updated-dependencies:
- dependency-name: github.com/ulikunitz/xz
dependency-version: 0.5.14
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* chore(deps): bump github.com/go-viper/mapstructure/v2 from 2.2.1 to 2.4.0 (#4173)
chore(deps): bump github.com/go-viper/mapstructure/v2
Bumps [github.com/go-viper/mapstructure/v2](https://github.com/go-viper/mapstructure) from 2.2.1 to 2.4.0.
- [Release notes](https://github.com/go-viper/mapstructure/releases)
- [Changelog](https://github.com/go-viper/mapstructure/blob/main/CHANGELOG.md)
- [Commits](https://github.com/go-viper/mapstructure/compare/v2.2.1...v2.4.0)
---
updated-dependencies:
- dependency-name: github.com/go-viper/mapstructure/v2
dependency-version: 2.4.0
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* refactor: standardize zetaclient logging (#4144)
* chore: remove unused DynamicTicker from zetaclient/types
* refactor: remove Msgf and refactor zerolog uses
* Replace Msgf for Msg
* Use '_' instead of '.'
* Start logs with lowercase instead of uppercase characters
* Use the constants in the logs module
* Use With().Logger() instead of log fields when possible
* fix: improve zetatool (#4175)
* scan gateway events by default for all inbound hashes
* scan gateway events by default for all inbound hashes
* test(`e2e`): add a E2E test to test depositAndCall with high gas consumption (#4177)
* set gas limit to 4m in localnet
* add high usage test
* changelog
* Update changelog.md
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
* Update e2e/e2etests/e2etests.go
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
---------
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
* test(`e2e`): add all chains by default in `start-localnet` (#4163)
* chore: add Solana to start-localnet to allow to run local tests
* add sui and ton
* Update cmd/zetae2e/local/local.go
Co-authored-by: Tanmay <tanmay@zetachain.com>
---------
Co-authored-by: Tanmay <tanmay@zetachain.com>
* chore: remove redundant words (#4179)
Signed-off-by: keeghcet <keeghcet@outlook.com>
* refactor: omit unnecessary reassignment (#4184)
Signed-off-by: fengyuchuanshen <fengyuchuanshen@outlook.com>
* fix: force rescan if inbound vote monitoring fails (#4183)
* add monitoringErr channel
* update to InboundBlockHeight - 1 , for reseting the block
* fix unit tests
* implement error interface
* rename to ErrTxMonitor
* add forceResetLastScanned flag
* add forceResetLastScanned flag
* add mutex to force scan
* add changelog
* add changelog
* update name to wasForceReset
* wrap UpdateForceResetLastScanned in mutex
* add a bound check to InboundBlockHeight to be safe
* Update zetaclient/chains/base/confirmation.go
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
* Update zetaclient/chains/base/observer.go
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
* force update for in memory value if forceResetLastScanned is true
* add a lock on reading block height
* update error message
* update changelog
* wait till end of scan cycle to toggle the forceUpdateFlag
---------
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
* fix: remove duplicate solana post-gas-price goroutine (#4194)
* feat: observe inbound from previous gateway package after upgrade (#4138)
* observe inbound from old gateway package optionally
* add changelog entry
* add sui inbound cursor migration; add post-upgrade deposit tests
* improve comments, logs and naming; fix post-upgrade withdraw failure
* protect anyStringMap
* add support for <withdrawcap-id> to Sui gateway address
* fix CI upgrade test failure
* use name previousPackageID and keep name PairID; rename AnyString and cursor migration function; improve test, comments, etc.
* replaced assert by require in sui unit test
* add support for original packageID in Sui gateway address
* avoid wrapping nil error
* use previous package ID in post-upgrade Sui deposit test
* add support for previous package deprecation and fix upgrade test
* fix unit test
* add a note to clarify the PackageID argument used for event query
* add documents to explain Sui gateway address format in the chain params
* refactor: remove unused loggers and log fields (#4180)
* chore: remove unused Headers logger
* refactor: remove (mostly) unused GasPrice logger
* refactor: replace logs.FieldMethod with With().Caller() and standardize logs.FieldModule values
* refactor: remove (mostly) unused log fields FieldTracker and FieldConfirmationMode
* refactor: replace missed log instances of '.' for '_'
* fix: unpack bitcoin revert message without considering 'CallOnRevert' flag (#4169)
* enable bitcoin revertMessage and ignore CallOnRevert flag
* add changelog entry
* update standard memo doc; improve abort address validation
* skip incompatible e2e test to allow CI upgrade test to pass
* fix: add timeout to monitoring routine (#4196)
* add a timeout for vote monitoring thread
* add a timeout for vote monitoring thread
* add comments
* remove typo for cancel call
* fix unit tests
* Update zetaclient/zetacore/client_vote.go
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
* Update zetaclient/chains/base/observer.go
Co-authored-by: Charlie Chen <34498985+ws4charlie@users.noreply.github.com>
---------
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
Co-authored-by: Charlie Chen <34498985+ws4charlie@users.noreply.github.com>
* refactor: use maps.Copy for cleaner map handling (#4198)
Signed-off-by: joemicky <joemickychang@outlook.com>
* chore: fix some comments (#4208)
Signed-off-by: zhoujiaweii <zjwustc@outlook.com>
* fix: update evm version for missing tx types (#4216)
* refactor: replace HasPrefix+TrimPrefix with CutPrefix (#4215)
Signed-off-by: quantpoet <quantway@outlook.com>
* refactor: remove `LastBlockHeight` state variable (#4200)
* proto
* remove other references
* changelog
* refactor: add documentation for ZetaClient logging fields (#4174)
* refactor: use coin.CoinType for compliance logging
* refactor: add documentation for zetaclient logging fields
* fix: remove ZetaChain chain ID from GasStabilityPoolBalances query (#4217)
* fix query
* add test
* changelog
* add commment
* lint
* remove gas token address
* change error type
* refactor: remove index field in ballot (#4205)
* refactor: remove index field in ballot
* changelog
* fix unit tests
* refactor: remove `MsgUpdateERC20CustodyPauseStatus` and `MsgMigrateERC20CustodyFunds` (#4199)
* make message legacy
* remove other reference
* changelog
* refactor: rename whitelistERC20 into whitelistAsset (#4203)
* refactor: rename whitelistERC20 into whitelistAsset
* e2e test
* e2e test
* fix event
* simulation
* changelogs
* update auth list
* add migration script
* apply comment
* feat: provide error information in CCTX struct when Bitcoin deposit fail (#4211)
* add error message to CCTX struct when Bitcoin deposit failed
* add changelog entry
* fix unit test; improve function naming
* add unit test for inbound vote digest
* exclude inbound observation error message from digest
* fix: re-check for finalized ballot when executing inbound vote to create cctx (#4197)
* check for finalized block after ballot is finalized
* fix unit tests and add changelog
* adjust comments
* Apply suggestion from @lumtis
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
* Apply suggestion from @lumtis
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
* refactor check finalized ballot check to be done before adding the finalizing vote to the ballot
* adjust comments
* adjust comments
* fix comments 2
---------
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
* fix: set zeta ante to true in upgrade tests (#4225)
* add zeta ante
* add to upgrade test regular
* add to upgrade test regular
* update out of gas test
* update out of gas test
* fix tss migration test
* fix lint issues 1
* update v2 zeta version
* chore: resync changelogs with v36 changes (#4223)
* fix: skip writing config file to the filesystem (#4210)
* comment out writing files to the state
* ad changelog
* remove commented code
* return error from fetching FlagSkipConfigOverwrite
* refactor(`observer`): remove deprecated code (#4192)
* update proto
* update code
* changelogs
* fix changelog
* fix gas limit issue in upgrade test
* use ante-zetae2e for admin upgrade tests
* test fix
* refactor: prepare the client interfaces used by the observer-signers for dry-mode (#4213)
refactor: prepare the client interfaces of the observer-signers for dry-mode
* feat: enable NoAssetCall from Bitcoin (#4218)
* enable NoAssetCall from Bitcoin
* add changelog entry
* improve comment and log print
* revert bitcoin NoAssetCall that carries large excessive funds
* adjust btc inbound parsing order; fix test name
* improve function and variable names
* feat: multiple evm calls in single tx (#4157)
* bump protocol contracts
* use newer geth version with cancun support
* e2e test with 2 deposits in same tx
* e2e tests
* inbound trackers for multiple events
* changelog
* generate
* fix e2e tests
* inbound trackers e2e test
* bump protocol contracts
* PR comments
* PR comment
* PR comments
* PR comment
* lower upgrade height in upgrade tests
* try diff upgrade height
* upgrade additional fee in upgrade v36 handler
* chore: fix function name in comment (#4238)
Signed-off-by: russcoss <russcoss@outlook.com>
* revert: add timeout to monitoring routine" (#4244)
Revert "fix: add timeout to monitoring routine (#4196)"
This reverts commit 65f227bbfa585adb408f31d15a5bcf71243d1e52.
* fix(e2e): check test contracts deployment (#4251)
* fix(e2e): check test contracts deployment
* add other contracts
* changelog
* fix chain to wait tx from
* revert: force rescan if inbound vote monitoring fails (#4250)
* feat: refund a portion of remaining unused tokens to user (#3734)
* add new field to cctx structure to track user gas burned
* add unit tests
* add doc
* add unit test for migration
* add check for pre upgrade cctxs
* add older logic for handling cctxs created before upgrade
* remove LegacyChainParams
* add unit test for refund gas fee
* remove old migration
* add temp note for PR review
* fix typo
* fix typo
* generate files
* add missing test case
* add missing test case
* refactor based on comments
* update EtherWithdrawRestricted test
* update EtherWithdrawRest…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
zerolog.Msgfforzerolog.Msgin order to migrate to full strutured logging..) for underlines (_) when logging.zetaclient/logs.zerolog'sWithfunction (in place oflog.Fields(...)).DynamicTickerfrom zetaclient/types.Closes #1902.
logs.FieldMethod. For example,logger.Msg("parse: successful")instead oflogger.Str(logs.FieldMethod, "parse").Msg("successful").With().Logger().How Has This Been Tested?
Summary by CodeRabbit
Refactor
Documentation