fix(backport): force rescan if inbound vote monitoring fails using a context that can timeout

[kingpinXD]

Description

This pr backports changes from
#4183
#4196

How Has This Been Tested?

• Tested CCTX in localnet
• Tested in development environment
• Go unit tests
• Go integration tests
• Tested via GitHub Actions

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)

• develop

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

✨ Finishing touches

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch backport-update-lastScannedBlock

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cursor]

Comment @cursor review or bugbot run to trigger another review on this PR

[cursor]

Bug: Context Timer Leak in CopyWithTimeout

The cancel function returned by zctx.CopyWithTimeout is discarded. This causes a resource leak, as the context and its associated timer remain active for the full 5-minute timeout, even if the monitoring operation completes sooner.

 

[kingpinXD]

That is the expected behavior, calling the context here would terminated the goroutines using the context which is not desirable

[codecov]

Codecov Report

❌ Patch coverage is 46.49123% with 61 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.85%. Comparing base (d925dd6) to head (a226586).
⚠️ Report is 1 commits behind head on release/v36.

Files with missing lines	Patch %	Lines
zetaclient/chains/base/observer.go	55.00%	33 Missing and 3 partials ⚠️
zetaclient/context/context.go	0.00%	7 Missing ⚠️
zetaclient/zetacore/client_vote.go	30.00%	7 Missing ⚠️
pkg/errors/monitor_error.go	0.00%	6 Missing ⚠️
zetaclient/zetacore/client_monitor.go	42.85%	4 Missing ⚠️
zetaclient/chains/solana/observer/inbound.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@               Coverage Diff               @@
##           release/v36    #4202      +/-   ##
===============================================
- Coverage        65.93%   65.85%   -0.09%     
===============================================
  Files              455      456       +1     
  Lines            33449    33532      +83     
===============================================
+ Hits             22055    22081      +26     
- Misses           10435    10489      +54     
- Partials           959      962       +3     

Files with missing lines	Coverage Δ
zetaclient/chains/base/confirmation.go	100.00% <ø> (ø)
zetaclient/chains/bitcoin/observer/db.go	93.47% <100.00%> (ø)
zetaclient/chains/evm/observer/observer.go	70.13% <100.00%> (ø)
zetaclient/chains/solana/observer/inbound.go	35.61% <0.00%> (ø)
zetaclient/zetacore/client_monitor.go	44.00% <42.85%> (+0.19%)	⬆️
pkg/errors/monitor_error.go	0.00% <0.00%> (ø)
zetaclient/context/context.go	52.38% <0.00%> (-26.20%)	⬇️
zetaclient/zetacore/client_vote.go	51.93% <30.00%> (-2.10%)	⬇️
zetaclient/chains/base/observer.go	73.98% <55.00%> (-8.19%)	⬇️

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[lumtis]

Tested with 1d04397 and it worked well

[lumtis]

I will merge since remaining issues are not a concern, we can apply these on the develop branch