security: replace eval() with json_encode/decode in ezcCacheStorageFileEvalArray#5
Open
se7enxweb wants to merge 1 commit intozetacomponents:masterfrom
Open
security: replace eval() with json_encode/decode in ezcCacheStorageFileEvalArray#5se7enxweb wants to merge 1 commit intozetacomponents:masterfrom
se7enxweb wants to merge 1 commit intozetacomponents:masterfrom
Conversation
…ageFileEvalArray
eval() on file contents is a direct RCE vector if an attacker can write
to the cache directory. JSON carries no code execution risk.
fetchData(): use json_decode(); throw ezcCacheInvalidDataException on
parse failure instead of silently returning null.
prepareData(): use json_encode() with JSON_UNESCAPED_UNICODE; throw on
encode failure.
BC note: existing cache files written by the old eval()-based format
("return <php_value>;\n?>\n") are not compatible with JSON decoding.
Clear the cache directory when deploying this change.
Reported-by: CJW Network security audit 2026-03-01
Security-fixes: RCE via eval() (CWE-94)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported-by: CJW Network security audit 2026-03-01
Problem
ezcCacheStorageFileEvalArray::fetchData()usedeval(file_get_contents($filename)). If an attacker can write to the cache directory (e.g. via a separate path traversal or file upload vulnerability), they can achieve Remote Code Execution by placing malicious PHP in a cache file.Changes
src/storage/file/eval_array.phpfetchData():eval()→json_decode(). ThrowsezcCacheInvalidDataExceptionon parse failure.prepareData():var_export()+PHP suffix →json_encode()withJSON_UNESCAPED_UNICODE. Throws on encode failure.BC note
Existing cache files written in the old
return <php>;?>format are not compatible. Clear the cache directory when deploying.Security fixes