Conversation
When -gt flag is specified, we now replace the original mesh tangents with newly generated ones, using the new meshoptimizer tangent algorithm. While it would be possible to only generate tangent streams for meshes that don't already have one, a lot of existing glTF assets have tangents that are broken or poor quality, so for now we always overwrite tangents, and also use the higher quality default algorithm. In the future we could add extra options to customize this. Morph tangents are rare and require custom code so that we only split the mesh based on original normal stream; for now we simply drop them.
We need -kv to force tangent generation for meshes that don't have a normal map.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
-gtflag is specified, we now replace the original mesh tangentswith newly generated ones, using the new meshoptimizer tangent algorithm.
While it would be possible to only generate tangent streams for meshes
that don't already have one, a lot of existing glTF assets have tangents
that are broken or poor quality, so for now we always overwrite tangents,
and also use the higher quality default algorithm.
In the future we could add extra options to customize this.
Morph tangents are rare and require custom code so that we only split
the mesh based on original normal stream; for now we simply drop them.