ci: fix docs not deployed in build-firmware workflow#35
Merged
Conversation
build-firmware.yml deploys to GitHub Pages but was missing the docs/ copy step. When it ran after deploy-pages.yml, it overwrote the site without docs, causing 404 on the docs viewer. Signed-off-by: Chao Liu <chao.liu.zevorn@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The docs viewer shows "Document not found" because
build-firmware.yml'sdeploy job deploys to GitHub Pages without copying docs/. When it runs
after
deploy-pages.yml, it overwrites the site and docs disappear.Fix: add
cp -r docs/ website/docs/tobuild-firmware.ymldeploy step.Root cause
Two workflows deploy to the same GitHub Pages environment:
deploy-pages.yml: copies images + docs ✓build-firmware.yml: copies images only ✗ ← this one overwrites without docsSigned-off-by: Chao Liu chao.liu.zevorn@gmail.com