fix: serial input bar height stretching with flash panel#57
Merged
Conversation
The grid layout uses align-items:stretch to match panel heights. The serial-output had fixed height:360px which didn't fill the available space, causing flex to distribute the extra height to the input bar. Fix: serial-output uses min-height:360px + flex:1 to fill remaining space. Titlebar and input bar get flex-shrink:0 to stay fixed height. Signed-off-by: Chao Liu <chao.liu.zevorn@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The grid layout (
align-items: stretch) makes both panels equal height. The serial output area had a fixedheight: 360pxthat didn't expand, causing flex to push extra space into the input bar, making it unnaturally tall.Fix
serial-output:height: 360px→min-height: 360px; flex: 1(fills available space)serial-titlebar: addflex-shrink: 0(stays fixed)serial-input-bar: addflex-shrink: 0(stays fixed)min-height: 0override (no minimum when fullscreen)Test plan