fix: serial panel height grows with output instead of scrolling#59
Merged
fix: serial panel height grows with output instead of scrolling#59
Conversation
serial-output used min-height:360px + flex:1 which allowed the flex container to expand when content exceeded the minimum, pushing the page layout taller. Fix: use height:0 + flex:1 so the output area is sized entirely by flex allocation (from grid stretch), never by content. overflow-y:auto ensures scrolling. serial-panel gets min-height:480px as a floor. Signed-off-by: Chao Liu <chao.liu.zevorn@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Serial output area used
min-height: 360px; flex: 1— when content exceeded the minimum, the flex container expanded, pushing the entire page layout taller instead of scrolling.Fix
serial-output:min-height: 360px→height: 0(flex:1 allocates all height from grid, content scrolls via overflow-y:auto)serial-panel: addmin-height: 480pxas a floor when flash panel is shorterTest plan