fix: serial panel still grows — use fixed height instead of min-height#62
Merged
fix: serial panel still grows — use fixed height instead of min-height#62
Conversation
min-height only sets a floor — the panel still grows when content exceeds 480px because there is no upper bound. Change to a fixed height so serial-output scrolls within the container. Signed-off-by: Chao Liu <chao.liu.zevorn@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
`min-height: 480px` only sets a floor. The panel still grows unbounded when serial output content exceeds it.
Fix: `min-height` → `height: 480px`. Combined with `overflow: hidden` on the panel and `height: 0; flex: 1; overflow-y: auto` on serial-output, content scrolls within the fixed container.