fix: serial panel aligns with flash panel without growing#63
Merged
Conversation
The serial panel must equal flash panel height (grid stretch) while preventing serial output from growing the container. Solution: - flash-layout: align-items:stretch (both panels equal height) - serial-panel: min-height:0 overrides grid default min-height:auto, which is the root cause of content pushing the grid row taller - serial-output: height:0 + flex:1 fills remaining space, scrolls - serial-titlebar / serial-input-bar: flex-shrink:0 stays fixed Signed-off-by: Chao Liu <chao.liu.zevorn@gmail.com>
zevorn
force-pushed
the
fix/serial-panel-align-v2
branch
from
db277b5 to
4d99ef1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Serial panel either didn't match flash panel height, or grew unbounded with content.
Root Cause
Grid items have implicit
min-height: autowhich prevents them from being smaller than their content. When serial output grows, it pushes the grid row taller.Fix
align-items: stretch— both panels equal height (determined by flash panel)serial-panel:min-height: 0— overrides the implicitmin-height: auto, so the panel respects the grid row height instead of being pushed by contentserial-output:height: 0; flex: 1; overflow-y: auto— fills remaining space, scrollsserial-titlebar+serial-input-bar:flex-shrink: 0— fixed height