fix: lock serial panel height with JS after layout#64
Merged
Conversation
CSS min-height:0 alone is not sufficient to prevent grid row growth from serial output content in all browsers. Fix: after page load, read the computed height of serial-panel (which equals flash-panel via grid stretch) and set it as an explicit inline style. This creates an absolute height constraint that overflow-y:auto on serial-output can work against. The expand/collapse toggle clears and re-locks the height. Signed-off-by: Chao Liu <chao.liu.zevorn@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CSS-only approaches (
min-height: 0,height: 0; flex: 1) don't reliably prevent grid row growth from serial content in all browsers.Fix: on
window.load, readserial-panel.offsetHeight(computed from grid stretch = flash-panel height) and set it as inlinestyle.height. This gives an absolute constraint foroverflow-y: autoto work against. Expand/collapse clears and re-locks.