platform: add CONFIG_RTCLAW_TELEGRAM_ENABLE to all sdkconfig.defaults#72
Merged
platform: add CONFIG_RTCLAW_TELEGRAM_ENABLE to all sdkconfig.defaults#72
Conversation
CONFIG_RTCLAW_TELEGRAM_ENABLE was defined in both ESP32-C3 and ESP32-S3 Kconfig files but never declared in any sdkconfig.defaults profile. This caused the Telegram Bot integration to silently fall through to the Kconfig default (disabled), with no explicit opt-in/opt-out visible in the board configuration files. Add explicit CONFIG_RTCLAW_TELEGRAM_ENABLE entries to all 9 sdkconfig.defaults files across both ESP32 platforms: - QEMU base, feishu, and demo profiles (C3 + S3) - Hardware boards: devkit, xiaozhi-xmini (C3), default (S3) Also add missing CONFIG_RTCLAW_FEISHU_ENABLE entries to hardware board defaults (devkit, xiaozhi-xmini, esp32s3-default) that previously lacked any IM integration declarations. Signed-off-by: Chao Liu <chao.liu.zevorn@gmail.com>
zevorn
force-pushed
the
fix/telegram-kconfig-defaults
branch
from
4c62c6d to
536524c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CONFIG_RTCLAW_TELEGRAM_ENABLEwas defined in both ESP32-C3 and ESP32-S3 Kconfig but never declared in anysdkconfig.defaultsprofile, causing it to silently fall through to Kconfig default (n)CONFIG_RTCLAW_TELEGRAM_ENABLEentries to all 9sdkconfig.defaults*files across both ESP32 platformsCONFIG_RTCLAW_FEISHU_ENABLEentries to hardware board defaults (devkit, xiaozhi-xmini, esp32s3-default) that previously lacked any IM integration declarationsAffected files (9)
boards/qemu/sdkconfig.defaultsboards/qemu/sdkconfig.defaults.feishuboards/qemu/sdkconfig.defaults.demoboards/devkit/sdkconfig.defaultsboards/xiaozhi-xmini/sdkconfig.defaultsboards/default/sdkconfig.defaultsTest plan
make build-esp32c3-qemu— verify Telegram config visible in menuconfigmake build-esp32s3-qemu— verify Telegram config visible in menuconfigCONFIG_RTCLAW_TELEGRAM_ENABLEdefaults ton(not set) in all profiles