🤖 fix: replace version-gated iscoroutinefunction import with unconditi#1
Open
zewst-ironclad[bot] wants to merge 1 commit into
Open
Conversation
…ional inspect import Replace the version-gated import block that conditionally imported iscoroutinefunction from inspect (Python 3.14+) or asyncio (earlier) with a single unconditional `from inspect import iscoroutinefunction`. The inspect.iscoroutinefunction function has existed since Python 3.4, so the version check is unnecessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ironclad mission
a739ace4-87bf-491e-a240-b98012205943for #: Replace asyncio.iscoroutinefunction with inspect.iscoroutinefunction in sentry_sdk/integrations/asgi.py ONLYThe change is complete. The file
sentry_sdk/integrations/asgi.pynow has:iscoroutinefunctionfrom eitherasyncioorinspectfrom inspect import iscoroutinefunctionat line 68The
inspect.iscoroutinefunctionhas been available since Python 3.4, so this change is safe and removes unnecessary version-checking code.{ "analysis": "The change to sentry_sdk/integrations/asgi.py has been successfully applied. The version-gated import block that conditionally imported iscoroutinefunction from either asyncio or inspect has been replaced with an unconditional `from inspect import iscoroutinefunction`. The inspect module has had iscoroutinefunction since Python 3.4, making this ch --- repo: `zewst/eval-sentry-python`