ensure php 8.3-8.5 compatibility#3
Merged
falkenhawk merged 1 commit intomasterfrom Apr 1, 2026
Merged
Conversation
- fix implicit nullable parameter deprecation (php 8.4) by removing type hints from parameters with null defaults, keeping php 5.3 compat - fix dynamic property creation in Context (php 8.2+) - $mode_arguments was never matching the declared $modeArguments property - add php 8.3, 8.4, 8.5 to CI test matrix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
implicit nullable parameter deprecation (php 8.4)
removes type hints from parameters with
= NULLdefaults to avoid thephp 8.4 deprecation, while keeping php 5.3 compatibility.
Same approach as used in
zf1s/phpunit- drop the type hint, rely onexisting null handling in the method body.
affected:
IDatabaseConnection::createDataSet(),DefaultDatabaseConnection::createDataSet(),DataSet::buildTableSelect()dynamic property creation (php 8.2+)
Context::setModeArguments()andgetModeArguments()were using$this->mode_arguments(snake_case) while the declared property is
$modeArguments(camelCase) -a latent bug causing dynamic property creation.
CI
adds php 8.3, 8.4, 8.5 to the test matrix.