fix implicit nullable in MockObject Generator::generate()#27
Merged
falkenhawk merged 1 commit intomasterfrom Apr 3, 2026
Merged
fix implicit nullable in MockObject Generator::generate()#27falkenhawk merged 1 commit intomasterfrom
falkenhawk merged 1 commit intomasterfrom
Conversation
`array $methods = NULL` triggers deprecation on php 8.4. Missed in the 3.7.44 release because it's in deps/phpunit-mock-objects which wasn't included in the nullable parameter fix pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
array $methods = NULLinGenerator::generate()triggers deprecation on php 8.4. Missed in the 3.7.44 release because it's indeps/phpunit-mock-objectswhich wasn't included in the nullable parameter fix pass.Removes the
arraytype hint and adds a runtime check, same pattern as the other nullable fixes in PR #25.Manifests as test failures in consumers (e.g. zf1s/zf1) when any test uses
$this->getMock()without specifying methods - phpunit's own test suite doesn't exercise this code path on 8.4.