Validation only works for first line

[rkg823]

Validation only works for the first line. Validation should work for the entire message.
Is there any reason to only validate the first line in the message?

[banyudu]

The .git/COMMIT_EDITMSG file usually looks like this:

real commit message here
# Please enter the commit message for your changes. Lines starting
# with '#' will be ignored, and an empty message aborts the commit.
#
# On branch master
# Your branch is up to date with 'origin/master'.
#
# Changes to be committed:
#       new file:   .gitkeep
#
~
~

There may be unexpected errors if validate the entire message.

So, I don't think commit-message-validator should validate the entire message by default.

By the way, it can be an optional option.

[rkg823]

Yes Please, optional should work.

[rkg823]

Can we have something like this?
message = message.lastIndexOf('\n')>0?message.substring(0, message.lastIndexOf('\n')) : message;

[banyudu]

Can we have something like this?
message = message.lastIndexOf('\n')>0?message.substring(0, message.lastIndexOf('\n')) : message;

So it seems you want to only chop the last line?

It can not solve the issue I mentioned above.

real commit message here
# Please enter the commit message for your changes. Lines starting
# with '#' will be ignored, and an empty message aborts the commit.
#
# On branch master
# Your branch is up to date with 'origin/master'.
#
# Changes to be committed:
#       new file:   .gitkeep
#
~
~

[rkg823]

Can you make it optional? I think there should be an option to get the entire message at least.

[banyudu]

Can you make it optional? I think there should be an option to get the entire message at least.

What message would you like to get from the .git/COMMIT_MSG file?

For example, there's a .git/COMMIT_MSG file:

line 1
line 2
# Please enter the commit message for your changes. Lines starting
# with '#' will be ignored, and an empty message aborts the commit.
#
# On branch master
# Your branch is up to date with 'origin/master'.
#
# Changes to be committed:
#       new file:   .gitkeep
#
~
~

Do you want to get

line 1
line 2

or the entire file

line 1
line 2
# Please enter the commit message for your changes. Lines starting
# with '#' will be ignored, and an empty message aborts the commit.
#
# On branch master
# Your branch is up to date with 'origin/master'.
#
# Changes to be committed:
#       new file:   .gitkeep
#
~
~

[banyudu]

IMO

line 1
line 2

is reasonable and can be the default behavior.

[rkg823]

If i remove this code
message = message.split('\n')[0]
and then commit with the below message
"87453 message
task 54567"

I am seeing the message assigned here as below
let message = fs.readFileSync(commitMsgFile, 'utf8')

"87453 message
task 54567
"
I think if you allow the entire message to the validation method
then I can have regex to validate the part I want to validate and ignore the extra newlines.

[banyudu]

Sounds reasonable, it can be the default behaviour.

[banyudu]

@rkg823 A new major version v1.0.0 released, support multiple lines now by default.