upgrade setup-zig #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the setup-zig GitHub Action from v1 to v2 and simplifies the Zig version management by removing the .zigversion file and associated workflow steps.
- Upgrades
mlugg/setup-zigaction from v1 to v2 - Removes
.zigversionfile containing version "0.14.0" - Eliminates the workflow steps that read the version file and pass it to setup-zig
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.zigversion |
Removes the version file that previously specified Zig 0.14.0 |
.github/workflows/main.yml |
Updates setup-zig to v2 and removes version file reading logic |
Comment on lines
23
to
+24
| - name: Install Zig | ||
| uses: mlugg/setup-zig@v1 | ||
| with: | ||
| version: ${{ steps.zigversion.outputs.content }} | ||
| uses: mlugg/setup-zig@v2 |
There was a problem hiding this comment.
The setup-zig action no longer specifies a Zig version. Consider documenting which version will be used by default in v2, or add a comment explaining the version selection strategy.
Member
Author
There was a problem hiding this comment.
setup-zig uses the minimum_zig_version specified in build.zig.zon by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.