Skip to content

Conversation

@xihale
Copy link
Member

@xihale xihale commented Jan 19, 2026

No description provided.

@gemini-code-assist
Copy link

Summary of Changes

Hello @xihale, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a layout issue by correctly configuring the cross-origin policy for the Mermaid renderer script. By adding the crossorigin attribute, it ensures that the script is loaded and executed properly, which can prevent potential security errors or loading failures related to Cross-Origin Resource Sharing (CORS) when fetching resources from a CDN.

Highlights

  • Mermaid Script Import: The crossorigin="anonymous" attribute has been added to the Mermaid JavaScript import tag within layouts/post.shtml.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@xihale xihale merged commit bc83ccd into main Jan 19, 2026
3 checks passed
@xihale xihale deleted the fix-mermaid branch January 19, 2026 15:17
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly adds the crossorigin="anonymous" attribute to the Mermaid.js script tag, which is a good practice for enabling subresource integrity checks. My review includes a critical security recommendation to update the version of Mermaid.js, as the current version (8.14.0) has known XSS vulnerabilities.

</ctx>
<ctx :if="$page.custom.getOr('mermaid', false)">
<script defer src="https://mirrors.sustech.edu.cn/cdnjs/ajax/libs/mermaid/8.14.0/mermaid.min.js" integrity="sha512-vLumCjg7NKEQKGM+xAgBYTvQ90DVu6Eo7vS1T/iPf2feNLcrpGxvumuUUmE3CPiCUPgviyKbtpWGDbhnVnmJxg==" onload="mermaid.initialize({startOnLoad:true});"></script>
<script defer src="https://mirrors.sustech.edu.cn/cdnjs/ajax/libs/mermaid/8.14.0/mermaid.min.js" integrity="sha512-vLumCjg7NKEQKGM+xAgBYTvQ90DVu6Eo7vS1T/iPf2feNLcrpGxvumuUUmE3CPiCUPgviyKbtpWGDbhnVnmJxg==" crossorigin="anonymous" onload="mermaid.initialize({startOnLoad:true});"></script>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The version of Mermaid.js being used (8.14.0) is outdated and has known security vulnerabilities, such as Cross-Site Scripting (XSS) (e.g., CVE-2022-39204). It is highly recommended to update to a patched version (9.3.0 or later) to mitigate these security risks. I suggest updating to a recent stable version like 10.9.0.

    <script defer src="https://mirrors.sustech.edu.cn/cdnjs/ajax/libs/mermaid/10.9.0/mermaid.min.js" integrity="sha512-f/owfVli2f/rZgE3SgPAOQRC2g4Lp3iU4Lz1T+tHq3iNo2v5s3R3D43sVvjV3gIq/5Zg3Zp26oD3Yx5SgA2hw==" crossorigin="anonymous" onload="mermaid.initialize({startOnLoad:true});"></script>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants