-
Notifications
You must be signed in to change notification settings - Fork 16
fix(layout): Add cross-origin prototype for Mermaid renderer import #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @xihale, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a layout issue by correctly configuring the cross-origin policy for the Mermaid renderer script. By adding the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly adds the crossorigin="anonymous" attribute to the Mermaid.js script tag, which is a good practice for enabling subresource integrity checks. My review includes a critical security recommendation to update the version of Mermaid.js, as the current version (8.14.0) has known XSS vulnerabilities.
| </ctx> | ||
| <ctx :if="$page.custom.getOr('mermaid', false)"> | ||
| <script defer src="https://mirrors.sustech.edu.cn/cdnjs/ajax/libs/mermaid/8.14.0/mermaid.min.js" integrity="sha512-vLumCjg7NKEQKGM+xAgBYTvQ90DVu6Eo7vS1T/iPf2feNLcrpGxvumuUUmE3CPiCUPgviyKbtpWGDbhnVnmJxg==" onload="mermaid.initialize({startOnLoad:true});"></script> | ||
| <script defer src="https://mirrors.sustech.edu.cn/cdnjs/ajax/libs/mermaid/8.14.0/mermaid.min.js" integrity="sha512-vLumCjg7NKEQKGM+xAgBYTvQ90DVu6Eo7vS1T/iPf2feNLcrpGxvumuUUmE3CPiCUPgviyKbtpWGDbhnVnmJxg==" crossorigin="anonymous" onload="mermaid.initialize({startOnLoad:true});"></script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version of Mermaid.js being used (8.14.0) is outdated and has known security vulnerabilities, such as Cross-Site Scripting (XSS) (e.g., CVE-2022-39204). It is highly recommended to update to a patched version (9.3.0 or later) to mitigate these security risks. I suggest updating to a recent stable version like 10.9.0.
<script defer src="https://mirrors.sustech.edu.cn/cdnjs/ajax/libs/mermaid/10.9.0/mermaid.min.js" integrity="sha512-f/owfVli2f/rZgE3SgPAOQRC2g4Lp3iU4Lz1T+tHq3iNo2v5s3R3D43sVvjV3gIq/5Zg3Zp26oD3Yx5SgA2hw==" crossorigin="anonymous" onload="mermaid.initialize({startOnLoad:true});"></script>
No description provided.