Skip to content

fix(chart): rename PUBLIC_WORKFLOWS_DATA_DIR → PUBLIC_WORKFLOWS_DIR to match app + Dockerfile#5

Open
404prefrontalcortexnotfound wants to merge 1 commit into
zigflow:mainfrom
404prefrontalcortexnotfound:fix/chart-public-workflows-dir-typo
Open

fix(chart): rename PUBLIC_WORKFLOWS_DATA_DIR → PUBLIC_WORKFLOWS_DIR to match app + Dockerfile#5
404prefrontalcortexnotfound wants to merge 1 commit into
zigflow:mainfrom
404prefrontalcortexnotfound:fix/chart-public-workflows-dir-typo

Conversation

@404prefrontalcortexnotfound
Copy link
Copy Markdown

Closes #4.

The chart's Deployment exports PUBLIC_WORKFLOWS_DATA_DIR, but the
SvelteKit app reads PUBLIC_WORKFLOWS_DIR in:

  • src/lib/server/workflows-dir.ts
  • src/routes/workflows/+page.server.ts

The Dockerfile also sets ENV PUBLIC_WORKFLOWS_DIR=/data (line 49),
so the chart was the outlier. With this fix, setting dataDir in
values.yaml plumbs through to the running app instead of being
silently ignored and falling back to process.cwd() + '/workflows'.

Verified with helm template — env block now shows
PUBLIC_WORKFLOWS_DIR, matching the app's expectation and the
Dockerfile default.

@404prefrontalcortexnotfound
Copy link
Copy Markdown
Author

Hey @mrsimonemms — here it is, hope it helps. Thanks for making a fantastic tool.

@mrsimonemms
Copy link
Copy Markdown
Contributor

Hey @mrsimonemms — here it is, hope it helps. Thanks for making a fantastic tool.

Thank you. Can you fix the failures and I'll get it merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(chart): deployment sets PUBLIC_WORKFLOWS_DATA_DIR but app reads PUBLIC_WORKFLOWS_DIR

2 participants