stage2 ARM: lower const slices#10868
Merged
kubkon merged 1 commit intoziglang:masterfrom Feb 11, 2022
Merged
Conversation
Member
|
Is the CI failure related by any chance? It didn't happen before 🤔 |
Contributor
Author
I currently don't see how it could be related, the error is in a std test for |
Follow-up to e1a5353 for ARM This also fixes some stack offset calculation bugs
joachimschmidt557
force-pushed
the
stage2-arm
branch
from
ede1307 to
8629a81
Compare
Member
|
Hmm, it passes now which makes me think we might have some hidden race condition somewhere. |
Contributor
Author
Should I open an issue for this? I still have the link to the "original" CI failure here: https://ci.ziglang.org/ziglang/zig/2278/1/4 |
Member
|
Yes please! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to e1a5353 (#10862) for ARM
This also fixes some stack offset calculation bugs
cc @kubkon