std.Build.Dependency: add optional~ functions#21841
Open
dasimmet wants to merge 1 commit intoziglang:masterfrom
Open
std.Build.Dependency: add optional~ functions#21841dasimmet wants to merge 1 commit intoziglang:masterfrom
dasimmet wants to merge 1 commit intoziglang:masterfrom
Conversation
dasimmet
force-pushed
the
lazy-dependency-functions
branch
2 times, most recently
from
9d2e043 to
9e1ba0d
Compare
alexrp
force-pushed
the
lazy-dependency-functions
branch
from
9e1ba0d to
f0005dc
Compare
dasimmet
force-pushed
the
lazy-dependency-functions
branch
from
f0005dc to
6132cdb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a
std.Build.Dependencyrelies on a transitiveb.lazyDependencyto expose an artifact, module, namedWriteFiles or namedLazyPath, calls to these functions panic when the dependency was not downloaded yet, but work fine when it is available in the local cache.We can prevent this by using
optionalArtifact, returning an optional instead of panic.Same for
optionalModule,optionalNamedWriteFilesandoptionalNamedLazyPath.I think the
optional~prefix is better thanlazy~here to avoid confusion withLazyPath.The downside I guess is it could lead to dead code if the named Item will never be available...