std.net: Fix IPv6 address format compression for long zero runs #22441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bondehagen
force-pushed
the
ipv6-zero-runs-compression
branch
from
7c2b944 to
70542a0
Compare
bondehagen
force-pushed
the
ipv6-zero-runs-compression
branch
2 times, most recently
from
579b709 to
591e41b
Compare
Member
|
The obvious issue with your implementation is that it doesn't work on big-endian hosts. This logic should not be attached to the endianness conversion. |
bondehagen
force-pushed
the
ipv6-zero-runs-compression
branch
2 times, most recently
from
2f5d5a6 to
249a1a5
Compare
Contributor
Author
@mlugg Ups, moved to separate loop now |
bondehagen
force-pushed
the
ipv6-zero-runs-compression
branch
from
249a1a5 to
dc0e56a
Compare
bondehagen
force-pushed
the
ipv6-zero-runs-compression
branch
from
4a766b4 to
2d377f5
Compare
bondehagen
force-pushed
the
ipv6-zero-runs-compression
branch
from
2d377f5 to
325e017
Compare
Contributor
Author
|
@MatthiasPortzel Would it be possible for you to take a look again? |
|
Nothing else that jumps out at me, but I’m not the one you need to ask. I’m unaffiliated with Zig, I was just making a suggestion. I know the core team is busy reviewing PRs ahead of the 0.14 release so I would just wait at this point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug in Ip6Address.format where improper zero-run handling led to incorrect IPv6 compression.
This PR fixes #22440.