Closed
Conversation
nektro
reviewed
Jan 26, 2025
Implement clone3 based on the clone(2) man page
Member
Contributor
Author
|
This is an incorrect implementation, see #22368 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements clone3 based on the clone(2) man page.
I did my best to follow the convention that
std.os.linuxcontains the straight syscall, andstd.posixcontains the syscall with error handling. If I broke some convention please let me know.I did not add the
ERESTARTNOINTRerror case because I am unsure where exactly to add the errno code (only to linux, everywhere and if so where all is everywhere). If that's a prerequisite for merging please point me to where to add the errno code.Finally in line with the other structs I found in
std.os.linuxI added minimal documentation to the fields and none to the flags. If I were to add the man page documentation it'd explode to a couple hundred lines which seems overkill.Closes #18508