Skip to content

std.os.linux.IoUring: IORING_ENTER_NO_IOWAIT flag support #25604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

std.os.linux.IoUring: IORING_ENTER_NO_IOWAIT flag support #25604

wants to merge 1 commit into from

Conversation

@RaidoAun
Copy link

andrewrk
andrewrk approved these changes Oct 16, 2025
View reviewed changes
Copy link
Member

@andrewrk andrewrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@andrewrk andrewrk enabled auto-merge (rebase) October 16, 2025 20:19
auto-merge was automatically disabled October 17, 2025 09:31

Head branch was pushed to by a user without write access

@RaidoAun RaidoAun force-pushed the IORING_ENTER_NO_IOWAIT-flag-support- branch from 4cfa5b8 to 0080795 Compare October 17, 2025 09:31
@RaidoAun
Copy link
Author

RaidoAun commented Oct 17, 2025 •
edited
Loading

@andrewrk it turns out that I made a mistake regarding the usage of flags, liburing introduced int_flags which we lacked. I thought we were using them as the flags field but turns out that was false. I added the int_flags field just like liburing has them.
with the previous changes setting the IOWAIT flag would overwrite IORING_SETUP_SUBMIT_ALL flag.

The only caveat is that liburing does some extra work to set the int_flags according to the setup flags, but since we seem to be behind liburing quite a bit then I do not think it is for this PR to also solve those issues. There should be a followup issue if there is a desire for this. Currently there is nothing inherently wrong since previously there just wasnt even the support to have persistent flags for enter, now atleast there are but they have to be set manually.

@RaidoAun RaidoAun requested a review from andrewrk October 17, 2025 09:40
@RaidoAun RaidoAun force-pushed the IORING_ENTER_NO_IOWAIT-flag-support- branch from 0080795 to bb6b867 Compare October 17, 2025 10:22
@RaidoAun RaidoAun mentioned this pull request Oct 17, 2025
Open
18 tasks
bernardassan added a commit to bernardassan/zig that referenced this pull request Oct 17, 2025
@bernardassan
Implement set_io_wait functionality
c43fdb4 
closes ziglang#25566
closes ziglang#25604

and IoUring enter_flags() helper function
add typed Init flags which match int_flags in liburing

Signed-off-by: Bernard Assan <mega.alpha100@gmail.com>
bernardassan added a commit to bernardassan/zig that referenced this pull request Oct 17, 2025
@bernardassan
IoUring: Implement set_iowait functionality
0768827 
closes ziglang#25566
closes ziglang#25604

and IoUring enter_flags() helper function
add typed Init flags which match int_flags in liburing

Signed-off-by: Bernard Assan <mega.alpha100@gmail.com>
bernardassan added a commit to bernardassan/zig that referenced this pull request Oct 17, 2025
@bernardassan
IoUring: Implement set_iowait functionality
53b2359 
closes ziglang#25566
closes ziglang#25604

and IoUring enter_flags() helper function
add typed Init flags which match int_flags in liburing

Signed-off-by: Bernard Assan <mega.alpha100@gmail.com>
bernardassan added a commit to bernardassan/zig that referenced this pull request Oct 17, 2025
@bernardassan @RaidoAun
IoUring: Implement set_iowait functionality
5785357 
closes ziglang#25566
closes ziglang#25604

and IoUring enter_flags() helper function
add typed Init flags which match int_flags in liburing

Co-authored-by: RaidoAun <45874591+RaidoAun@users.noreply.github.com>
Signed-off-by: Bernard Assan <mega.alpha100@gmail.com>
bernardassan added a commit to bernardassan/zig that referenced this pull request Oct 17, 2025
@bernardassan @RaidoAun
IoUring: Implement set_iowait functionality
dba0c81 
closes ziglang#25566
closes ziglang#25604

and IoUring enter_flags() helper function
add typed Init flags which match int_flags in liburing

Co-authored-by: RaidoAun <45874591+RaidoAun@users.noreply.github.com>
Signed-off-by: Bernard Assan <mega.alpha100@gmail.com>
bernardassan added a commit to bernardassan/zig that referenced this pull request Oct 21, 2025
@bernardassan @RaidoAun
IoUring: Implement set_iowait functionality
caf492e 
closes ziglang#25566
closes ziglang#25604

and IoUring enter_flags() helper function
add typed Init flags which match int_flags in liburing

Co-authored-by: RaidoAun <45874591+RaidoAun@users.noreply.github.com>
Signed-off-by: Bernard Assan <mega.alpha100@gmail.com>
bernardassan added a commit to bernardassan/zig that referenced this pull request Oct 25, 2025
@bernardassan @RaidoAun
IoUring: Implement set_iowait functionality
4600dc7 
closes ziglang#25566
closes ziglang#25604

and IoUring enter_flags() helper function
add typed Init flags which match int_flags in liburing

Co-authored-by: RaidoAun <45874591+RaidoAun@users.noreply.github.com>
Signed-off-by: Bernard Assan <mega.alpha100@gmail.com>
bernardassan added a commit to bernardassan/zig that referenced this pull request Oct 27, 2025
@bernardassan @RaidoAun
IoUring: Implement set_iowait functionality
487ba41 
closes ziglang#25566
closes ziglang#25604

and IoUring enter_flags() helper function
add typed Init flags which match int_flags in liburing

Co-authored-by: RaidoAun <45874591+RaidoAun@users.noreply.github.com>
Signed-off-by: Bernard Assan <mega.alpha100@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewrk andrewrk Awaiting requested review from andrewrk

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

std.os.Linux.IoUring: add IORING_ENTER_NO_IOWAIT flag support

2 participants

@RaidoAun @andrewrk