stage1: Compile error instead of falling back to C for unsupported cc#6829
Merged
Vexu merged 4 commits intoziglang:masterfrom Nov 19, 2020
Merged
stage1: Compile error instead of falling back to C for unsupported cc#6829Vexu merged 4 commits intoziglang:masterfrom
Vexu merged 4 commits intoziglang:masterfrom
Conversation
tadeokondrak
changed the title
xackus
reviewed
Oct 27, 2020
Contributor
xackus
left a comment
xackus
left a comment
There was a problem hiding this comment.
Could you add a test to test/compile_errors.zig?
Vexu
force-pushed
the
error-unsupported-callconv
branch
from
b98dd3c to
f6ed7cd
Compare
Vexu
force-pushed
the
error-unsupported-callconv
branch
from
f6ed7cd to
3a28b65
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening this to check CI, since GitHub won't let me reopen the old one.Still needs translate-c support before it's ready.
translate-c seems to already be arch-specific, and clang gives us the right calling conventions by default.
Closes #6536.