Added guard before setting result on reset future#101
Merged
AndreasBomholtz merged 6 commits intomasterfrom Jun 8, 2018
Merged
Added guard before setting result on reset future#101AndreasBomholtz merged 6 commits intomasterfrom
AndreasBomholtz merged 6 commits intomasterfrom
Conversation
Pull Request Test Coverage Report for Build 479
💛 - Coveralls |
1 similar comment
Pull Request Test Coverage Report for Build 479
💛 - Coveralls |
Pull Request Test Coverage Report for Build 546
💛 - Coveralls |
rcloran
reviewed
Feb 12, 2018
bellows/uart.py
Outdated
|
|
||
| self._reset_future.set_result(True) | ||
| # Make sure that the reset_future is not done | ||
| if self._reset_future.done() is not True: |
Collaborator
There was a problem hiding this comment.
if not self._reset_future.done() ?
Contributor
Author
There was a problem hiding this comment.
It was just a easy way, not to rewrite the test cases. But I can just rewrite them to make them pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix the issue #76. @titilambert Can you test this small change?