Skip to content

increase table size#104

Merged
AndreasBomholtz merged 3 commits into
zigpy:masterfrom
Yoda-x:clean_increase_table
Feb 27, 2018
Merged

increase table size#104
AndreasBomholtz merged 3 commits into
zigpy:masterfrom
Yoda-x:clean_increase_table

Conversation

@Yoda-x
Copy link
Copy Markdown
Contributor

@Yoda-x Yoda-x commented Feb 18, 2018

increased max childen to 32
address-table to 16
source_routes to 8

tried to be conservative to keep enough buffers for normal operations

@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 488

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 477: 0.0%
Covered Lines: 1321
Relevant Lines: 1321

💛 - Coveralls

1 similar comment
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 488

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 477: 0.0%
Covered Lines: 1321
Relevant Lines: 1321

💛 - Coveralls

@coveralls
Copy link
Copy Markdown

coveralls commented Feb 18, 2018

Pull Request Test Coverage Report for Build 503

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 501: 0.0%
Covered Lines: 1321
Relevant Lines: 1321

💛 - Coveralls

yield from self._cfg(c.CONFIG_APPLICATION_ZDO_FLAGS, zdo)
yield from self._cfg(c.CONFIG_TRUST_CENTER_ADDRESS_CACHE_SIZE, 2)
yield from self._cfg(c.CONFIG_ADDRESS_TABLE_SIZE, 16)
yield from self._cfg(c.CONFIG_SOURCE_ROUTE_TABLE_SIZE, 8)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default value from Silabs is 32 for the "CONFIG_SOURCE_ROUTE_TABLE_SIZE". Maybe we should at least keep it at that value or higher. I have seen in some of the Silabs example code that they have values like 100 and 250 for this value.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you look at the UG100 doc from silab, page 5: it says the default value is 0.
i did also a config_read before writing for my em357 stick:
2018-02-23 21:53:51 DEBUG (MainThread) [bellows.zigbee.application] default CONFIG_ADDRESS_TABLE_SIZE: 8
2018-02-23 21:53:51 DEBUG (MainThread) [bellows.zigbee.application] default c.CONFIG_NEIGHBOR_TABLE_SIZE: 16
2018-02-23 21:53:51 DEBUG (MainThread) [bellows.zigbee.application] default c.CONFIG_SOURCE_ROUTE_TABLE_SIZE: 0
2018-02-23 21:53:51 DEBUG (MainThread) [bellows.zigbee.application] default c.CONFIG_MAX_END_DEVICE_CHILDREN: 6

I`m pretty sure there a different default settings depending on the OEM or chipset(em357:12kB RAM, em3588:64kB RAM)
When I used larger tables, I saw often failures, where I had no buffers left.
From what I read is the MAX.END_DEVICE_CHILDREN table a hard stop, if it's full it is full.
the other tables do a cleanup or time_out old values.

if you want to check your default settings, thats the code I added https://gist.github.com/Yoda-x/8ab346a3ef6d7c08c9e9750ebdfbef98.js

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have the same default values in the chip, I was talking about the Silabs Zigbee Gateway program that configures the chip. It configures the values different.

I'm working on a MGM111 which has 32Kb ram, so it works fine for me. But if there is a memory issue with the lower end chips, then we should not increase it.

I will just accept your values.

@AndreasBomholtz AndreasBomholtz merged commit 907336d into zigpy:master Feb 27, 2018
@Yoda-x Yoda-x deleted the clean_increase_table branch March 11, 2018 20:39
Yoda-x added a commit to Yoda-x/bellows that referenced this pull request Mar 18, 2018
* increase table size
Yoda-x added a commit to Yoda-x/bellows that referenced this pull request Mar 18, 2018
* increase table size
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants