Silabs released new version of ezsp protocol#112
Merged
AndreasBomholtz merged 2 commits intomasterfrom Apr 7, 2018
unknown repository
Merged
Silabs released new version of ezsp protocol#112AndreasBomholtz merged 2 commits intomasterfrom unknown repository
AndreasBomholtz merged 2 commits intomasterfrom
unknown repository
Conversation
Silicon labs have released new version of their protocol - v6.
This small change fixes the issue with it. Without this change it fails during start up with the following log:
```
Traceback (most recent call last):
File "uvloop/cbhandles.pyx", line 47, in uvloop.loop.Handle._run
File "/usr/lib/python3.6/site-packages/serial_asyncio/__init__.py", line 106, in _read_ready
self._protocol.data_received(data)
File "/usr/lib/python3.6/site-packages/bellows/uart.py", line 64, in data_received
self.frame_received(frame)
File "/usr/lib/python3.6/site-packages/bellows/uart.py", line 76, in frame_received
self.data_frame_received(data)
File "/usr/lib/python3.6/site-packages/bellows/uart.py", line 97, in data_frame_received
self._application.frame_received(self._randomize(data[1:-3]))
File "/usr/lib/python3.6/site-packages/bellows/ezsp.py", line 173, in frame_received
assert expected_id == frame_id
AssertionError
```
The failure occurs because these additional bytes are not inserted.
Tested with:
- EFR32MG12 development kit
- Silabs EM3588 USB adapter
- Elelabs ZigBee Raspberry Pi shield (EM357)
- Elelabs ZigBee USB adapter (EM3585)
Pull Request Test Coverage Report for Build 506
💛 - Coveralls |
Pull Request Test Coverage Report for Build 507
💛 - Coveralls |
AndreasBomholtz
suggested changes
Apr 7, 2018
Contributor
AndreasBomholtz
left a comment
AndreasBomholtz
left a comment
There was a problem hiding this comment.
Perhaps it would be better to change it check for greater or equal to 5.
AndreasBomholtz
approved these changes
Apr 7, 2018
Yoda-x
pushed a commit
to Yoda-x/bellows
that referenced
this pull request
May 5, 2018
* Silabs released new version of exsp protocol
Silicon labs have released new version of their protocol - v6.
This small change fixes the issue with it. Without this change it fails during start up with the following log:
```
Traceback (most recent call last):
File "uvloop/cbhandles.pyx", line 47, in uvloop.loop.Handle._run
File "/usr/lib/python3.6/site-packages/serial_asyncio/__init__.py", line 106, in _read_ready
self._protocol.data_received(data)
File "/usr/lib/python3.6/site-packages/bellows/uart.py", line 64, in data_received
self.frame_received(frame)
File "/usr/lib/python3.6/site-packages/bellows/uart.py", line 76, in frame_received
self.data_frame_received(data)
File "/usr/lib/python3.6/site-packages/bellows/uart.py", line 97, in data_frame_received
self._application.frame_received(self._randomize(data[1:-3]))
File "/usr/lib/python3.6/site-packages/bellows/ezsp.py", line 173, in frame_received
assert expected_id == frame_id
AssertionError
```
The failure occurs because these additional bytes are not inserted.
Tested with:
- EFR32MG12 development kit
- Silabs EM3588 USB adapter
- Elelabs ZigBee Raspberry Pi shield (EM357)
- Elelabs ZigBee USB adapter (EM3585)
* Now checking if version is greater than or equal to 5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Silicon labs have released new version of their protocol - v6.
This small change fixes the issue with it. Without this change it fails during start up with the following log:
The failure occurs because these additional bytes are not inserted.
Tested with: