Skip to content

Conversation

@prairiesnpr
Copy link
Contributor

We have two definitions for SensorDeviceClass.

zha.application.platforms.sensor.const.SensorDeviceClass and zigpy.quirks.v2.homeassistant.sensor.SensorDeviceClass

Quirks will import from zigpy and the current logic would fail to match. This works for both enums and modifies the tests to ensure we test both enums.

@codecov
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.31%. Comparing base (3d34a30) to head (d3ac280).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #248   +/-   ##
=======================================
  Coverage   96.31%   96.31%           
=======================================
  Files          61       61           
  Lines        9366     9366           
=======================================
  Hits         9021     9021           
  Misses        345      345           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmulcahey dmulcahey merged commit 2cfd334 into zigpy:dev Oct 18, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants