Skip to content

Conversation

@TheJulianJES
Copy link
Contributor

Part 1 of changes related to: zigpy/zigpy#1488

Proposed change

This adds translation_key and fallback_name to all tests where a v2 quirk entity is created.

Additional information

With the PR below, zigpy always requires fallback_name name to be set. translation_key also needs to be set if device_class is not set.

This PR should be merged before a zigpy bump with the PR below to ensure tests still pass. However, this PR only makes sense if we go through with the changes from the PR below.

zigpy now always requires `fallback_name` name to be set.
`translation_key` also needs to be set if `device_class` is not set.
@codecov
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.27%. Comparing base (2cfd334) to head (0da6fd4).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #252      +/-   ##
==========================================
- Coverage   96.31%   96.27%   -0.05%     
==========================================
  Files          61       61              
  Lines        9366     9366              
==========================================
- Hits         9021     9017       -4     
- Misses        345      349       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheJulianJES
Copy link
Contributor Author

zigpy/zigpy#1488 is merged now, so we can already merge this to be ready for the zigpy bump.
The slight decrease in code coverage is the defaulting to attribute_name/command_name no longer being tested. https://app.codecov.io/gh/zigpy/zha/pull/252/indirect-changes

That code will be removed with the next PR: #251
I wanted to separate all test changes (this PR) from proper/behavioral changes.

@TheJulianJES TheJulianJES marked this pull request as ready for review October 21, 2024 16:52
@puddly puddly merged commit 927e249 into zigpy:dev Oct 21, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants