Add test for endpoint initialization failure#719
Merged
TheJulianJES merged 2 commits intozigpy:devfrom Mar 24, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #719 +/- ##
==========================================
+ Coverage 97.62% 97.64% +0.01%
==========================================
Files 62 62
Lines 10950 10951 +1
==========================================
+ Hits 10690 10693 +3
+ Misses 260 258 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a regression/unit test to exercise the Device.async_initialize() code path that catches and logs exceptions raised during per-endpoint initialization, improving coverage for the endpoint-initialization failure branch.
Changes:
- Add an async test that patches an endpoint’s
async_initializeto raise and then callszha_device.async_initialize(from_cache=True).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
This adds a small test for endpoint initialization failure here:
zha/zha/zigbee/device.py
Lines 995 to 996 in 5848461
Needed for code coverage in below PR (since a surrounding line is touched by that PR):