Skip to content

Disable light default move rate config entity by default#741

Merged
TheJulianJES merged 3 commits intozigpy:devfrom
TheJulianJES:tjj/disable_default_move_rate_entity_default
Apr 29, 2026
Merged

Disable light default move rate config entity by default#741
TheJulianJES merged 3 commits intozigpy:devfrom
TheJulianJES:tjj/disable_default_move_rate_entity_default

Conversation

@TheJulianJES
Copy link
Copy Markdown
Contributor

Proposed change

This disables the "Default move rate" config entity for lights by default.

Additional information

The entity is not really used at all, unless you directly bind a remote to it, or send raw ZCL move commands.

Most lights also do not support it, but for the ones that do, we now disable the entity by default with this PR to clean up the "Configuration" section on the device page a bit. Most people don't have any clue what this entity does.

Notes

The entity is not disabled for existing (paired) devices, only for ones paired with this version of ZHA (and newer).
The entity can still be enabled using Home Assistant.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.63%. Comparing base (5013814) to head (a39ed66).
⚠️ Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #741   +/-   ##
=======================================
  Coverage   97.63%   97.63%           
=======================================
  Files          62       62           
  Lines       10814    10815    +1     
=======================================
+ Hits        10558    10559    +1     
  Misses        256      256           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TheJulianJES TheJulianJES marked this pull request as ready for review April 29, 2026 06:37
Copilot AI review requested due to automatic review settings April 29, 2026 06:37
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR disables the LevelControl “Default move rate” number configuration entity by default to reduce device-page configuration clutter, while keeping it manually enableable via Home Assistant.

Changes:

  • Mark DefaultMoveRateConfigurationEntity as disabled-by-default via _attr_entity_registry_enabled_default = False.
  • Update affected device fixture snapshots to expect entity_registry_enabled_default: false for the default move rate entity.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
zha/application/platforms/number/__init__.py Disables the Default Move Rate number config entity by default.
tests/data/devices/schneider-electric-lk-dimmer.json Updates snapshot expectation for the default move rate entity’s default enabled state.
tests/data/devices/legrand-dimmer-switch-w-o-neutral.json Same snapshot update for default move rate entity.
tests/data/devices/ledvance-outdoor-accent-light-rgb.json Same snapshot update for default move rate entity.
tests/data/devices/ledvance-flex-rgbw.json Same snapshot update for default move rate entity.
tests/data/devices/inovelli-vzm30-sn.json Same snapshot update for default move rate entity.
tests/data/devices/bega-gantenbrink-leuchten-kg-smart-dimmable-light.json Same snapshot update for default move rate entity.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread zha/application/platforms/number/__init__.py
@TheJulianJES TheJulianJES merged commit af84e97 into zigpy:dev Apr 29, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants