Disable light default move rate config entity by default#741
Merged
TheJulianJES merged 3 commits intozigpy:devfrom Apr 29, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #741 +/- ##
=======================================
Coverage 97.63% 97.63%
=======================================
Files 62 62
Lines 10814 10815 +1
=======================================
+ Hits 10558 10559 +1
Misses 256 256 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR disables the LevelControl “Default move rate” number configuration entity by default to reduce device-page configuration clutter, while keeping it manually enableable via Home Assistant.
Changes:
- Mark
DefaultMoveRateConfigurationEntityas disabled-by-default via_attr_entity_registry_enabled_default = False. - Update affected device fixture snapshots to expect
entity_registry_enabled_default: falsefor the default move rate entity.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
zha/application/platforms/number/__init__.py |
Disables the Default Move Rate number config entity by default. |
tests/data/devices/schneider-electric-lk-dimmer.json |
Updates snapshot expectation for the default move rate entity’s default enabled state. |
tests/data/devices/legrand-dimmer-switch-w-o-neutral.json |
Same snapshot update for default move rate entity. |
tests/data/devices/ledvance-outdoor-accent-light-rgb.json |
Same snapshot update for default move rate entity. |
tests/data/devices/ledvance-flex-rgbw.json |
Same snapshot update for default move rate entity. |
tests/data/devices/inovelli-vzm30-sn.json |
Same snapshot update for default move rate entity. |
tests/data/devices/bega-gantenbrink-leuchten-kg-smart-dimmable-light.json |
Same snapshot update for default move rate entity. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
This disables the "Default move rate" config entity for lights by default.
Additional information
The entity is not really used at all, unless you directly bind a remote to it, or send raw ZCL
movecommands.Most lights also do not support it, but for the ones that do, we now disable the entity by default with this PR to clean up the "Configuration" section on the device page a bit. Most people don't have any clue what this entity does.
Notes
The entity is not disabled for existing (paired) devices, only for ones paired with this version of ZHA (and newer).
The entity can still be enabled using Home Assistant.