Skip to content

Remove pyserial dependencies#746

Merged
TheJulianJES merged 1 commit intozigpy:devfrom
TheJulianJES:tjj/remove_pyserial_dependencies
Apr 20, 2026
Merged

Remove pyserial dependencies#746
TheJulianJES merged 1 commit intozigpy:devfrom
TheJulianJES:tjj/remove_pyserial_dependencies

Conversation

@TheJulianJES
Copy link
Copy Markdown
Contributor

@TheJulianJES TheJulianJES commented Apr 20, 2026

Proposed change

This removes the explicit pyserial and pyserial-asyncio-fast dependencies we had (for some reason).

Additional information

Zigpy (and thus ZHA) exclusively use Serialx now after the following PRs:

Copilot AI review requested due to automatic review settings April 20, 2026 17:13
@puddly
Copy link
Copy Markdown
Contributor

puddly commented Apr 20, 2026

Oops, I didn't know we had these. Thanks for the catch.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes explicit pyserial / pyserial-asyncio-fast declarations from ZHA’s packaging metadata now that serial support is provided via zigpy’s switch to Serialx (and its transitive dependencies).

Changes:

  • Drop pyserial==3.5 from pyproject.toml project dependencies
  • Drop pyserial-asyncio-fast from pyproject.toml project dependencies

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.63%. Comparing base (650e08a) to head (f9b17cb).
⚠️ Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #746   +/-   ##
=======================================
  Coverage   97.63%   97.63%           
=======================================
  Files          62       62           
  Lines       10814    10814           
=======================================
  Hits        10558    10558           
  Misses        256      256           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TheJulianJES TheJulianJES merged commit 7b85184 into zigpy:dev Apr 20, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants