Skip to content

Conversation

@dotlambda
Copy link
Contributor

No description provided.

@puddly
Copy link
Contributor

puddly commented Nov 1, 2025

Thanks! This needs one tiny patch to get CI passing again, it hasn't run in a while:

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 2b1f0c2..84ac791 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -11,8 +11,6 @@ jobs:
     with:
       CODE_FOLDER: zigpy_xbee
       CACHE_VERSION: 2
-      PYTHON_VERSION_DEFAULT: 3.9.15
-      PRE_COMMIT_CACHE_PATH:  ~/.cache/pre-commit
       MINIMUM_COVERAGE_PERCENTAGE: 100
     secrets:
       CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}

@puddly
Copy link
Contributor

puddly commented Nov 1, 2025

Looks like a few tests now fail due to asyncio changes in 3.14. This should do the trick:

diff --git a/tests/test_api.py b/tests/test_api.py
index 48768e1..a366a81 100644
--- a/tests/test_api.py
+++ b/tests/test_api.py
@@ -323,7 +323,7 @@ def _handle_at_response(api, tsn, status, at_response=b""):
     return response


-def test_handle_at_response_none(api):
+async def test_handle_at_response_none(api):
     """Test AT successful response with no value."""
     tsn = 123
     fut = _handle_at_response(api, tsn, 0)
@@ -332,7 +332,7 @@ def test_handle_at_response_none(api):
     assert fut.exception() is None


-def test_handle_at_response_data(api):
+async def test_handle_at_response_data(api):
     """Test AT successful response with data."""
     tsn = 123
     status, response = 0, 0x23
@@ -342,7 +342,7 @@ def test_handle_at_response_data(api):
     assert fut.exception() is None


-def test_handle_at_response_error(api):
+async def test_handle_at_response_error(api):
     """Test AT unsuccessful response."""
     tsn = 123
     status, response = 1, 0x23
@@ -351,7 +351,7 @@ def test_handle_at_response_error(api):
     assert isinstance(fut.exception(), ATCommandError)


-def test_handle_at_response_invalid_command(api):
+async def test_handle_at_response_invalid_command(api):
     """Test invalid AT command response."""
     tsn = 123
     status, response = 2, 0x23
@@ -360,7 +360,7 @@ def test_handle_at_response_invalid_command(api):
     assert isinstance(fut.exception(), InvalidCommand)


-def test_handle_at_response_undef_error(api):
+async def test_handle_at_response_undef_error(api):
     """Test AT unsuccessful response with undefined error."""
     tsn = 123
     status, response = 0xEE, 0x23
@@ -482,7 +482,7 @@ def test_handle_tx_status_duplicate(api):
     assert send_fut.set_exception.call_count == 0


-def test_handle_registration_status(api):
+async def test_handle_registration_status(api):
     """Test device registration status."""
     frame_id = 0x12
     status = xbee_t.RegistrationStatus.SUCCESS
@@ -526,7 +526,7 @@ async def test_command_mode_at_cmd_timeout(api):
     assert result is None


-def test_handle_command_mode_rsp(api):
+async def test_handle_command_mode_rsp(api):
     """Test command mode response."""
     api._cmd_mode_future = None
     data = "OK"

@codecov
Copy link

codecov bot commented Nov 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (dev@c2d2f5b). Learn more about missing BASE report.
⚠️ Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##             dev      #178   +/-   ##
=======================================
  Coverage       ?   100.00%           
=======================================
  Files          ?         7           
  Lines          ?       718           
  Branches       ?         0           
=======================================
  Hits           ?       718           
  Misses         ?         0           
  Partials       ?         0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@puddly puddly merged commit f5f9d6f into zigpy:dev Nov 1, 2025
12 checks passed
@puddly
Copy link
Contributor

puddly commented Nov 1, 2025

Thanks!

@dotlambda dotlambda deleted the pyserial-asyncio-fast branch November 1, 2025 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants