Skip to content

v3.25.0 — Configurable MMR fix_threshold

Choose a tag to compare

View all tags
@zigrivers zigrivers released this 28 Apr 18:02
· 318 commits to main since this release
v3.25.0
6f2acaf
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode.

Highlights

  • Configurable fix_threshold across the review stack. scaffold run review-pr, review-code, and post-implementation-review now accept --fix-threshold P0|P1|P2|P3 and forward to mmr review. Default behavior unchanged when the flag is omitted.
  • Self-documenting mmr config init. New .mmr.yaml files include an explanatory comment block above fix_threshold describing each severity tier, with P2 written explicitly so future MMR default shifts won't silently change behavior for existing projects.
  • advisory_count in MMR verdicts. Findings strictly below the configured threshold are now counted in results.advisory_count and rendered as Advisory: N (text) or **Advisory:** N (markdown) in the verdict copy when non-zero. The gate is unchanged — these findings stay in reconciled_findings but don't cause blocked.
  • Agent-facing docs read fix_threshold from the verdict JSON instead of hardcoding P0/P1/P2. Per-channel review prompts now request all P0–P3 findings (was P0/P1/P2 only) so projects running at threshold P3 actually surface P3 findings.

Bundled

  • @zigrivers/mmr@1.3.0

Why this matters

The appropriate fix threshold varies by project — a prototype or doc-only PR may only warrant blocking on P0/P1, while a security-sensitive change may warrant blocking on P0–P3. Before this release, the threshold was hardcoded to P2 in agent-facing docs even though the MMR CLI had supported --fix-threshold for a while. This release makes the threshold configurable per-project (via .mmr.yaml) and per-invocation (via the wrapper passthrough), and makes the doc layer threshold-aware.

Migration

No migration needed. Behavior is unchanged at the default threshold (P2), which is what every project gets unless they explicitly opt in to a different value.

To pin a different threshold:

mmr config init    # creates .mmr.yaml with P2 + comment block
# Edit .mmr.yaml: change `fix_threshold: P2` to P0/P1/P3 as appropriate

To override per-invocation:

scaffold run review-pr -- --fix-threshold P1

Full changelog

  • See CHANGELOG.md for the complete list of changes
  • PR #315 — feature work
  • PR #316 — mmr v1.3.0 release-prep
  • PR #317 — v3.25.0 release-prep
Assets 2
Loading