fix: handle analysis of decls more correctly#3190
Open
neoto wants to merge 1 commit intozigtools:masterfrom
Open
fix: handle analysis of decls more correctly#3190neoto wants to merge 1 commit intozigtools:masterfrom
neoto wants to merge 1 commit intozigtools:masterfrom
Conversation
Handles references to aliased decls more correctly by distinguishing between containers and runtime types. Compared to zigtools#3189 which special cases renames, this _should_ address the root cause, fixing both renaming and highlighting symbols. I also added regression tests that fail without the changes on this branch. Closes zigtools#3184
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handles references to aliased decls more correctly by distinguishing between containers and runtime types. Compared to
#3189 which special cases renames, this should address the root cause, fixing both renaming and highlighting symbols. I also added regression tests that fail without the changes on this branch.
Closes #3184