chore: drop image_url column from world_heritage_sites#393
chore: drop image_url column from world_heritage_sites#393zigzagdev merged 1 commit intofeat/clean-up-codefrom
Conversation
zigzagdev
left a comment
zigzagdev
left a comment
There was a problem hiding this comment.
Note
Some tests referencing image_url are still failing.
These will be fixed in the next PR.
There was a problem hiding this comment.
Pull request overview
Drops the legacy image_url column from the world_heritage_sites table as the final step of the image refactor, relying on world_heritage_site_images as the single source of truth.
Changes:
- Add a migration to drop
world_heritage_sites.image_url - Add rollback behavior to restore the
image_urlcolumn if needed
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| Schema::table('world_heritage_sites', function (Blueprint $table) { | ||
| $table->dropColumn('image_url'); | ||
| }); |
There was a problem hiding this comment.
Dropping world_heritage_sites.image_url will break any seed/test code that still inserts or upserts an image_url field into world_heritage_sites (e.g., src/database/seeders/WorldHeritageSeeder.php and multiple query service tests). Please remove/replace those writes before merging, otherwise running migrations + seeders/tests will fail with an unknown column error.
What
image_urlcolumn fromworld_heritage_sitestableWhy
image_urlis now sourced exclusively from world_heritage_site_images.This is the final step of the image refactoring (#294).
Verification
php artisan app:world-heritage-build --fresh --jp --pretty --clear --algolia --algolia-truncatesuccessfully