Chore/import main image url into json#450
Merged
zigzagdev merged 2 commits intochore/add-main_iamge_urlfrom May 4, 2026
Merged
Chore/import main image url into json#450zigzagdev merged 2 commits intochore/add-main_iamge_urlfrom
zigzagdev merged 2 commits intochore/add-main_iamge_urlfrom
Conversation
In normalizeSiteRowImportReady, surface main_image_url on every newly created site row in world_heritage_sites.json. The lookup prefers the local dump's image_url key (UNESCO main_image_url is renamed to image_url by DumpUnescoWorldHeritageJson) and falls back to main_image_url for sources that keep the original UNESCO field name. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
In mergeSiteRowPreferExisting, fill main_image_url onto an already seen site row when the existing entry has none and a duplicate row provides a value. This keeps the existing-wins semantics consistent with the rest of the merge while ensuring transnational/duplicate rows do not silently drop the hero image. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.