Feature Test#81
Merged
zigzagdev merged 1 commit intofeature/central-asiafrom Aug 27, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes feature tests for world heritage creation functionality. The changes primarily update test data from Japanese heritage sites to transnational European and Asian heritage sites, add database seeding for countries, and update parameter mappings.
- Updated test data to use transnational heritage sites with multiple state parties
- Added country seeding and additional table truncation in test setup/teardown
- Fixed parameter mapping from 'state_party_codes' to 'state_parties' in the factory
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| CreateManyWorldHeritagesTest.php | Updated test data structure, added country seeding, and expanded database cleanup |
| CreateWorldManyHeritagesUseCase.php | Added state party codes and metadata parameters to heritage creation |
| WorldHeritageListQueryFactory.php | Fixed parameter mapping from 'state_party_codes' to 'state_parties' |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| 'unesco_site_url' => 'https://whc.unesco.org/en/list/660/', | ||
| 'unesco_site_url' => 'https://whc.unesco.org/en/list/1133/', | ||
| 'state_parties' => [ | ||
| 'AL','AT','BE','BA','BG','HR','CZ','FR','DE','IT','MK','PL','RO','SK','SI','ES','CH','UA' |
There was a problem hiding this comment.
[nitpick] The long array of country codes on a single line reduces readability. Consider formatting this as a multi-line array with one or a few codes per line for better maintainability.
Suggested change
| 'AL','AT','BE','BA','BG','HR','CZ','FR','DE','IT','MK','PL','RO','SK','SI','ES','CH','UA' | |
| 'AL', 'AT', 'BE', 'BA', | |
| 'BG', 'HR', 'CZ', 'FR', | |
| 'DE', 'IT', 'MK', 'PL', | |
| 'RO', 'SK', 'SI', 'ES', | |
| 'CH', 'UA' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what i have done