Skip to content

Feature Test#81

Merged
zigzagdev merged 1 commit intofeature/central-asiafrom
feature/central-asia-test
Aug 27, 2025
Merged

Feature Test#81
zigzagdev merged 1 commit intofeature/central-asiafrom
feature/central-asia-test

Conversation

@zigzagdev
Copy link
Copy Markdown
Owner

what i have done

  • feature tests fixed

@zigzagdev zigzagdev requested a review from Copilot August 27, 2025 06:57
@zigzagdev zigzagdev self-assigned this Aug 27, 2025
@zigzagdev zigzagdev linked an issue Aug 27, 2025 that may be closed by this pull request
@zigzagdev zigzagdev merged commit b23daf6 into feature/central-asia Aug 27, 2025
1 check passed
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes feature tests for world heritage creation functionality. The changes primarily update test data from Japanese heritage sites to transnational European and Asian heritage sites, add database seeding for countries, and update parameter mappings.

  • Updated test data to use transnational heritage sites with multiple state parties
  • Added country seeding and additional table truncation in test setup/teardown
  • Fixed parameter mapping from 'state_party_codes' to 'state_parties' in the factory

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
CreateManyWorldHeritagesTest.php Updated test data structure, added country seeding, and expanded database cleanup
CreateWorldManyHeritagesUseCase.php Added state party codes and metadata parameters to heritage creation
WorldHeritageListQueryFactory.php Fixed parameter mapping from 'state_party_codes' to 'state_parties'

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

'unesco_site_url' => 'https://whc.unesco.org/en/list/660/',
'unesco_site_url' => 'https://whc.unesco.org/en/list/1133/',
'state_parties' => [
'AL','AT','BE','BA','BG','HR','CZ','FR','DE','IT','MK','PL','RO','SK','SI','ES','CH','UA'
Copy link

Copilot AI Aug 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The long array of country codes on a single line reduces readability. Consider formatting this as a multi-line array with one or a few codes per line for better maintainability.

Suggested change
'AL','AT','BE','BA','BG','HR','CZ','FR','DE','IT','MK','PL','RO','SK','SI','ES','CH','UA'
'AL', 'AT', 'BE', 'BA',
'BG', 'HR', 'CZ', 'FR',
'DE', 'IT', 'MK', 'PL',
'RO', 'SK', 'SI', 'ES',
'CH', 'UA'

Copilot uses AI. Check for mistakes.
@zigzagdev zigzagdev deleted the feature/central-asia-test branch August 27, 2025 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Test fix

2 participants