update Chinese translation at section Lookaround #178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imba-tjd
reviewed
Oct 30, 2019
translations/README-cn.md
Outdated
|
|
||
| 先行断言和后发断言都属于**非捕获簇**（不捕获文本 ，也不针对组合计进行计数）。 | ||
| 先行断言用于判断所匹配的格式是否在另一个确定的格式之前，匹配结果不包含该确定格式（仅作为约束）。 | ||
| 先行断言和后发断言（也叫 lookaround）都属于**非捕获组**（用于匹配模式，但不包括在匹配列表中）。当我们需要一个模式的前面或后面有另一个特定的模式时，就可以使用它们。 |
Contributor
There was a problem hiding this comment.
这里改成（合称为 lookaround） 比较好，否则可能让人误会后发断言是lookaround
imba-tjd
reviewed
Oct 30, 2019
translations/README-cn.md
Outdated
| <pre> | ||
| "/(.*at)/" => <a href="#learn-regex"><strong>The fat cat sat on the mat</strong></a>. </pre> | ||
| "/(.*at)/" => <a href="#learn-regex"><strong>The fat cat sat on the mat</strong></a>. | ||
| </pre> |
Contributor
Author
There was a problem hiding this comment.
内容没修改，只是样例的格式调了一下，把 </pre> 换到下一行了
Contributor
Author
There was a problem hiding this comment.
这个，<pre> 标签是用来预格式化的文本，原版这个样例的确没换行。比较其他的，比较长的样例都会单独放换行的...，这个主要是原版的头 <pre> 是一行的，换了会对称一些... 这是为了直接看 markdown 文档的话不会有点怪，效果没差
Contributor
There was a problem hiding this comment.
真要改也应该单独开一个PR把所有语言的都改了啊。反正我的意见是这种东西应该与原文一致。
imba-tjd
approved these changes
Oct 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.