Fix typos #94
Fix typos #94
Conversation
| ## What is Regular Expression? | ||
|
|
||
| > Regular expression is a group of characters or symbols which is used to find a specific pattern from a text. | ||
| > Regular expression is a group of characters or symbols which are used to find a specific pattern from a text. |
There was a problem hiding this comment.
I think that this changed is wrong...
For me is correct way is:
Regular expression is a group of characters or symbols which is used to find a specific pattern from a text.
Because the group (just one group) is used to find a specific pattern
There was a problem hiding this comment.
I agree with @eamanu.
TBH though, you could probably drop the which (is|are) part from that sentence and it'd still read in the same way and be perfectly acceptable anyhow:
A regular expression is a group of characters or symbols used to find a specific pattern from a text.
There was a problem hiding this comment.
Thanks but we will stick with which is because it fits more in our context
| In regular expressions, we use anchors to check if the matching symbol is the | ||
| starting symbol or ending symbol of the input string. Anchors are of two types: | ||
| First type is Caret `^` that check if the matching character is the start | ||
| First type is Caret `^` that checks if the matching character is the start |
| The `m` modifier is used to perform a multi-line match. As we discussed earlier | ||
| anchors `(^, $)` are used to check if pattern is the beginning of the input or | ||
| end of the input string. But if we want that anchors works on each line we use | ||
| end of the input string. But if we want that anchors work on each line we use |
There was a problem hiding this comment.
Somewhat better:
But if we want anchors to work on each line (...)
|
PR was originally submitted 4th September, so, it has been a little over a month now. Some changes are good, but more changes have been suggested/requested, which haven't yet been committed to the PR branch. Would it be worth sending a new PR to implement the suggested/requested changes (replacing this PR), or better to wait? If the original PR author isn't interested in this PR anymore, I could write a new PR to implement the suggested/requested changes, but doing so would create conflicts for the original PR, and, if the original PR author is still interested in this PR, writing a new PR that could cause conflicts for the original PR might seem a little rude, so, I thought I should ask first. :-) |
|
@Maikuolan I think that is better that you submit the PR. Can you? |
|
@Maikuolan @eamanu Please send a new PR and close this. Thank you :) |
|
Yep, I can do that. :-) |
|
Excelent @Maikuolan |
|
can somebody pick this PR and do the above-requested changes and resolve the conflicts. Thanks |
4 participants
No description provided.