Encode string once and reuse for subsequent calls #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For times when apps use same string multiple times with
findNextMatchetc, it is very expensive to run UTF8 encoding over and over.For such cases, it is now advised to create an instance of
OnigStringand keep it referenced. Then, pass thatOnigStringref tofindNextMatchinstead of literal strings for better performance.Following code was run against
onigasm@2.0(before) and current patch (after):Before (onigasm@2.0)
After (current patch)