Skip to content

fix(relay): keep stale routes from closing pairing#47

Merged
zikolach merged 2 commits into
mainfrom
fix/stale-route-pairing-screen
May 15, 2026
Merged

fix(relay): keep stale routes from closing pairing#47
zikolach merged 2 commits into
mainfrom
fix/stale-route-pairing-screen

Conversation

@zikolach
Copy link
Copy Markdown
Owner

Summary

  • prevent stale route-local notifications from closing a newer active pairing QR screen
  • keep pairing QR teardown after route live-context verification
  • add integration coverage for stale route notification versus active route notification

Validation

  • npm run typecheck
  • npm test

OpenSpec validation skipped: follow-up bugfix is not tied to an active OpenSpec implementation change.

Copilot AI review requested due to automatic review settings May 15, 2026 09:03
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes relay pairing QR teardown so stale route-local notifications no longer close a newer active pairing screen, while preserving teardown when the active route reports a pairing notification.

Changes:

  • Moved QR screen closure until after route live-context verification.
  • Added integration coverage for stale versus active route-local notifications affecting pairing UI.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
extensions/relay/runtime/extension-runtime.ts Ensures notifyLocal only closes the active pairing QR screen after confirming the route still has a live context.
tests/integration.test.ts Extends stale route-local action coverage to verify stale notifications do not close the active QR screen, while active notifications do.

Comment thread tests/integration.test.ts Outdated
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

@zikolach zikolach merged commit aeac22e into main May 15, 2026
6 checks passed
@zikolach zikolach deleted the fix/stale-route-pairing-screen branch May 15, 2026 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants