fix(doris): support IVF on disk index properties#768
Open
zhiqiang-hhhh wants to merge 2 commits intozilliztech:mainfrom
Open
fix(doris): support IVF on disk index properties#768zhiqiang-hhhh wants to merge 2 commits intozilliztech:mainfrom
zhiqiang-hhhh wants to merge 2 commits intozilliztech:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: zhiqiang-hhhh The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--index-prop, including future Doris index types and index-specific options.ivf_on_diskindex creation by ensuringnlistis preserved and forwarded through Doris SDK ANN properties.Motivation
Doris supports more ANN index types than HNSW, and new index properties may be added in Doris without requiring VectorDBBench changes. Previously the Doris client validated index types locally and only handled HNSW/IVF paths, which made
ivf_on_diskand future index properties fragile.This PR makes Doris index configuration more forward-compatible by treating unknown index types and unmapped index options as passthrough properties.
Changes
index_typeand default it tohnswwhen omitted.index_propertiesbefore applying known convenience fields.nlistfor known IVF index types:ivfandivf_on_disk.IndexOptions.ann_propertiesorIndexOptions.properties.ann_propertiesandproperties.--index-prop index_type=...usage with anivf_on_diskexample.Testing
python -m compileall -q vectordb_bench/backend/clients/dorisgit diff --check