feat: [2.6] cherrypick DiskANN GPU build support#1617
Merged
sre-ci-robot merged 3 commits intoMay 6, 2026
Conversation
* Add GPU support for building DISKANN based indexes. Signed-off-by: Lior Friedman <lior.friedman@il.kioxia.com> Signed-off-by: Hiroshi Murayama <hiroshi4.murayama@kioxia.com> * Add new diskann_gpu files. Signed-off-by: Lior Friedman <lior.friedman@il.kioxia.com> Signed-off-by: Hiroshi Murayama <hiroshi4.murayama@kioxia.com> * After maintainer code review comments Signed-off-by: Lior Friedman <lior.friedman@il.kioxia.com> Signed-off-by: Hiroshi Murayama <hiroshi4.murayama@kioxia.com> * rephrase GPU R and L validation Signed-off-by: Lior Friedman <lior.friedman@il.kioxia.com> Signed-off-by: Hiroshi Murayama <hiroshi4.murayama@kioxia.com> --------- Signed-off-by: Lior Friedman <lior.friedman@il.kioxia.com> Signed-off-by: Hiroshi Murayama <hiroshi4.murayama@kioxia.com> (cherry picked from commit 20b6dce) Signed-off-by: marcelo-cjl <marcelo.chen@zilliz.com>
) * After maintainer more code review comments Signed-off-by: Lior Friedman <lior.friedman@il.kioxia.com> * fix invalid GPU params UT Signed-off-by: Lior Friedman <lior.friedman@il.kioxia.com> * rename local use_gpu param Signed-off-by: Lior Friedman <lior.friedman@il.kioxia.com> --------- Signed-off-by: Lior Friedman <lior.friedman@il.kioxia.com> (cherry picked from commit 12f08a9) Signed-off-by: marcelo-cjl <marcelo.chen@zilliz.com>
…#1518) * Attempt to fix cuvs memory access error Signed-off-by: jamesgao-jpg <james.gao@zilliz.com> * Suppress cuVS diag 550 to fix GPU build with -Werror cuVS's ConfigureCUDA.cmake sets -Werror=all-warnings, which promotes an unused-variable warning (diag 550) in robust_prune.cuh to a build error. Add --diag-suppress 550 to CMAKE_CUDA_FLAGS so the warning is silenced before cuVS is configured. Signed-off-by: jamesgao-jpg <james.gao@zilliz.com> * Refactor GPU/CPU fallback logic in partition_and_pq.cpp Replace combined condition with nested if-else for clarity: check is_gpu_available() first, then guard against num_centers > num_train inside the GPU block. Signed-off-by: jamesgao-jpg <james.gao@zilliz.com> --------- Signed-off-by: jamesgao-jpg <james.gao@zilliz.com> (cherry picked from commit b023194) Signed-off-by: marcelo-cjl <marcelo.chen@zilliz.com>
marcelo-cjl
force-pushed
the
cherrypick-diskann-gpu-2.6
branch
from
d37c2db to
0a61306
Compare
Collaborator
|
/kind improvement |
Collaborator
|
/lgtm |
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexanderguzhva, foxspy, marcelo-cjl The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue: #1616
Cherrypick DiskANN GPU build support to the
2.6branch.Summary
2.6.Test plan
conan install .. --build=missing -o with_ut=True -o with_cuvs=True -o with_diskann=True -s compiler.libcxx=libstdc++11 -s build_type=Releaseconan build ..LD_LIBRARY_PATH="$PWD/build/Release:$PWD/build/Release/_deps/cuvs-build:${LD_LIBRARY_PATH}" ./build/Release/tests/ut/knowhere_tests "Test DiskANN Build Index" --success --durations yesLD_LIBRARY_PATH="$PWD/build/Release:$PWD/build/Release/_deps/cuvs-build:${LD_LIBRARY_PATH}" ./build/Release/tests/ut/knowhere_tests "Test DiskANNIndexNode." --reporter compact --durations yesLD_LIBRARY_PATH="$PWD/build/Release:$PWD/build/Release/_deps/cuvs-build:${LD_LIBRARY_PATH}" ./build/Release/tests/ut/knowhere_tests "Test DISKANN for EmbList" --reporter compact --durations yesLD_LIBRARY_PATH="$PWD/build/Release:$PWD/build/Release/_deps/cuvs-build:${LD_LIBRARY_PATH}" ./build/Release/tests/ut/knowhere_tests "Test DiskANN GetVectorByIds" --reporter compact --durations yesNotes
560.35.05.Running pq with 256 clusters, pq 16 ...using GPU!andBuilding with GPU! R= 64 L=128.